Page MenuHomePhabricator

D2. Flow: subst'd templates aren't subst'd (CA)
Closed, ResolvedPublic

Description

Currently, a {{subst:template}} is not getting subst'd properly. It just appears as plaintext.
2 examples at https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Flow/Developer_test_page&workflow=rw60o5ujcgk6sn8f

(See [[m:Help:Substitution]] for technical specs)


Version: unspecified
Severity: normal
URL: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Flow/Developer_test_page&workflow=rw60o5ujcgk6sn8f

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:24 AM
bzimport set Reference to bz66307.
bzimport added a subscriber: Unknown Object (MLST).

@Gerardduenas Thanks for bumping this ticket. We'll talk about it at the team's next estimation meeting.

DannyH renamed this task from Flow: subst'd templates aren't subst'd to Flow: subst'd templates aren't subst'd (CA).Jun 11 2015, 9:10 PM
DannyH set Security to None.

Parsoid API now has support for subst-ing of templates ( https://gerrit.wikimedia.org/r/#/c/208993/ ) which Flow could use for this purpose. We are yet to update our API docs.

Change 218574 had a related patch set uploaded (by Catrope):
Run pre-save transform on wikitext before saving it

https://gerrit.wikimedia.org/r/218574

And please check
to in header of a topic when creating or changing first subst transform , and then save

see subst:CONTENTLANG in https://ru.wikipedia.org/wiki/%D0%A2%D0%B5%D0%BC%D0%B0:Shhqnuw5kngudt55

DannyH renamed this task from Flow: subst'd templates aren't subst'd (CA) to D2. Flow: subst'd templates aren't subst'd (CA).Jun 16 2015, 7:21 PM

Change 218574 merged by jenkins-bot:
Run pre-save transform on wikitext before saving it

https://gerrit.wikimedia.org/r/218574

Checked on http://en.wikipedia.beta.wmflabs.org/wiki/.

{{subst:#ifeq:{{subst:CONTENTLANG}}|en||''Apologies for writing in English, please help translate this into your local language.''}}

results in

Screen Shot 2015-06-17 at 3.52.45 PM.png (285×955 px, 51 KB)

However, I am not sure that the following is expected:

  • {{subst:Discussió:ET1}} results in the error message <span class="error">Discussions cannot be embedded yet.</span>
  • {{subst:Portada}} results in
{{Introducció de la portada}}
{| border="0" style="margin-top: 5px;"
| width="60%" valign="top" style="padding-right: 5px;" |
{{Metacaixa elements enciclopèdics a la portada|
|{{{1}}}=seleccionada
|Secció={{{1}}}
|Dependència={{{2}}}
}}{{Metacaixa elements sobre la Viquipèdia a la portada|
|{{{2}}}=seleccionada
|Secció={{{2}}}
|Dependència={{{1}}}
}}
| width="40%" valign="top" style="padding-left: 5px;" | {{Categories|una columna}}
|}
__NOTOC__ __NOEDITSECTION__

Unfortunately, Forrestbot was wrong (T103291: Forrestbot posted wrong release branch).

This is not in any release branches yet.

Also, it will not apply to topic titles like https://ru.wikipedia.org/wiki/%D0%A2%D0%B5%D0%BC%D0%B0:Shhqnuw5kngudt55 . Flow topic titles do not support wikitext.

However, I am not sure that the following is expected:

  • {{subst:Discussió:ET1}} results in the error message <span class="error">Discussions cannot be embedded yet.</span>

This is expected. Subst-ing in a Flow board is not possible. Transcluding a discussion could make sense (but would require some careful consideration of the feature), but substing probably wouldn't.

  • {{subst:Portada}} results in

This template probably just isn't intended to be subst-ed. But that template doesn't exist, and I don't get that result at either http://en.wikipedia.beta.wmflabs.org/wiki/Topic:Sjoxzoqv6drmilg8 or http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Sandbox&oldid=229341