Principal software engineer at WMF
User Details
User Details
- User Since
- Nov 6 2014, 11:05 PM (524 w, 1 d)
- Availability
- Available
- IRC Nick
- jdlrobson
- LDAP User
- Unknown
- MediaWiki User
- Jdlrobson [ Global Accounts ]
Today
Today
Jdlrobson added a project to T380645: Language setting is ignored when rendering SVGs in Page Previews: Page Content Service.
There is code in MultimediaViewer that can be made use of here. Needs changes in API first before it can be used in client.
Please report this to the talk page. The template does not appear to be compatible with page previews. Thanks in advance!
Jdlrobson added a comment to T380669: Add Wikipedia YIR to translatewiki.net.
I am still working on qqq.json but that should be up shortly. :)
Yesterday
Yesterday
Jdlrobson closed T380558: LogEventsList:showLogExtract uses Codex markup without appropriate style pack as Resolved.
Jdlrobson added a comment to T369950: Application Security Review Request : Chart extension and chart-renderer service.
Thanks @mmartorana for the assessment ! Happy to hear this is low risk.
Jdlrobson changed the point value for T380507: Move code for Typeahead Search into core from 3 to 5.
Jdlrobson added a comment to T266361: Reduce ResourceLoader modules used in Minerva..
No need for QA.
Fri, Nov 22, 5:35 PM · Web-Team, Web-Team-Backlog (FY2024-25 Q2 Sprint 5), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Web Team Essential Work 2024, Wikimedia-Performance-recommendation, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), patch-welcome, MinervaNeue, Technical-Debt
Jdlrobson changed the status of T380554: Jumping search box at specific sizes at Wikispecies from Open to Stalled.
Jdlrobson added a comment to T378095: [Spike] Do people use the search within page button.
Ok modified the query and managed to run in on the latest snapshot
Jdlrobson moved T378095: [Spike] Do people use the search within page button from Ready for Development to In Progress on the Web-Team (FY2024-25 Q2 Sprint 4 (Nov 13 - Nov 26, 2024)) board.
As a proxy for search within pages we can look at uri_query in the webrequest table for a given hour using https://superset.wikimedia.org/sqllab.
The queries constructed on mobile and desktop are slightly different. Mobile URLs will always begin "?fulltext=search" and desktop "?fulltext=1"
To avoid timeout issues I've limited results to a single hour. on a single day on en.wikipedia.org but I am currently getting server errors so can't get these queries to complete. @jwang / @KSarabia-WMF any chance these queries work for you?
Jdlrobson added a comment to T230812: Use native image lazy loading on mobile site in Parsoid.
Yep just beta testing. The fix will go out next Thursday!
Jdlrobson added a comment to T380554: Jumping search box at specific sizes at Wikispecies.
I am going to need more information as I can't reproduce on Mac OS with Chrome or Firefox. Is it possible you have some browser extension running additional styles on the page in incognito mode (just want to rule that out!)?
Jdlrobson closed T380547: Printable page uses Codex markup without appropriate style pack as Resolved.
Is this just wikispecies or does it also apply to commons? I presume this occurs because of the ULS button but I havent had time to check.
Thu, Nov 21
Thu, Nov 21
Jdlrobson updated the task description for T380553: Search page uses Codex markup without appropriate style pack.
Jdlrobson added a comment to T380509: Update Vector 2022 to use core TypeaheadSearch.
Legacy code would not be removed as part of this ticket due to caching. I added a sign off step with that in mind. I wouldn't be adverse to 2. My thinking for 3 was this is highly visible and a revert would be a pain, so factoring that in to the point score.
Jdlrobson updated the task description for T380509: Update Vector 2022 to use core TypeaheadSearch.
Jdlrobson added a comment to T379167: Some UI components overlap the Vector 2022 menus.
Since this relates to content, this is typically out of scope for web team and a difficult problem to address universally. It doesn't make sense to fix this on the platform level.
Jdlrobson updated the task description for T375287: Identify pages that rely on Codex message box but do not explicitly add Codex styles to the page.
Jdlrobson added a comment to T375287: Identify pages that rely on Codex message box but do not explicitly add Codex styles to the page.
According to logging about 70k pages every 15 mins are rely on this behaviour
https://logstash.wikimedia.org/goto/1bd455888d36e19ddb5476db1257d36b
Jdlrobson moved T379833: Add basic instrumentation for when a chart is viewed from Doing to Ready for Signoff on the Charts (Sprint 11) board.
Jdlrobson moved T369684: Add tracking category for pages with Charts from Code Review to Ready for Signoff on the Charts (Sprint 11) board.
Jdlrobson added a comment to T378100: [Spike] Functional + Design comparison of Typeahead search vs Mobile Search.
To clarify timeline, yes this would all be for Q3 (we might do stage 1 and 2 this quarter depending on bandwidth and what Olga things)
Jdlrobson added a comment to T378420: Request: Research viability of us Reading List data for recommendations.
Perfect.
Jdlrobson updated the task description for T380507: Move code for Typeahead Search into core.
Jdlrobson updated the task description for T380507: Move code for Typeahead Search into core.
Jdlrobson updated the task description for T266361: Reduce ResourceLoader modules used in Minerva..
Thu, Nov 21, 5:45 PM · Web-Team, Web-Team-Backlog (FY2024-25 Q2 Sprint 5), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Web Team Essential Work 2024, Wikimedia-Performance-recommendation, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), patch-welcome, MinervaNeue, Technical-Debt
Jdlrobson triaged T380429: TypeError: Cannot read properties of undefined (reading 'then') at maybeShowWelcomeDrawer as Medium priority.
Tagging as medium for now. Please let me know if you change your mind and it does warrant an earlier backport.
Jdlrobson added a comment to T380338: [mobile] Homepage - Uncaught TypeError: welcomeDrawer.show() is undefined.
Note: in the revert I updated the code to make it clearer that GrowthExperiments is using this, so the same mistake is not made again. Apologies, this was very avoidable, Ed's patch looked harmless but there was no urgency to merge it on my part. At least this relationship is a lot clearer now.
Jdlrobson changed the point value for T380510: Update Minerva to use new core Codex TypeaheadSearch from 3 to 5.
Upped to 5, with new feature flag requirement.
Jdlrobson updated the task description for T380510: Update Minerva to use new core Codex TypeaheadSearch.
(3 assumes that in the event of any unexpected issues we stop working on this and work on a new task to unblock it)
Jdlrobson set the point value for T380510: Update Minerva to use new core Codex TypeaheadSearch to 3.
(3 assumes that in the event of any unexpected issues we stop working on this and work on a new task to unblock it)
Jdlrobson renamed T380328: [Spike] Consider whether "search within pages" should appear at top for Typeahead Search on mobile from Consider whether "search within pages" should appear at top for Typeahead Search on mobile to [Spike] Consider whether "search within pages" should appear at top for Typeahead Search on mobile.
Jdlrobson added a project to T380327: [SPIKE] Consider touch areas for Typeahead search on mobile: Web-Team.
Jdlrobson set the point value for T380327: [SPIKE] Consider touch areas for Typeahead search on mobile to 2.
Jdlrobson set the point value for T380326: Add icon button to Typeahead Search to clear search suggestions to 5.
Jdlrobson set the point value for T379861: Remove unused performance metrics from Vector search instrumentation.js and mediawiki.page.ready to 2.
Jdlrobson lowered the priority of T380508: Upstream search toggle code to core from Vector from High to Medium.
Jdlrobson renamed T380507: Move code for Typeahead Search into core from Move code for Typeahead Search into Codex to Move code for Typeahead Search into core.
Jdlrobson reassigned T378100: [Spike] Functional + Design comparison of Typeahead search vs Mobile Search from Jdlrobson to ovasileva.
@bwang myself and @JScherer-WMF synced and I think it's clear what the next steps are.
Jdlrobson renamed T282473: [GOAL] Use the Codex search widget inside the mobile and desktop site from [GOAL] Use the Codex search widget inside the mobile site to [GOAL] Use the Codex search widget inside the mobile and desktop site.
Jdlrobson renamed T379861: Remove unused performance metrics from Vector search instrumentation.js and mediawiki.page.ready from Remove unused performance metrics from Vector search instrumentation.js to Remove unused performance metrics from Vector search instrumentation.js and mediawiki.page.ready.
Jdlrobson triaged T380327: [SPIKE] Consider touch areas for Typeahead search on mobile as Medium priority.
Jdlrobson triaged T380326: Add icon button to Typeahead Search to clear search suggestions as High priority.
Jdlrobson added a comment to T380429: TypeError: Cannot read properties of undefined (reading 'then') at maybeShowWelcomeDrawer.
@Michael is this impacting users? If so I can try to get it backported today.
Wed, Nov 20
Wed, Nov 20
Jdlrobson added a comment to T378420: Request: Research viability of us Reading List data for recommendations.
That sounds great.
I think the big open question here is do we currently have access to the raw database table in the replicas in MariaDB (and if not how do we enable that or get a dump of that data to look at).
Jdlrobson renamed T379352: Evaluate and provide feedback on itwiki automatic night mode color-darkening from Feedback on itwiki automatic night mode color-darkening to Evaluate and provide feedback on itwiki automatic night mode color-darkening.
Jdlrobson edited projects for T379352: Evaluate and provide feedback on itwiki automatic night mode color-darkening, added: Web-Team; removed Web-Team (FY2024-25 Q2 Sprint 4 (Nov 13 - Nov 26, 2024)).
Hey there, we need some time to verify the impact of this change, so for now we've disabled dark mode for anonymous users.
Jdlrobson triaged T380430: TypeError: Cannot read properties of undefined (reading 'replace') at Object.percentDecodeFragment as Low priority.
Ack likely MobileFrontend's given Minerva onClickImage in stack trace:
https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/d2abd0d2e88d2d0d81f37fadc0d7fffd5619eb4a/src/mobile.startup/PageHTMLParser.js#189
Jdlrobson added a comment to T380429: TypeError: Cannot read properties of undefined (reading 'then') at maybeShowWelcomeDrawer.
Error also occurring as TypeError: undefined is not an object (evaluating 'welcomeDrawer.show().then')
Jdlrobson updated the task description for T380429: TypeError: Cannot read properties of undefined (reading 'then') at maybeShowWelcomeDrawer.
Jdlrobson updated the task description for T266361: Reduce ResourceLoader modules used in Minerva..
Wed, Nov 20, 10:48 PM · Web-Team, Web-Team-Backlog (FY2024-25 Q2 Sprint 5), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Web Team Essential Work 2024, Wikimedia-Performance-recommendation, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), patch-welcome, MinervaNeue, Technical-Debt
Jdlrobson reassigned T378101: [Spike] Decide where recommendations code should live from Jdlrobson to ovasileva.
TDLR: We'll add the experiment in RelatedArticles.
Jdlrobson renamed T378117: Search A/B test: Add MoreLike-based article suggestions when activating search bar in mobile from Search A/B test: Add MoreLike-based article suggestions when activating search bar in mobile to Search A/B test: Add MoreLike-based article suggestions to RelatedArticles when activating search bar in mobile.