Principal software engineer at WMF
User Details
- User Since
- Nov 6 2014, 11:05 PM (514 w, 4 d)
- Availability
- Available
- IRC Nick
- jdlrobson
- LDAP User
- Unknown
- MediaWiki User
- Jdlrobson [ Global Accounts ]
Today
Thanks! This survey is only meant to be running on https://en.wikipedia.beta.wmflabs.org as that's the only environment where the messages have been defined so best solution here is to disable the survey for other betas.
Yesterday
Thanks @Pcoombe
@SToyofuku-WMF we intentionally broke this behaviour, but don't seem to have documented it as an ADR.
We consider this a bug on wiki now - we should probably have a Special:LintError rule for it so community know they need to fix it.
I'll DM you when I find the link.
@Jdlrobson - also curious why we looked at wikivoyage specifically - is this related to our upcoming experiment in any way?
French does not have a Beta but German does.
For now this behaviour is intentional. This would need to reference branding guidelines to be changed. Some logos are intentionally displayed always on the same colored background and there is no clear guidance as far as I can see about how our logos should appear in dark mode.
Great! I looked at the configuration though and it seems like all namespaces on Russian Wikipedia are enabled? Am I missing something? Is there a specific URL you can point me to that is not working in dark mode?
I think the bug report has always been about the no-ULS experience (ULS not installed, disabled in preferences, or unavailable due to lack of JS), so I don’t think so. I’m not even sure why you added the UniversalLanguageSelector tag back then.
Because ULS modifies this menu and https://gerrit.wikimedia.org/r/851592 fixed it.
Fri, Sep 13
I took a first stab at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Chart/+/1072630 but I don't think it covers the following points:
- Why we chose shelling out over other approaches
- How and where data is loaded, and why
Could you please help me expand it?
Thanks for jumping on this so quickly and the explanation! I can wait until https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1072781 gets deployed - I can confirm this addresses the issue!
Sounds good!
I'll let you sign this off given it concerns the work we'll be doing next sprint!
I've created T374743 to disable the surveys! Nice job all!
Should be testable on beta cluster shortly.
Worth a follow up tickeT?
@simon04 I would be concerned about taking away a feature. On mobile I think it's particularly important given sections are collapsed by default and it allows a way to cycle through all the images in the page. Perhaps as a compromise we could add the link but hide it at the desktop breakpoint so that it appears for mobile but not desktop?
@stoyofoku I think the scope of this has changed significantly enough to warrant a new ticket. We have fixed one margin issue only to uncover another.
Regarding AC2 talk pages and images are out of scope for this change! So this is a pass!
I would be making it possible to enable the desktop MMV on mobile and running some synthetic tests.
(behaviour on https://ca.wikisource.org is working as expected for me)
@Edtadros is it possible you have it enabled via GlobalPreferences. Could you create a new account to verify this behaviour? If you have a new account you should NOT be seeing dark mode on any of these sister projects for logged in or anonymous users.
Hi, @Volker_E the main issue here is that the checkbox hack is not compatible with Codex buttons so hover states are broken. This component also needs to work with JavaScript disabled. When we talked to DST before they recommended using details/summary.
@bwang @KSarabia-WMF I know we have aria-labels for most of this - any reason we don't have title as well?
I'd rather focus on removing the need to strip HTML from MobileFrontend. In production the main reason for this feature's existence is navboxes given it cannot even be rendered correctly on mobile (needs an update to template) and constitutes 1/3 of the HTML payload for many pages.
This bug still exists if UniversalLanguageSelector is not installed on a wiki and/or JavaScript is disabled.
Lowering priority since this project is finished.