Change Details

According to [[ https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/docs/change-op-serializations.wiki$43 | the docs ]], "you can either add or remove aliases individually, or send the full set of aliases for a language". But it seems like sending the full set of aliases is not supported if the set is empty? **Steps to reproduce:** Make a wbeditentity request with data set to `{"aliases":{"en":[]}}` **Actual result:** No changes are made. **Expected result:** Existing English aliases are removed. **Deployment Blocker** We have to check whether this is to be qualified as a breaking change or not, and follow the proper process accordingly. **Hints** Probably a good place to start is: \Wikibase\Repo\ChangeOp\Deserialization\AliasesChangeOpDeserializer::getIndexedAliasesChangeOps

According to [[ https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/docs/change-op-serializations.wiki$43 | the docs ]], "you can either add or remove aliases individually, or send the full set of aliases for a language". But it seems like sending the full set of aliases is not supported if the set is empty? **Steps to reproduce:** Make a wbeditentity request with data set to `{"aliases":{"en":[]}}` **Actual result:** No changes are made. **Expected result:** Existing English aliases are removed. **Deployment Blocker** This change will be announced as a breaking change to avoid tools that has been using the current behavior in any way from starting to delete aliases unintentionally. **Hints** Probably a good place to start is: \Wikibase\Repo\ChangeOp\Deserialization\AliasesChangeOpDeserializer::getIndexedAliasesChangeOps

According to [[ https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/docs/change-op-serializations.wiki$43 | the docs ]], "you can either add or remove aliases individually, or send the full set of aliases for a language". But it seems like sending the full set of aliases is not supported if the set is empty? **Steps to reproduce:** Make a wbeditentity request with data set to `{"aliases":{"en":[]}}` **Actual result:** No changes are made. **Expected result:** Existing English aliases are removed. **Deployment Blocker** We have to check whether this is to be qualified as a breaking change or not, and follow the proper process accordingThis change will be announced as a breaking change to avoid tools that has been using the current behavior in any way from starting to delete aliases unintentionally. **Hints** Probably a good place to start is: \Wikibase\Repo\ChangeOp\Deserialization\AliasesChangeOpDeserializer::getIndexedAliasesChangeOps