Page MenuHomePhabricator
Create Task
Maniphest T62307

VisualEditor: Cannot save a page after adding gallery to a page
Closed, ResolvedPublic
Actions

Description

Screenshot of the error

Steps to reproduce:

1.Open a page with VE
2.Add a gallery from Insert>Gallery or just simply close the inspector without adding anything.
3.Click on the "Save Page" button

Observed Result:

The page cannot be saved.

An error appears in the console:
Uncaught Error: InvalidCharacterError: DOM Exception 5

See the screenshot attached.

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Page:https://test2.wikipedia.org/w/index.php?title=Thedomtest&veaction=edit

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-01-21_at_10.45.24_AM.png (631×1 px, 108 KB)

Details

Reference
bz60307

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:53 AM
• bzimport added projects: VE-deploy-2014-01-30, VisualEditor-EditingTools.
• bzimport set Reference to bz60307.
Ryasmeen created this task.Jan 21 2014, 9:30 PM
• bzimport added a comment.Jan 22 2014, 12:03 PM

cmitasch wrote:

I can confirm the behaviour. It does not work in Chrome but it is working with Firefox 26.0.

gerritbot added a comment.Jan 27 2014, 9:46 PM

Change 109759 had a related patch set uploaded by Catrope:
Add .tagName to MWGalleryNode

https://gerrit.wikimedia.org/r/109759

gerritbot added a comment.Jan 27 2014, 10:34 PM

Change 109759 merged by jenkins-bot:
Add tagName to ve.dm.MWGalleryNode

https://gerrit.wikimedia.org/r/109759

Ryasmeen added a comment.Jan 28 2014, 12:43 AM

Verified the fix in betalabs.

Ryasmeen added a comment.Jan 30 2014, 11:26 PM

Verified the fix in mw.org and test2

gerritbot added a comment.Feb 2 2014, 12:06 AM

Change 110826 had a related patch set uploaded by Jforrester:
Add tagName to ve.dm.MWGalleryNode

https://gerrit.wikimedia.org/r/110826

gerritbot added a comment.Feb 3 2014, 11:38 PM

Change 110826 merged by jenkins-bot:
Add tagName to ve.dm.MWGalleryNode

https://gerrit.wikimedia.org/r/110826

Jdforrester-WMF added a project: VisualEditor.Nov 27 2014, 12:46 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits