Page MenuHomePhabricator

tablesorter and rowspans in headers
Closed, ResolvedPublic

Description

There is an issue with complicated tables, where there are two header rows, with rowspans on some of the header elements. When you try to sort, the tablesorter will 'explode' the rowspans, and it does this not only on tbody elements, but also on thead elements.

Suggest we change $table.find( '[rowspan]' ).each(function() to $table.find( 'tbody [rowspan]' ).each(function()

I'm not sure if that will work, but it might...


Version: 1.18.x
Severity: normal
URL: https://en.wikipedia.org/wiki/List_of_Manchester_United_F.C._players?debug=true

Details

Reference
bz31420

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:49 PM
bzimport set Reference to bz31420.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

There is an issue with complicated tables, where there are two header rows,
with rowspans on some of the header elements. When you try to sort, the
tablesorter will 'explode' the rowspans, and it does this not only on tbody
elements, but also on thead elements.

Suggest we change $table.find( '[rowspan]' ).each(function() to $table.find(
'tbody [rowspan]' ).each(function()

I'm not sure if that will work, but it might...

I'll give that a spin.

Fixed in r99092, will deploy shortly. Derk-Jan's suggestion was spot on, thanks!