(In reply to comment #0)

I just saw a situation on pt.wiki on which an user is blocked from editing
(sending mail and talk page editing disabled). Though account couldn't edit
talk page, he still could edit his IP talk page as it appear that autoblock
didn't stop it.

I know this seems obvious, but I have to ask just in case: was the block an auto-block (i.e., was the "Prevent editing from IP address" checkbox checked)?

I don't think this is necessarily a thing to change, because an IP may be mistakenly caught in an autoblock and would have to appeal the bug.

I meant "block", not "bug", sorry.

(In reply to comment #1)

(In reply to comment #0)

I just saw a situation on pt.wiki on which an user is blocked from editing
(sending mail and talk page editing disabled). Though account couldn't edit
talk page, he still could edit his IP talk page as it appear that autoblock
didn't stop it.

I know this seems obvious, but I have to ask just in case: was the block an
auto-block (i.e., was the "Prevent editing from IP address" checkbox
checked)?

Yes.

(In reply to comment #2)

I don't think this is necessarily a thing to change, because an IP may be
mistakenly caught in an autoblock and would have to appeal the bug.

That means that every vandal account that is blocked will be able to edit his talk page (as most blocks allow that). Then the sysop will prevent him from editing his talk page. Then he will unlog and edit his IP talk page. Then the sysop will have to block the IP. Isn't that too much? An autoblock takes only a day to end; the possible damage to autoblock is not that much.

The created autoblock gets no update on reblock, and so the changed param (talk page edit disabled) is not changed there.

Since some month each auto blocks knows it parent, so on reblock it should be possible to select all auto blocks for the current block and set the changed flags and save it.

(In reply to comment #6)

The created autoblock gets no update on reblock, and so the changed param
(talk
page edit disabled) is not changed there.

Since some month each auto blocks knows it parent, so on reblock it should be
possible to select all auto blocks for the current block and set the changed
flags and save it.

Wait, so this bug is about a block whose parameters were changed? Because that wasn't specified in the original report.

(In reply to comment #7)

(In reply to comment #6)

The created autoblock gets no update on reblock, and so the changed param
(talk
page edit disabled) is not changed there.

Since some month each auto blocks knows it parent, so on reblock it should be
possible to select all auto blocks for the current block and set the changed
flags and save it.

Wait, so this bug is about a block whose parameters were changed? Because
that
wasn't specified in the original report.

Yes. That is what I tried to say on second paragraph of first message; sorry if I couldn't.

Here is the block log: https://pt.wikipedia.org/w/index.php?title=Especial:Registo/block&page=Usu%C3%A1rio%3AMan%C3%ADaco+da+Cruz

--Teles
https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles

OK, I now understand and can confirm the bug. This occurs because on Special:Block when you update a block, it just deletes the old block and inserts a new one. May take a while to fix this one.

Was the autoblock logged as before or after the block modification?

(In reply to comment #10)

Was the autoblock logged as before or after the block modification?

15:03, 25 May 2013 (UTC) - First account block with permission to edit talk page.
15:04, 25 May 2013 (UTC) - Second account block without permission to edit talk page.
15:28, 25 May 2013 (UTC) - Unlogged edit on IP talk page.

So, account blocks occured before the unlogged edit.

--Teles
https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles

(In reply to comment #9)

OK, I now understand and can confirm the bug. This occurs because on
Special:Block when you update a block, it just deletes the old block and
inserts a new one. May take a while to fix this one.

Tyler, is it safe to say that if the first account block was set to disable talk page editing, the IP couldn't edit talk page when unlogged?

--Teles

(In reply to comment #2)

I don't think this is necessarily a thing to change, because an IP may be
mistakenly caught in an autoblock and would have to appeal the bug.

Jasper Deng, the MediaWiki default is to disallow talk page editing when blocked, so if anything, it should be disabled by default for autoblocks, and not enabled.

(In reply to comment #11)

(In reply to comment #10)

Was the autoblock logged as before or after the block modification?

15:03, 25 May 2013 (UTC) - First account block with permission to edit talk
page.
15:04, 25 May 2013 (UTC) - Second account block without permission to edit
talk
page.
15:28, 25 May 2013 (UTC) - Unlogged edit on IP talk page.

So, account blocks occured before the unlogged edit.

--Teles
https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles

Teles, so was the autoblock logged at 15:28, 25 May 2013 (UTC) as well?

Sorry... I don't know what do you mean by "autoblock logged".

--Teles

(In reply to comment #15)

Sorry... I don't know what do you mean by "autoblock logged".

--Teles

Don't autoblocks show up on the block list?

(In reply to comment #16)

(In reply to comment #15)

Sorry... I don't know what do you mean by "autoblock logged".

--Teles

Don't autoblocks show up on the block list?

I think they do; until they expire. I didn't check the log though.

(In reply to comment #14)

(In reply to comment #11)

(In reply to comment #10)

Was the autoblock logged as before or after the block modification?

15:03, 25 May 2013 (UTC) - First account block with permission to edit talk
page.
15:04, 25 May 2013 (UTC) - Second account block without permission to edit
talk
page.
15:28, 25 May 2013 (UTC) - Unlogged edit on IP talk page.

So, account blocks occured before the unlogged edit.

--Teles
https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles

Teles, so was the autoblock logged at 15:28, 25 May 2013 (UTC) as well?

An IP edit was done at 15:28; not the autoblock log.

--Teles

OK

(In reply to comment #12)

(In reply to comment #9)

OK, I now understand and can confirm the bug. This occurs because on
Special:Block when you update a block, it just deletes the old block and
inserts a new one. May take a while to fix this one.

Tyler, is it safe to say that if the first account block was set to disable
talk page editing, the IP couldn't edit talk page when unlogged?

--Teles

Yes. When an autoblock is generated, it inherits many of the properties of the original block, including talk page editing. But when the block is editing, the original block is deleted and re-created, and the autoblocks are never updated.

Related URL: https://gerrit.wikimedia.org/r/66366 (Gerrit Change I5403f6e1d7f8f07273cd5da8068b928fdddcdfc9)

You just need to be careful to not reduce an IP block due to an autoblock update. I mean, in case you block an IP for, say, a month, it should not be autoblocked for a day when we indef an account that was using this IP.

Change 66366 merged by jenkins-bot:
Make autoblocks update with the parent block

https://gerrit.wikimedia.org/r/66366

was successfully merged