Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] Add libseccomp requirement for rpm packages #266

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

thaJeztah
Copy link
Member

This requirement was originally added in 86f7649 (#75), but got removed in the migration to the new image-based packaging.

Commit f2ceca9 (#172) added this requirement back for .deb packages, but did not include the same changes for RPMs.

This patch adds back the requirement for RPM packages as well.

This requirement was originally added in 86f7649,
but got removed in the migration to the new image-based packaging.

Commit f2ceca9 added this requirement
back for `.deb` packages, but did not include the same changes for
RPMs.

This patch adds back the requirement for RPM packages as well.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

@andrewhsu andrewhsu added this to the 18.09.1 milestone Nov 28, 2018
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# yum --showduplicates list libseccomp # centos7
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: mirror.web-ster.com
 * extras: mirror.web-ster.com
 * updates: mirror.web-ster.com
Available Packages
libseccomp.i686                          2.3.1-3.el7                        base
libseccomp.x86_64                        2.3.1-3.el7                        base

@andrewhsu andrewhsu merged commit 9a7acfb into docker:18.09 Nov 28, 2018
@thaJeztah thaJeztah deleted the 18.09_add_seccomp_dependency branch November 28, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants