This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Fix error handling of incorrect --platform values #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#39527
Relates to docker/docker-py#2382 (comment)
errdefs: convert containerd errors to the correct status code
In situations where the containerd error is consumed directly
and not received over gRPC, errors were not translated.
Add regression tests for invalid platform status codes
Before we handled containerd errors, using an invalid platform produced a 500 status:
That problem is now fixed, and the API correctly returns a 4xx status:
This patch adds tests to validate the behaviour
- How to verify it
- Description for the changelog