Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] builder entitlements configuration added. #412

Conversation

thaJeztah
Copy link
Member

backport of moby#39144

relates to:

buildkit supports entitlements like network-host and security-insecure.
this patch aims to make it configurable through daemon.json file.
by default network-host is enabled & security-insecure is disabled.

- What I did
option to enable/disable buildkit's entitlements settings for moby
fixes part of issue discussed here moby/buildkit#950 (comment)

- How I did it
Added entitlements in builder config

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

buildkit supports entitlements like network-host and security-insecure.
this patch aims to make it configurable through daemon.json file.
by default network-host is enabled & secuirty-insecure is disabled.

Signed-off-by: Kunal Kushwaha <[email protected]>
(cherry picked from commit 8b7bbf1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 19.03.5 milestone Oct 22, 2019
@thaJeztah thaJeztah changed the title [19.03 backport] builder entitlements configutation added. [19.03 backport] builder entitlements configuration added. Oct 22, 2019
@thaJeztah
Copy link
Member Author

ping @tonistiigi @tiborvass PTAL - I think you mentioned this should be in 19.03

Copy link

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@andrewhsu andrewhsu merged commit 370def6 into docker-archive:19.03 Oct 28, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_builder_entitilement_confg branch October 28, 2019 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants