Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use the progress_bar_type argument in QueryJob.to_dataframe() #7616

Merged
merged 3 commits into from
Mar 30, 2019
Merged

Actually use the progress_bar_type argument in QueryJob.to_dataframe() #7616

merged 3 commits into from
Mar 30, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 29, 2019

Oops. Missed adding this in #7552.

@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Mar 29, 2019
@tswast tswast requested a review from crwilcox as a code owner March 29, 2019 16:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2019
tseaver
tseaver suggested changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a unit test which passes a non-default progress_bar_type, and asserts that it is propagated.

@tswast
Copy link
Contributor Author

tswast commented Mar 29, 2019

Needs a unit test which passes a non-default progress_bar_type, and asserts that it is propagated.

Done in 0b73e32.

@tseaver tseaver merged commit 28ad1a8 into googleapis:master Mar 30, 2019
@tswast tswast deleted the progress_bar branch April 1, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @tseaver @googlebot