Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery Snippets: Use autodetected location #8340

Merged
merged 2 commits into from
Jun 19, 2019
Merged

BigQuery Snippets: Use autodetected location #8340

merged 2 commits into from
Jun 19, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Jun 14, 2019 •
edited
Loading

This change update a BigQuery sample to show that the location field can be autodetected .

We can remove the location since it is now auto-detected.
See b/116968956.

@grant
b/116968956
2219886 
Remove location since it is now auto-detected.
@grant grant requested a review from a team June 14, 2019 18:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@alixhami
Copy link
Contributor

This is an open source repo. Please give descriptive titles to pull requests.

@grant grant changed the title b/116968956 BigQuery Snippets: Use autodetected location Jun 14, 2019
@busunkim96 busunkim96 added the api: bigquery Issues related to the BigQuery API. label Jun 14, 2019
@busunkim96
Copy link
Contributor

Container Analysis and Grafeas are failing because those libraries have not yet been merged.

@grant
Copy link
Contributor Author

grant commented Jun 15, 2019

Well, this PR is failing due to a totally unrelated outage? That is frustrating.

@grant
Copy link
Contributor Author

grant commented Jun 15, 2019

Can someone force run kokoro?

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2019
@tswast tswast merged commit c7cf8ef into googleapis:master Jun 19, 2019
@grant grant deleted the patch-1 branch June 19, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grant @alixhami @busunkim96 @tswast @googlebot @yoshi-kokoro