-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-exporting types for google-common #1271
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…bigquery into feat_api_error_export reconciling local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense to me. To we know if other libraries have that same kind of pattern ?
I'm pretty sure the other languages do not, but it is a pattern in TypeScript libraries in general. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1268 🦕
This PR introduces a re-exporting pattern to the library that allows for users to import
google-common
along withbigquery
. This option ensures that users' version ofgoogle-common
is the same as the one used in the BigQuery library. This is also a way to gauge the value of re-exporting dependencies in the library.