Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Authorized Dataset #1064

Closed
yongjiaw opened this issue Nov 16, 2021 · 5 comments · Fixed by #1075
Closed

Support Authorized Dataset #1064

yongjiaw opened this issue Nov 16, 2021 · 5 comments · Fixed by #1075
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@yongjiaw
Copy link

yongjiaw commented Nov 16, 2021

ENTITY_TYPES = frozenset(
[
"userByEmail",
"groupByEmail",
"domain",
"specialGroup",
"view",
"iamMember",
"routine",
]
)

Not sure about the reason to have restricted entities here.
We need to use authorized dataset, and got ValueError.
image

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 16, 2021
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 16, 2021
@tswast
Copy link
Contributor

tswast commented Nov 16, 2021

Not sure about the reason to have restricted entities here.

I agree that the client-side validation may be more trouble than its worth.

@tswast
Copy link
Contributor

tswast commented Nov 16, 2021

@yongjiaw I'm not seeing "dataset" listed here: https://cloud.google.com/bigquery/docs/reference/rest/v2/datasets#Dataset.FIELDS.access Is this a new / preview feature?

@yongjiaw
Copy link
Author

yongjiaw commented Nov 17, 2021

Not sure about the status of this feature, it's probably relatively new.
This is the only workaround to solve the problem of hitting the limit of 2500 authorized views per dataset.
https://cloud.google.com/bigquery/docs/authorized-datasets
https://cloud.google.com/bigquery/quotas#dataset_limits

@tswast
Copy link
Contributor

tswast commented Nov 17, 2021

Thanks @yongjiaw I've filed an issue 206825216 to our docs team to address the missing REST API docs.

@steffnay I think we want to remove the client-side validation of entity types and replace them with some enum values in https://github.com/googleapis/python-bigquery/blob/main/google/cloud/bigquery/enums.py for the folks that want some helpers to avoid typos.

@tswast
Copy link
Contributor

tswast commented Dec 14, 2021

This will be included in the next release, which is planned for January 4. We've paused releases in the meantime out of caution towards introducing changes around the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants