Add an update timestamp to trigger the creation of a revision when needed. #1364

rhuss · 2021-07-05T18:38:53Z

Add an update timestamp anytime a new revision should be triggered. Previously client-side revision names were this trigger but since we switched to server-side revision naming by default that didn't work anymore (and hasn't worked with server-side revision naming before, too).

Fixes #1318.

/lint

knative-prow-robot

@rhuss: 3 warnings.

In response to this:

Add an update timestamp anytime a new revision should be triggered. Previously client-side revision names were this trigger but since we switched to server-side revision naming by default that didn't work anymore (and hasn't worked with server-side revision naming before, too).

Fixes #1318.

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2021-07-05T18:39:02Z

pkg/serving/config_changes.go

@@ -41,8 +41,9 @@ const (
 )

 var (
-	UserImageAnnotationKey = "client.knative.dev/user-image"
-	ApiTooOldError         = errors.New("the service is using too old of an API format for the operation")
+	UserImageAnnotationKey       = "client.knative.dev/user-image"


Golint comments: exported var UserImageAnnotationKey should have comment or be unexported. More info.

pkg/serving/config_changes.go

codecov · 2021-07-05T18:43:12Z

Codecov Report

Merging #1364 (99661ff) into main (b05a111) will increase coverage by 0.09%.
The diff coverage is 81.15%.

@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   78.23%   78.33%   +0.09%     
==========================================
  Files         160      160              
  Lines        8246     8270      +24     
==========================================
+ Hits         6451     6478      +27     
+ Misses       1104     1103       -1     
+ Partials      691      689       -2

Impacted Files	Coverage Δ
pkg/kn/plugin/manager.go	`83.95% <ø> (ø)`
pkg/kn/commands/revision/describe.go	`50.61% <50.00%> (ø)`
pkg/serving/config_changes.go	`89.85% <72.00%> (+5.10%)`	⬆️
pkg/serving/revision_template.go	`90.90% <88.23%> (-3.04%)`	⬇️
...kg/kn/commands/service/configuration_edit_flags.go	`77.91% <100.00%> (+0.27%)`	⬆️
pkg/kn/commands/service/export.go	`81.48% <100.00%> (+0.46%)`	⬆️
pkg/kn/commands/service/update.go	`80.59% <100.00%> (+0.29%)`	⬆️
pkg/serving/v1/client.go	`82.85% <100.00%> (+0.99%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05a111...99661ff. Read the comment docs.

google-cla · 2021-07-15T13:05:09Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-15T19:48:14Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-16T05:51:27Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

…eviously client side revision names was this trigger but since we switched to server-side revision naming by default that didn't work anymore (and hasn't worked with server-side revision naming before, too). Fixes knative#1318.

rhuss · 2021-07-19T11:23:31Z

/retest

rhuss · 2021-07-19T14:52:46Z

/retest

pkg/serving/revision_template.go

pkg/serving/config_changes.go

rhuss · 2021-07-21T08:35:19Z

@dsimansk PTAL, added some tests and addressed the error return value issue.

dsimansk · 2021-07-21T15:29:45Z

@rhuss looks good. However lint check isn't happy.

  Error: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
  Error: SA5011: possible nil pointer dereference (staticcheck)
  Error: SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
  Error: SA5011: possible nil pointer dereference (staticcheck)
  Error: SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
  Error: SA5011: possible nil pointer dereference (staticcheck)
  Error: SA5011(related information): this check suggests that the pointer can be nil (staticcheck)

rhuss · 2021-07-23T08:00:56Z

@dsimansk thanks for the review. Really would love to catch those lint errors with our build script. Any idea ?

dsimansk · 2021-07-23T09:46:07Z

@dsimansk thanks for the review. Really would love to catch those lint errors with our build script. Any idea ?

Agreed, we should add it to the script. The initial run may take a bit longer ~20s, but then cache will speed subsequent runs up significantly. And it's a matter of executing:

golangci-lint run

knative-metrics-robot · 2021-07-26T13:38:11Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	85.0%	85.2%	0.2
pkg/kn/commands/service/export.go	87.6%	88.2%	0.6
pkg/kn/commands/service/update.go	86.7%	86.9%	0.2
pkg/serving/config_changes.go	92.1%	94.5%	2.5
pkg/serving/revision_template.go	97.0%	95.3%	-1.6
pkg/serving/v1/client.go	90.7%	91.0%	0.3

dsimansk · 2021-07-26T18:46:39Z

Thanks!

/approve
/lgtm

knative-prow-robot · 2021-07-26T18:46:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dsimansk,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021

google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 5, 2021

knative-prow-robot reviewed Jul 5, 2021

View reviewed changes

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2021

rhuss mentioned this pull request Jul 6, 2021

lock-to-digest help text default is backwards and doesn't seem to work #1329

Closed

knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2021

google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 15, 2021

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 15, 2021

rhuss added 2 commits July 16, 2021 07:56

Merge branch 'main' into pr/image-digest

fd15588

rhuss force-pushed the pr/image-digest branch from 77e6b02 to fd15588 Compare July 16, 2021 05:58

google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jul 16, 2021

fix e2e test

b542665

add some unit tests

3264f6f

dsimansk reviewed Jul 19, 2021

View reviewed changes

pkg/serving/revision_template.go Show resolved Hide resolved

dsimansk reviewed Jul 19, 2021

View reviewed changes

pkg/serving/config_changes.go Show resolved Hide resolved

Update error handling + added some tests

fcee305

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2021

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2021

Merge branch 'main' into pr/image-digest

8819408

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2021

fixed compile error in test

6f97cbb

rhuss added 2 commits July 23, 2021 15:53

lint fixes

ba2500e

Merge branch 'main' into pr/image-digest

99661ff

knative-prow-robot assigned dsimansk Jul 26, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2021

knative-prow-robot merged commit a252d9b into knative:main Jul 26, 2021

LucaLanziani mentioned this pull request Sep 30, 2023

fix: add annotations to ensure new docker image is downloaded nearform/initium-cli#117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an update timestamp to trigger the creation of a revision when needed. #1364

Add an update timestamp to trigger the creation of a revision when needed. #1364

rhuss commented Jul 5, 2021

knative-prow-robot left a comment

knative-prow-robot Jul 5, 2021

codecov bot commented Jul 5, 2021 •

edited

Loading

google-cla bot commented Jul 15, 2021

google-cla bot commented Jul 15, 2021

google-cla bot commented Jul 16, 2021

rhuss commented Jul 19, 2021

rhuss commented Jul 19, 2021

rhuss commented Jul 21, 2021

dsimansk commented Jul 21, 2021

rhuss commented Jul 23, 2021

dsimansk commented Jul 23, 2021 •

edited

Loading

knative-metrics-robot commented Jul 26, 2021

dsimansk commented Jul 26, 2021

knative-prow-robot commented Jul 26, 2021

Add an update timestamp to trigger the creation of a revision when needed. #1364

Add an update timestamp to trigger the creation of a revision when needed. #1364

Conversation

rhuss commented Jul 5, 2021

knative-prow-robot left a comment

Choose a reason for hiding this comment

knative-prow-robot Jul 5, 2021

Choose a reason for hiding this comment

codecov bot commented Jul 5, 2021 • edited Loading

Codecov Report

google-cla bot commented Jul 15, 2021

google-cla bot commented Jul 15, 2021

google-cla bot commented Jul 16, 2021

rhuss commented Jul 19, 2021

rhuss commented Jul 19, 2021

rhuss commented Jul 21, 2021

dsimansk commented Jul 21, 2021

rhuss commented Jul 23, 2021

dsimansk commented Jul 23, 2021 • edited Loading

knative-metrics-robot commented Jul 26, 2021

dsimansk commented Jul 26, 2021

knative-prow-robot commented Jul 26, 2021

codecov bot commented Jul 5, 2021 •

edited

Loading

dsimansk commented Jul 23, 2021 •

edited

Loading