Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase webhook timeout values to be larger than probe timeouts. #5175

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

n3wscott
Copy link
Contributor

Fixes ##5172

Proposed Changes

  • Increase Webhook timeout config from 2 seconds to 10 seconds. At minimum this value should have been larger than the default probe timeout (3 x 1 second). 2 seconds timeout means the LB would fail to route requests if a terminated and not removed pod out of the LB for the webhook.

Release Note

Webhook timeout for API server calls has been increased to 10 seconds.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 29, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2021
@n3wscott
Copy link
Contributor Author

Example failure: #5164

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #5175 (956e690) into main (9362696) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5175      +/-   ##
==========================================
+ Coverage   83.41%   83.43%   +0.01%     
==========================================
  Files         283      283              
  Lines        7955     7961       +6     
==========================================
+ Hits         6636     6642       +6     
  Misses        947      947              
  Partials      372      372              
Impacted Files Coverage Δ
pkg/adapter/v2/main.go 60.86% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9362696...956e690. Read the comment docs.

@n3wscott
Copy link
Contributor Author

Will retry several times with:

/test pull-knative-eventing-integration-tests
/test pull-knative-eventing-upgrade-tests
/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-reconciler-tests 

@n3wscott
Copy link
Contributor Author

2/2

/test pull-knative-eventing-integration-tests
/test pull-knative-eventing-upgrade-tests
/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-reconciler-tests

@n3wscott
Copy link
Contributor Author

n3wscott commented Mar 29, 2021

panics related to knative-extensions/reconciler-test#156

2/3 runs worked. Rebasing and updating deps.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2021
@n3wscott
Copy link
Contributor Author

Restarting count.

1/1

/test pull-knative-eventing-integration-tests
/test pull-knative-eventing-upgrade-tests
/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-reconciler-tests

@n3wscott
Copy link
Contributor Author

2/2

/test pull-knative-eventing-integration-tests
/test pull-knative-eventing-upgrade-tests
/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-reconciler-tests

Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2021
@knative-prow-robot knative-prow-robot merged commit 18e33bf into knative:main Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants