Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve configuration of additional repositories in GUI #4498

Merged
merged 7 commits into from
Jan 12, 2023
Merged

Improve configuration of additional repositories in GUI #4498

merged 7 commits into from
Jan 12, 2023

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Jan 10, 2023 •
edited
Loading

Implement suggestions for additional repositories proposed at: #4257

  • Replace the protocol selection with a drop-down menu of source actions.
  • Show only configuration options relevant to the selected source action.
  • Re-use the available proxy configuration dialog for the proxy configuration.

Depends on:

TODO:

  • Test all types of additional repositories and all methods of their configuration.
  • Open separate pull requests for some of the commits to make this PR smaller.

@poncovka poncovka added notable change Important changes like API change, behavior change... f38 Fedora 38 release note required Write a release note for this change. labels Jan 10, 2023
@poncovka
Copy link
Contributor Author

Additional repositories are hidden by default.

Screenshot_vpn_test_03_2023-01-10_18:35:03

The configuration screen for the repositories is not available when there is nothing to show. We were not very good at disabling the configuration options + there was a bug + it is easier to hide them than disable them.

Screenshot_vpn_test_03_2023-01-10_18:36:13

After adding or selecting a repository, this is a configuration page for http, https and ftp repositories.

Screenshot_vpn_test_03_2023-01-10_18:36:30

This is a configuration page for nfs repositories with an example of the validation error.

Screenshot_vpn_test_03_2023-01-10_18:37:22

This is a configuration page for other types of repositories.

image

This is a configuration page for treeinfo repositories.

image

@poncovka poncovka mentioned this pull request Jan 10, 2023
Merged
rvykydal
rvykydal approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you.

@poncovka
GUI: Improve configuration of additional repositories
60b3610 
Implement suggestions for additional repositories proposed at:
rhinstaller#4257

* Replace the protocol selection with a drop-down menu of source actions.
* Show only configuration options relevant to the selected source action.
* Re-use the available proxy configuration dialog for the proxy configuration.
@poncovka
Remove the cmp_obj_attrs function
5a8756f 
The function is no longer used.
@poncovka
Remove the id_generator function
a702ad1 
The function is no longer used.
@poncovka
Remove the RepoData.create_copy method
921635a 
The method is no longer used.
@poncovka
Remove the RepoData.repo_id attribute
2c910e7 
The attribute is no longer used.
@poncovka
Remove the GUIInputCheckHandler.can_go_back_focus_if_not method
9bcb8a0 
The method is no longer used.
@poncovka
Remove the InputCheckHandler.remove_check method
b361344 
The method is no longer used.
@poncovka poncovka force-pushed the master-additional_repo_gui_v2 branch from 753b777 to b361344 Compare January 12, 2023 14:58
@poncovka
Copy link
Contributor Author

/kickstart-test --testtype smoke

@poncovka
Copy link
Contributor Author

I am merging this pull request to unblock some follow-up work, but feel free to provide a review or a feedback anyway.

@poncovka poncovka merged commit 2c7b23d into rhinstaller:master Jan 12, 2023
@poncovka poncovka removed the release note required Write a release note for this change. label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvykydal rvykydal rvykydal approved these changes

Assignees
No one assigned
Labels
f38 Fedora 38 notable change Important changes like API change, behavior change...
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poncovka @rvykydal