Use standard addHelpLink() for search help on Special:Search page
Closed, ResolvedPublic
Actions

Description

Many WMF wikis display a Help:Searching link on the Special:Search page by adding the message key 'search-summary' which SpecialPage.php outputs in outputHeader(). But it doesn't render it with the addHelpLink() standard '(?)' help UX used on most other special pages, e.g. https://www.mediawiki.org/wiki/Special:LinkSearch.

A fix is to add the standard addHelpLink() code to SpecialSearch.php using a different message key such as 'Help:Search', then over time wikis can remove 'search-summary' in favor of this.

Details

	Subject	Repo	Branch	Lines +/-
	Add help link to Special:Search	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T141003: "Help" on the search page for many WMF wikis points to the wrong place

Event Timeline

• Spage created this task.Oct 14 2015, 1:00 AM

• Spage raised the priority of this task from to Needs Triage.

• Spage updated the task description. (Show Details)

• Spage added projects: MediaWiki-Special-pages, Discovery-Portal-Sprint, UI-Standardization.

• Spage subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2015, 1:00 AM

Glaisher subscribed.Oct 15 2015, 4:10 PM

Change 246695 had a related patch set uploaded (by Glaisher):
Add help link to Special:Search

https://gerrit.wikimedia.org/r/246695

gerritbot added a project: Patch-For-Review.Oct 15 2015, 4:17 PM

This would need a User-notice, so that Wiki administrators cann remove the search-summary message to avoid two help links, which would be very confusing, right?

@Johan can probably help decide that.

Florian moved this task from To triage to Special:LinkSearch on the MediaWiki-Special-pages board.Oct 19 2015, 5:10 PM

(Sorry for the late reply, I was at a conference last week and had to leave Tech News in other competent hands.)

I'll mention it in Tech News. I see the patch is still in "review in progress". When could we expect the changed to be deployed?

Liuxinyu970226 set Security to None.Oct 28 2015, 10:31 AM

Liuxinyu970226 subscribed.

@Johan: Thanks for reply :) I haven't merged the change, because I wanted to make sure, that we announce it properly, if needed :) I now merged it and it will be deployed next week, with MW 1.27.0-wmf.5 starting at 03 November.

Change 246695 merged by jenkins-bot:
Add help link to Special:Search

https://gerrit.wikimedia.org/r/246695