Filed as a separate issue - split from T149435: Build user interface for the Filter Search Bar
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| RCFilters UI: Add 'direction' property to the wrapper | mediawiki/core | master | +5 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • DannyH | T171977 Annual Plan 2017-2018, Audiences 5: Increase current editor retention and engagement | |||
| Resolved | • DannyH | T171981 Annual Plan 2017-2018, Audiences 5, Goal 2: Give better ways to monitor contributions | |||
| Resolved | • jmatazzoni | T157642 Graduate New Filters UX out of beta on Recent Changes on ALL wikis | |||
| Resolved | • jmatazzoni | T144458 Launch ERI RC page features as a Beta Feature to all wikis | |||
| Resolved | Mooeypoo | T144448 Build all front-end elements for the new Recent Changes (RC) Page user interface | |||
| Resolved | • jmatazzoni | T149435 Build user interface for the Filter Search Bar | |||
| Resolved | Mooeypoo | T157189 RC filters: filter selector drop down is misplaced in RTL |
Event Timeline
Comment Actions
Change 337210 had a related patch set uploaded (by Mooeypoo):
RCFilters UI: Fix popup position for RTL
https://gerrit.wikimedia.org/r/337210
Comment Actions
This is a bit of a hack until we figure out the positioning overrides that happen in PopupWidget vs FloatableElement and manage to add RTL fixes to those positioning calculations.
@Catrope and @matmarex may find this interesting...
I tried not to drown too much in the different calculations, but I think that now that PopupWidget has become FloatableElement, the 'PopupWidget#updateDimensions' method should seriously change to adjust. At the very least, we have to correct FloatableElement stuff to RTL, since if the menu isn't full-width with the input it floats under (like our case) then RTL adjustment is a must.
Comment Actions
I think that PopupWidget (and maybe also FloatableElement) need to have their positioning logic rewritten completely. Right now it's always left-based, even in RTL, but that means that some features like anchoring an iconed ButtonPopupWidget's popup to its icon fundamentally cannot work in RTL. Instead, I'm going to try to make it right-based in RTL. I'll take a stab at this today.
Comment Actions
Change 337210 merged by jenkins-bot:
RCFilters UI: Add 'direction' property to the wrapper
https://gerrit.wikimedia.org/r/337210
Comment Actions
Checked in betalabs - the drop-down panel is displayed in correct place.
QA recommendation: Resolve.