Thanks thanking the wrong edit
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MusikAnimal
	Feb 20 2018, 1:28 AM

Description

See https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Thanks_not_working - (permalink)

When I tried to thank Davey2010 for his edit, it looked as though it went through. I hit refresh on the revision history, and it says I've thanked Begoon for their edit. I tried a second time, and it thanked Begoon's other edit.

It seems it is thanking the most recent non-thanked revision on the page.

My thanks log also shows Begoon was thanked, and not Davey2010.

I'm using Chrome on Mac OS El Capitan, Vector skin.

The thanks button on en.wp has been temporarily hidden to avoid disruption. diff 1 diff 2

Development updated

@Trizek-WMF at 14:50 UTC:

All wikis are impacted, whatever the browser/OS; whatever the skin (mobile included)
All thanks are shifted: you thank the previous edit, not the current one.
Early investigation shows that DOM is correct, but the API is somehow malfunctioning.
Developers who can possibly fix have submitted a patch that needs to be reviewed. Thank you for your patience.

Details

	Subject	Repo	Branch	Lines +/-
	Send thank for the right link	mediawiki/extensions/Thanks	wmf/1.31.0-wmf.21	+23 -14
	Send thank for the right link	mediawiki/extensions/Thanks	master	+23 -14

Customize query in gerrit

Related Objects

Mentioned In: T186998: No indication to a user that only one Thank action is allowed

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 20 2018, 1:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

MusikAnimal updated the task description. (Show Details)Feb 20 2018, 1:29 AM

Maybe this worthy as an Unbreak Now?

MusikAnimal updated the task description. (Show Details)Feb 20 2018, 1:42 AM

MusikAnimal updated the task description. (Show Details)Feb 20 2018, 1:45 AM

Vector skin, Chrome on Windows 7 is also affected, according to Davey2010.

I got the same error in a test with Vector and Firefox. I made two screenshots (combined in one image) for documentation.
I logged in as PrimeHunter3 and viewed https://en.wikipedia.org/w/index.php?title=User_talk:PrimeHunter2&action=history

I thanked PrimeHunter for the 7 September edit, as shown in the first screenshot.
I reloaded the page and the newest 11 October edit by PrimeHunter2 was marked as thanked, as shown in the second screenshot.
PrimeHunter received no thanks. PrimeHunter2 received thanks for the 11 October edit. The thanks log also says PrimeHunter2 was thanked:
https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=thanks&user=PrimeHunter3

We've discussed this and believe that this is pretty serious, so upping to UBN. Hope that is okay! We're also going to hide the Thanks link via CSS for the time being.

Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptFeb 20 2018, 2:23 AM

MusikAnimal renamed this task from Thanks thanking for the wrong edit to Thanks thanking the wrong edit.Feb 20 2018, 2:38 AM

MusikAnimal's "We're also going to hide the Thanks link via CSS" refers to adding this to MediaWiki:Common.css in the English Wikipedia:
.mw-thanks-thank-link {display: none;}
Other wikis still have thanks links.

Xaosflux subscribed.Feb 20 2018, 4:17 AM

Dane2007 subscribed.Feb 20 2018, 6:23 AM

Coffee subscribed.Feb 20 2018, 8:35 AM

Status update? This is extremely high priority.

Coffee moved this task from Untriaged to Hot on the Collaboration-Team-Triage board.Feb 20 2018, 8:44 AM

TheresNoTime awarded a token.Feb 20 2018, 8:48 AM

TheresNoTime subscribed.

Thanks appears to be working correctly on Commons, following a quick test with an edit and an upload.

Liuxinyu970226 awarded a token.Feb 20 2018, 9:00 AM

Trizek-WMF subscribed.Feb 20 2018, 10:54 AM

All developers with experience about this feature are now sleeping. We need to wait a few hours for a fix.

Very quick tests performed before on on the engineers goes to bed seems to show that the problem comes from the API. Thanks are shifted by one: the previous edit is thanked.

I can confirm this bug for cs-wiki. The thanks notification goes to the last user who edited the page. Using Firefox 52.6.0 ESR.

Vachovec1 awarded a token.Feb 20 2018, 11:01 AM

In T187757#3985076, @Vachovec1 wrote:

I can confirm this bug for cs-wiki. The thanks notification goes to the last user who edited the page. Using Firefox 52.6.0 ESR.

The bug is on all wikis. I've updated the task accordingly.

In T187757#3985071, @Trizek-WMF wrote:

All developers with experience about this feature are now sleeping. We need to wait a few hours for a fix.

Very quick tests performed before on on the engineers goes to bed seems to show that the problem comes from the API. Thanks are shifted by one: the previous edit is thanked.

As mentioned above: "Thanks are shifted by one: the previous edit is thanked." appears not quite correct. I tried to thanks User:Vojtasafr here, but the thanks went away to User:Horst (the last user who modified the page at that time), so the difference is +3.

Trizek-WMF updated the task description. (Show Details)Feb 20 2018, 11:23 AM

TheDJ updated the task description. (Show Details)Feb 20 2018, 11:23 AM

Trizek-WMF updated the task description. (Show Details)Feb 20 2018, 11:30 AM

Coffee awarded a token.Feb 20 2018, 12:25 PM

DoRD subscribed.Feb 20 2018, 1:12 PM

SBisson claimed this task.Feb 20 2018, 1:51 PM

SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.

SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 412916 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Thanks@master] Send thank for the light link

https://gerrit.wikimedia.org/r/412916

gerritbot added a project: Patch-For-Review.Feb 20 2018, 2:04 PM

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Feb 20 2018, 2:13 PM

Davey2010 subscribed.Feb 20 2018, 2:20 PM

Sario528 subscribed.Feb 20 2018, 2:22 PM

Trizek-WMF updated the task description. (Show Details)Feb 20 2018, 2:50 PM

deryckchan subscribed.Feb 20 2018, 3:31 PM

I have done a few tests by trying to thank lots of people on a page on yue.wp where I don't mind thanking everybody. I can confirm the behaviour described above:

When I click "thank", the thanks always goes to the most recent ''edit'' by a non-bot editor (the most recent edit, not the most recent editor) that hasn't yet been thanked.

Thryduulf subscribed.Feb 20 2018, 3:52 PM

Morten_Haan subscribed.Feb 20 2018, 3:52 PM

KTC subscribed.Feb 20 2018, 3:54 PM

revi subscribed.Feb 20 2018, 4:24 PM

• Tbayer subscribed.Feb 20 2018, 4:29 PM

Jamez42 subscribed.Feb 20 2018, 5:13 PM

Change 412916 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Send thank for the right link

https://gerrit.wikimedia.org/r/412916

Change 412971 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/Thanks@wmf/1.31.0-wmf.21] Send thank for the right link

https://gerrit.wikimedia.org/r/412971

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Feb 20 2018, 6:23 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 20 2018, 7:00 PM

Nihlus subscribed.Feb 20 2018, 7:53 PM

I'm glad that the button has been disabled as a temporary measure to avoid problems with thanking the wrong users. However, I would like to have the button online and working as soon as possible. I'm finding it bothersome that I can't thank people when I appreciate their efforts.

This is fixed in master, just needs a backport (which Roan started already). I'm finishing that now.

Change 412971 merged by jenkins-bot:
[mediawiki/extensions/Thanks@wmf/1.31.0-wmf.21] Send thank for the right link

https://gerrit.wikimedia.org/r/412971

Mentioned in SAL (#wikimedia-operations) [2018-02-20T22:25:57Z] <demon@tin> Synchronized php-1.31.0-wmf.21/extensions/Thanks/modules/ext.thanks.revthank.js: T187757 (duration: 01m 14s)

Ok, this is live now!

Thanks, @demon!

I've undone @MusikAnimal 's hiding of the thank button. Button is now live again and working.

Coffee lowered the priority of this task from Unbreak Now! to Lowest.Feb 20 2018, 10:58 PM

Coffee moved this task from To Triage to Announce in next Tech/News on the User-notice board.

It was Unbreak now! when it was marked as resolved, so I don't think there's any need to change the priority.

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)); removed MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 20 2018, 11:00 PM

In T187757#3987634, @revi wrote:

It was Unbreak now! when it was marked as resolved, so I don't think there's any need to change the priority.

Roger that... didn't know if it still showed up in the UN list or whatnot.

Not sure if I can or should comment here but just wanted to say thanks all for fixing this,

Jamez42 unsubscribed.Feb 21 2018, 1:44 AM

Liuxinyu970226 unsubscribed.Feb 21 2018, 3:25 AM

In T187757#3987645, @Coffee wrote:

In T187757#3987634, @revi wrote:

It was Unbreak now! when it was marked as resolved, so I don't think there's any need to change the priority.

Roger that... didn't know if it still showed up in the UN list or whatnot.