Page MenuHomePhabricator
Create Task
Maniphest T195615

handle use of statements linking to Lexemes (and Forms?) more gracefully on client
Closed, ResolvedPublic
Actions

Description

We turned of client-side features for Lexemes for now but seem to have missed a part. (See T195611 for the fallout.)

The problem: someone added a statement to an item that was used on Wikipedia. This statement linked to a Lexeme. This lead to internal errors when viewing the page.

We need to figure out a more graceful way of handling links to Lexemes (and Forms?) in statements that are used on the clien

Current stacktrace:

2018-05-25 18:12:37 [WwhSEwpAICMAALKnaggAAABH] mw1333 frwiki 1.32.0-wmf.4 exception ERROR: [WwhSEwpAICMAALKnaggAAABH] /wiki/Cracovie   Wikibase\DataModel\Services\Lookup\EntityLookupException from line 44 of /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php: The serialization "L1041" is not recognized by the configured id builders {"exception_id":"WwhSEwpAICMAALKnaggAAABH","exception_url":"/wiki/Cracovie","caught_by":"mwe_handler"} 
[Exception Wikibase\DataModel\Services\Lookup\EntityLookupException] (/srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php:44) The serialization "L1041" is not recognized by the configured id builders
  #0 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-services/src/Lookup/RedirectResolvingEntityLookup.php(51): Wikibase\Lib\Store\RevisionBasedEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
  #1 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/LangLinkHandler.php(109): Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
  #2 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/LangLinkHandler.php(331): Wikibase\Client\LangLinkHandler->getEntityLinks(Title)
  #3 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/LangLinkHandler.php(352): Wikibase\Client\LangLinkHandler->getEffectiveRepoLinks(Title, ParserOutput)
  #4 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(97): Wikibase\Client\LangLinkHandler->addLinksFromRepository(Title, ParserOutput)
  #5 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(65): Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers->doContentAlterParserOutput(Title, ParserOutput)
  #6 /srv/mediawiki/php-1.32.0-wmf.4/includes/Hooks.php(177): Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers::onContentAlterParserOutput(WikitextContent, Title, ParserOutput)
  #7 /srv/mediawiki/php-1.32.0-wmf.4/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
  #8 /srv/mediawiki/php-1.32.0-wmf.4/includes/content/AbstractContent.php(520): Hooks::run(string, array)
  #9 /srv/mediawiki/php-1.32.0-wmf.4/includes/poolcounter/PoolWorkArticleView.php(145): AbstractContent->getParserOutput(Title, integer, ParserOptions)
  #10 /srv/mediawiki/php-1.32.0-wmf.4/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
  #11 /srv/mediawiki/php-1.32.0-wmf.4/includes/page/Article.php(604): PoolCounterWork->execute()
  #12 /srv/mediawiki/php-1.32.0-wmf.4/includes/actions/ViewAction.php(68): Article->view()
  #13 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(500): ViewAction->show()
  #14 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
  #15 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(861): MediaWiki->performRequest()
  #16 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(524): MediaWiki->main()
  #17 /srv/mediawiki/php-1.32.0-wmf.4/index.php(42): MediaWiki->run()
  #18 /srv/mediawiki/w/index.php(3): include(string)
  #19 {main}
Caused by: [Exception Wikibase\DataModel\Entity\EntityIdParsingException] (/srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php:60) The serialization "L1041" is not recognized by the configured id builders
  #0 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-services/src/EntityId/PrefixMappingEntityIdParser.php(86): Wikibase\DataModel\Entity\DispatchingEntityIdParser->parse(string)
  #1 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Serialization/RepositorySpecificDataValueDeserializerFactory.php(70): Wikibase\DataModel\Services\EntityId\PrefixMappingEntityIdParser->parse(string)
  #2 /srv/mediawiki/php-1.32.0-wmf.4/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(122): Closure$Wikibase\Lib\Serialization\RepositorySpecificDataValueDeserializerFactory::newDeserializerForRepository(array)
  #3 /srv/mediawiki/php-1.32.0-wmf.4/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(91): DataValues\Deserializers\DataValueDeserializer->getDeserialization(array)
  #4 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(118): DataValues\Deserializers\DataValueDeserializer->deserialize(array)
  #5 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(108): Wikibase\DataModel\Deserializers\SnakDeserializer->deserializeDataValue(array)
  #6 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(90): Wikibase\DataModel\Deserializers\SnakDeserializer->newValueSnak(array)
  #7 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(72): Wikibase\DataModel\Deserializers\SnakDeserializer->getDeserialized(array)
  #8 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/SnakListDeserializer.php(60): Wikibase\DataModel\Deserializers\SnakDeserializer->deserialize(array)
  #9 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/SnakListDeserializer.php(41): Wikibase\DataModel\Deserializers\SnakListDeserializer->getDeserialized(array)
  #10 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(140): Wikibase\DataModel\Deserializers\SnakListDeserializer->deserialize(array)
  #11 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(118): Wikibase\DataModel\Deserializers\StatementDeserializer->setQualifiersFromSerialization(array, Wikibase\DataModel\Statement\Statement)
  #12 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(100): Wikibase\DataModel\Deserializers\StatementDeserializer->getDeserialized(array)
  #13 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/StatementListDeserializer.php(60): Wikibase\DataModel\Deserializers\StatementDeserializer->deserialize(array)
  #14 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/StatementListDeserializer.php(41): Wikibase\DataModel\Deserializers\StatementListDeserializer->getDeserialized(array)
  #15 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/ItemDeserializer.php(130): Wikibase\DataModel\Deserializers\StatementListDeserializer->deserialize(array)
  #16 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/ItemDeserializer.php(85): Wikibase\DataModel\Deserializers\ItemDeserializer->setStatementListFromSerialization(array, Wikibase\DataModel\Entity\Item)
  #17 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-serialization/src/Deserializers/ItemDeserializer.php(77): Wikibase\DataModel\Deserializers\ItemDeserializer->getDeserialized(array)
  #18 /srv/mediawiki/php-1.32.0-wmf.4/vendor/serialization/serialization/src/Deserializers/DispatchingDeserializer.php(42): Wikibase\DataModel\Deserializers\ItemDeserializer->deserialize(array)
  #19 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/internal-serialization/src/Deserializers/EntityDeserializer.php(47): Deserializers\DispatchingDeserializer->deserialize(array)
  #20 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php(252): Wikibase\InternalSerialization\Deserializers\EntityDeserializer->deserialize(array)
  #21 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(163): Wikibase\Lib\Store\EntityContentDataCodec->decodeEntity(string, NULL)
  #22 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(92): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->loadEntity(stdClass)
  #23 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(59): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
  #24 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(104): Wikibase\Lib\Store\DispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
  #25 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(87): Wikibase\Lib\Store\CachingEntityRevisionLookup->fetchEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
  #26 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(104): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
  #27 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(87): Wikibase\Lib\Store\CachingEntityRevisionLookup->fetchEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
  #28 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php(39): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId)
  #29 /srv/mediawiki/php-1.32.0-wmf.4/vendor/wikibase/data-model-services/src/Lookup/RedirectResolvingEntityLookup.php(51): Wikibase\Lib\Store\RevisionBasedEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
  #30 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/LangLinkHandler.php(109): Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
  #31 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/LangLinkHandler.php(331): Wikibase\Client\LangLinkHandler->getEntityLinks(Title)
  #32 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/LangLinkHandler.php(352): Wikibase\Client\LangLinkHandler->getEffectiveRepoLinks(Title, ParserOutput)
  #33 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(97): Wikibase\Client\LangLinkHandler->addLinksFromRepository(Title, ParserOutput)
  #34 /srv/mediawiki/php-1.32.0-wmf.4/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(65): Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers->doContentAlterParserOutput(Title, ParserOutput)
  #35 /srv/mediawiki/php-1.32.0-wmf.4/includes/Hooks.php(177): Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers::onContentAlterParserOutput(WikitextContent, Title, ParserOutput)
  #36 /srv/mediawiki/php-1.32.0-wmf.4/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
  #37 /srv/mediawiki/php-1.32.0-wmf.4/includes/content/AbstractContent.php(520): Hooks::run(string, array)
  #38 /srv/mediawiki/php-1.32.0-wmf.4/includes/poolcounter/PoolWorkArticleView.php(145): AbstractContent->getParserOutput(Title, integer, ParserOptions)
  #39 /srv/mediawiki/php-1.32.0-wmf.4/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
  #40 /srv/mediawiki/php-1.32.0-wmf.4/includes/page/Article.php(604): PoolCounterWork->execute()
  #41 /srv/mediawiki/php-1.32.0-wmf.4/includes/actions/ViewAction.php(68): Article->view()
  #42 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(500): ViewAction->show()
  #43 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
  #44 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(861): MediaWiki->performRequest()
  #45 /srv/mediawiki/php-1.32.0-wmf.4/includes/MediaWiki.php(524): MediaWiki->main()
  #46 /srv/mediawiki/php-1.32.0-wmf.4/index.php(42): MediaWiki->run()
  #47 /srv/mediawiki/w/index.php(3): include(string)
  #48 {main}

Details

SubjectRepoBranchLines +/-
Only enable repo-specific parts of WikibaseLexeme on wikidata wikisoperations/mediawiki-configmaster+6 -0
Load WikibaseLexeme on all wikidata clientsoperations/mediawiki-configmaster+1 -2
Load WikibaseLexeme on group1operations/mediawiki-configmaster+1 -0
Load WikibaseLexeme on testwikioperations/mediawiki-configmaster+1 -0
Load WikibaseLexeme on all of group0operations/mediawiki-configmaster+1 -1
Only define non-repo elements in data types definition for Clientmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.8+44 -1
Only define non-repo elements in data types definition for Clientmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.999+44 -1
Only define non-repo elements in data types definition for Clientmediawiki/extensions/WikibaseLexememaster+44 -1
Statement transclusion: when entity of unknown type in statement, display ID as stringmediawiki/extensions/Wikibasewmf/1.32.0-wmf.8+301 -25
Only register API modules and other repo-specific stuff in repo-only modemediawiki/extensions/WikibaseLexememaster+562 -463
Register data types on clientmediawiki/extensions/WikibaseLexememaster+3 -0
Only add repo-specific entity type definition elements in Repo contextmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.5+330 -298
Only add repo-specific entity type definition elements in Repo contextmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.6+330 -298
Only add repo-specific entity type definition elements in Repo contextmediawiki/extensions/WikibaseLexememaster+330 -298
Only run onCirrusSearchProfileService if repo is enabledmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.5+5 -0
Only run onCirrusSearchProfileService if repo is enabledmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.6+5 -0
Do not register Lexeme namespaces in CanonicalNamespaces on clientsmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.5+6 -0
Do not register Lexeme namespaces in CanonicalNamespaces on clientsmediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.6+6 -0
Only run onCirrusSearchProfileService if repo is enabledmediawiki/extensions/WikibaseLexememaster+5 -0
Do not register Lexeme namespaces in CanonicalNamespaces on clientsmediawiki/extensions/WikibaseLexememaster+6 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Addshore mentioned this in rEWLE5d51d731a0e7: Only add repo-specific entity type definition elements in Repo context.May 31 2018, 3:25 PM
Addshore mentioned this in rEWLEc198da5cefce: Only add repo-specific entity type definition elements in Repo context.
gerritbot added a comment.May 31 2018, 3:37 PM

Change 436563 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Only add repo-specific entity type definition elements in Repo context

https://gerrit.wikimedia.org/r/436563

gerritbot added a comment.May 31 2018, 3:38 PM

Change 436566 merged by Addshore:
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.6] Only add repo-specific entity type definition elements in Repo context

https://gerrit.wikimedia.org/r/436566

Stashbot added a comment.May 31 2018, 3:42 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-31T15:42:15Z] <addshore@tin> Synchronized php-1.32.0-wmf.6/extensions/WikibaseLexeme: [[gerrit:436566|Only add repo-specific entity type definition elements in Repo context]] T195615 (duration: 01m 32s)

gerritbot added a comment.May 31 2018, 3:42 PM

Change 436567 merged by Addshore:
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.5] Only add repo-specific entity type definition elements in Repo context

https://gerrit.wikimedia.org/r/436567

Stashbot added a comment.May 31 2018, 3:44 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-31T15:44:56Z] <addshore@tin> Synchronized php-1.32.0-wmf.5/extensions/WikibaseLexeme: [[gerrit:436567|Only add repo-specific entity type definition elements in Repo context]] T195615 (duration: 01m 32s)

Stashbot added a comment.May 31 2018, 3:50 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-31T15:50:54Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings.php: [[gerrit:436560|Load WikibaseLexeme on testwiki (again)]] T195615 (duration: 01m 21s)

gerritbot added a comment.May 31 2018, 3:52 PM

Change 436497 merged by jenkins-bot:
[operations/mediawiki-config@master] Load WikibaseLexeme on all of group0

https://gerrit.wikimedia.org/r/436497

Stashbot added a comment.May 31 2018, 3:59 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-31T15:59:00Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings.php: [[gerrit:436497|Load WikibaseLexeme on group0]] T195615 (duration: 01m 18s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)); removed MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 31 2018, 4:00 PM
Stashbot added a comment.May 31 2018, 4:03 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-31T16:03:06Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings.php: REVERT Load WikibaseLexeme on group0 T195615 (duration: 01m 21s)

Stashbot added a comment.May 31 2018, 4:06 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-31T16:06:44Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings.php: REVERT Load WikibaseLexeme on testwiki (again) T195615 (duration: 01m 21s)

Addshore added a comment.May 31 2018, 4:08 PM

Next issue encountered is that API modules are also loaded, when they should not be.

PHP Fatal Error: Class undefined: Wikibase\Repo\WikibaseRepo
#0 /srv/mediawiki/php-1.32.0-wmf.6/extensions/WikibaseLexeme/src/Api/AddForm.php(70): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiModuleManager.php(191): Wikibase\Lexeme\Api\AddForm::newFromGlobalState(ApiMain, string)
#2 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiModuleManager.php(167): ApiModuleManager->instantiateModule(string, string, string)
#3 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiBase.php(641): ApiModuleManager->getModule(string)
#4 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiBase.php(2426): ApiBase->getModuleFromPath(string)
#5 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiHelp.php(429): ApiBase->getFinalParamDescription()
#6 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiHelp.php(146): ApiHelp::getHelpInternal(DerivativeContext, array, array, array)
#7 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiHelp.php(50): ApiHelp::getHelp(DerivativeContext, array, array)
#8 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiMain.php(1579): ApiHelp->execute()
#9 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiMain.php(535): ApiMain->executeAction()
#10 /srv/mediawiki/php-1.32.0-wmf.6/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#11 /srv/mediawiki/php-1.32.0-wmf.6/api.php(83): ApiMain->execute()
#12 /srv/mediawiki/w/api.php(3): include(string)
#13 {main}
WMDE-leszek claimed this task.Jun 1 2018, 2:51 PM
Pintoch subscribed.Jun 4 2018, 12:49 PM

Just noting that this prevents us from adding examples on lexeme-related properties, such as https://www.wikidata.org/wiki/Property:P5244.

WMDE-leszek mentioned this in rEWLEb23a63a470df: Only register API modules and other repo-specific stuff in repo-only mode.Jun 5 2018, 4:09 PM
hoo merged a task: T196471: PHP fatal error: Call to undefined method __PHP_Incomplete_Class::getEntityType().Jun 5 2018, 9:00 PM
hoo added subscribers: Nirmos, hoo, greg.
hoo added a comment.EditedJun 5 2018, 9:08 PM

This is very close to a UBN (if not actually a UBN) :/

Addshore added a comment.EditedJun 6 2018, 8:19 AM

I undid the edit that was causing the spam @ T196471 for now and confirmed that there are no more items or properties that use forms or lexemes.

WMDE-leszek mentioned this in rEWLE33d1400a65f7: Only register API modules and other repo-specific stuff in repo-only mode.Jun 6 2018, 8:32 AM
WMDE-leszek mentioned this in rEWLE19bb6532f43c: Only register API modules and other repo-specific stuff in repo-only mode.Jun 6 2018, 8:59 AM
gerritbot added a comment.Jun 6 2018, 9:47 AM

Change 437699 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Register data types on client

https://gerrit.wikimedia.org/r/437699

WMDE-leszek mentioned this in rEWLE8d8398b726b8: Register data types on client.Jun 6 2018, 9:48 AM
gerritbot added a comment.Jun 6 2018, 12:02 PM

Change 437699 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Register data types on client

https://gerrit.wikimedia.org/r/437699

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)); removed MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 6 2018, 1:01 PM
WMDE-leszek added a comment.Jun 7 2018, 12:43 PM

@Addshore enabling WikibaseLexeme on clients is one thing that probably should be considered. But also something that needs more thought and work.
Regardelss of this, I am now pretty convinced https://gerrit.wikimedia.org/r/#/c/437495/ is a fix that would solve this problem, and generally a problem of client wiki reading data containing references to entities of type the client wiki does not know.

WMDE-leszek moved this task from Doing to Peer Review on the Wikidata-Turtles-Sprint #5 board.Jun 7 2018, 12:43 PM
Addshore mentioned this in rEWLE9f742e5f05c1: Only register API modules and other repo-specific stuff in repo-only mode.Jun 7 2018, 1:44 PM
Addshore added a comment.EditedJun 7 2018, 1:48 PM

Just +2ed the patch and have setup the following patches ready to deploy:

Still TODO is a patch setting wgLexemeEnableRepo to false for the clients

We of course need to wait for the patch to be deployed everywhere next week first :)

gerritbot added a comment.Jun 7 2018, 1:57 PM

Change 437500 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Only register API modules and other repo-specific stuff in repo-only mode

https://gerrit.wikimedia.org/r/437500

gerritbot added a comment.Jun 8 2018, 1:46 PM

Change 438245 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Only enable repo-specific parts of WikibaseLexeme on wikidata wikis

https://gerrit.wikimedia.org/r/438245

WMDE-leszek added a comment.Jun 8 2018, 1:48 PM

Still TODO is a patch setting wgLexemeEnableRepo to false for the clients

Hopefully https://gerrit.wikimedia.org/r/438245 does the trick.

Lydia_Pintscher added a project: Wikidata-Campsite.Jun 10 2018, 10:48 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Peer Review on the Wikidata-Campsite board.Jun 12 2018, 1:35 PM
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.Jun 13 2018, 7:58 AM
Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration1.Jun 13 2018, 9:28 AM
Jakob_WMDE moved this task from To Do to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 10:40 AM
greg added a comment.Jun 13 2018, 4:38 PM

I presume the fatal on https://test.wikipedia.org/wiki/Main_Page is known?

• Pablo-WMDE removed WMDE-leszek as the assignee of this task.Jun 14 2018, 8:36 AM
• Pablo-WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration1 board.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 14 2018, 9:00 AM
Addshore added a comment.Jun 14 2018, 9:20 AM
In T195615#4280121, @greg wrote:

I presume the fatal on https://test.wikipedia.org/wiki/Main_Page is known?

Fixed by https://test.wikidata.org/w/index.php?title=Q33&diff=prev&oldid=395905

Backport coming today

gerritbot added a comment.Jun 14 2018, 9:27 AM

Change 440295 had a related patch set uploaded (by Addshore; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.8] Statement transclusion: when entity of unknown type in statement, display ID as string

https://gerrit.wikimedia.org/r/440295

Addshore added a comment.Jun 14 2018, 9:28 AM
In T195615#4282248, @gerritbot wrote:

Change 440295 had a related patch set uploaded (by Addshore; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.8] Statement transclusion: when entity of unknown type in statement, display ID as string

https://gerrit.wikimedia.org/r/440295

The patch on master has already been +2ed and merged, but the Bug link wasn't in the commit message footer so the bot failed to link it here

gerritbot added a comment.Jun 14 2018, 1:23 PM

Change 440295 merged by Zfilipin:
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.8] Statement transclusion: when entity of unknown type in statement, display ID as string

https://gerrit.wikimedia.org/r/440295

Stashbot added a comment.Jun 14 2018, 1:46 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-14T13:46:18Z] <zfilipin@deploy1001> Synchronized php-1.32.0-wmf.8/extensions/Wikibase: SWAT: [[gerrit:440343| Revert "Statement transclusion: when entity of unknown type in statement, display ID as string" (T195615)]] (duration: 01m 21s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 14 2018, 2:00 PM
WMDE-leszek mentioned this in T197252: Can't correctly unserialize cached EntityRevision on WikibaseClient (Wikipedia) .Jun 14 2018, 5:30 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/437495/ fixes the problem but when cache is used there is a PHP serialization issue resulting with fatals: T197252.

Addshore added a subtask: T197252: Can't correctly unserialize cached EntityRevision on WikibaseClient (Wikipedia) .Jun 15 2018, 10:01 AM
Addshore mentioned this in T197454: Deploy WikibaseLexeme to wikidata clients.
Lydia_Pintscher closed this task as Resolved.Jun 15 2018, 4:56 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Editor-Experience-Improvements-Iteration1 board.
Lydia_Pintscher added a subscriber: Lea_Lacroix_WMDE.

@Addshore did you already remove the abuse filter?

Addshore reopened this task as Open.Jun 15 2018, 9:56 PM

This isn't yet resolved.

Addshore removed a subtask: T197454: Deploy WikibaseLexeme to wikidata clients.Jun 15 2018, 9:58 PM
Kostas20142 subscribed.Jun 17 2018, 9:56 AM
WMDE-leszek moved this task from Peer Review to In Progress on the Wikidata-Campsite board.Jun 18 2018, 10:02 AM
KaMan subscribed.Jun 20 2018, 8:02 AM
Addshore mentioned this in T198063: Adding a value like "L3" blocked on items.Jun 25 2018, 9:51 AM
gerritbot added a comment.Jun 25 2018, 3:42 PM

Change 441896 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Only define non-repo elements in data types definition for Client

https://gerrit.wikimedia.org/r/441896

WMDE-leszek mentioned this in rEWLE8ee8b5e4af99: Only define non-repo elements in data types definition for Client.Jun 25 2018, 3:45 PM
gerritbot added a comment.Jun 25 2018, 4:24 PM

Change 441896 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Only define non-repo elements in data types definition for Client

https://gerrit.wikimedia.org/r/441896

gerritbot added a comment.Jun 26 2018, 12:04 PM

Change 442083 had a related patch set uploaded (by Addshore; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.8] Only define non-repo elements in data types definition for Client

https://gerrit.wikimedia.org/r/442083

gerritbot added a comment.Jun 26 2018, 12:04 PM

Change 442084 had a related patch set uploaded (by Addshore; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.999] Only define non-repo elements in data types definition for Client

https://gerrit.wikimedia.org/r/442084

Addshore mentioned this in rEWLE5b743a0c4801: Only define non-repo elements in data types definition for Client.Jun 26 2018, 12:05 PM
Addshore mentioned this in rEWLEb127ed870004: Only define non-repo elements in data types definition for Client.
gerritbot added a comment.Jun 26 2018, 12:19 PM

Change 442084 abandoned by Addshore:
Only define non-repo elements in data types definition for Client

https://gerrit.wikimedia.org/r/442084

gerritbot added a comment.Jun 26 2018, 12:19 PM

Change 442083 abandoned by Addshore:
Only define non-repo elements in data types definition for Client

https://gerrit.wikimedia.org/r/442083

Lydia_Pintscher removed Lydia_Pintscher as the assignee of this task.Jun 27 2018, 9:45 AM
• Jonas assigned this task to WMDE-leszek.Jun 27 2018, 10:05 AM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 30 2018, 4:01 PM
• Vvjjkkii renamed this task from handle use of statements linking to Lexemes (and Forms?) more gracefully on client to k9baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii removed WMDE-leszek as the assignee of this task.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from k9baaaaaaa to handle use of statements linking to Lexemes (and Forms?) more gracefully on client.Jul 2 2018, 1:23 PM
CommunityTechBot assigned this task to WMDE-leszek.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
gerritbot added a comment.Jul 3 2018, 3:39 PM

Change 436498 merged by jenkins-bot:
[operations/mediawiki-config@master] Load WikibaseLexeme on group1

https://gerrit.wikimedia.org/r/436498

gerritbot added a comment.Jul 3 2018, 3:44 PM

Change 436499 merged by jenkins-bot:
[operations/mediawiki-config@master] Load WikibaseLexeme on all wikidata clients

https://gerrit.wikimedia.org/r/436499

WMDE-leszek closed this task as Resolved.Jul 3 2018, 4:03 PM

This should be fixed now (finally) on all client WMF wikis.
@Addshore has deleted the Abuse Filter rule, so use of lexemes in statements is now possible.

With this, I'd conclude this ticket to be resolved.

Addshore moved this task from Back Burner 🏛️ to Closing ✔️ on the User-Addshore board.Jul 11 2018, 1:13 PM
gerritbot added a comment.Aug 27 2018, 9:19 AM

Change 438245 abandoned by WMDE-leszek:
Only enable repo-specific parts of WikibaseLexeme on wikidata wikis

https://gerrit.wikimedia.org/r/438245

WMDE-leszek mentioned this in T208103: Wikibase Lexeme emits "PHP Warning: Class __PHP_Incomplete_Class has no unserializer".Oct 29 2018, 7:09 PM
Lucas_Werkmeister_WMDE mentioned this in T207683: Wikibase Repo api modules and special pages should be conditionally loaded based on entity types enabled and local, or only accept loaded local entities (or at least, not crash).Apr 13 2021, 12:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits