Page MenuHomePhabricator
Create Task
Maniphest T198036

Validating the language of a Gloss
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
Currently any input is accepted for the language of a Gloss. We should restrict this in order to make it easier to re-use and to be able to do language fallbacks etc.

Acceptance criteria:

  • I can not enter a language for a Gloss that is not in the list we validate against (list of label languages).
  • I can enter any language that is on the list we validate against.

BDD
GIVEN I am on a Lexeme page
AND I edit a Gloss
WHEN I enter a language that is not considered valid
THEN the field is highlighted in red
AND the save button is grayed out

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Jun 24 2018, 11:16 AM
Lydia_Pintscher moved this task from incoming to features/bugs for next release (Senses) on the Wikidata Lexicographical data board.
Lydia_Pintscher updated the task description. (Show Details)Jun 25 2018, 8:37 AM
• RazShuty set the point value for this task to 5.Jun 26 2018, 11:24 AM
• Vvjjkkii renamed this task from Validating the language of a Gloss to beaaaaaaaa.Jul 1 2018, 1:01 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
JJMC89 renamed this task from beaaaaaaaa to Validating the language of a Gloss.Jul 1 2018, 3:52 AM
JJMC89 raised the priority of this task from High to Needs Triage.
JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
JJMC89 updated the task description. (Show Details)
JJMC89 set the point value for this task to 5.
Lucas_Werkmeister_WMDE subscribed.Jul 23 2018, 11:25 AM

Is client-side validation (T198203: Check gloss language codes in UI) required for this? It’s not (yet?) implemented for form representations either.

WMDE-leszek added a project: Wikidata-Senses-Iteration2.Jul 24 2018, 11:49 AM
Lydia_Pintscher added a comment.Jul 26 2018, 12:30 PM

I'd say yes. Is there a good reason not do it?

Ladsgroup mentioned this in T198203: Check gloss language codes in UI.Jul 31 2018, 8:18 AM
Lucas_Werkmeister_WMDE closed subtask T198200: Validate gloss languages in the API as Resolved.Jul 31 2018, 1:07 PM
WMDE-leszek added a project: Wikidata-Senses-Iteration3.Aug 14 2018, 11:41 AM
Lydia_Pintscher closed subtask T198202: Add API to check language code validity / get all valid language codes as Resolved.Aug 24 2018, 12:40 PM
Addshore added a project: Wikidata-Senses-Iteration4.Sep 4 2018, 11:34 AM
Addshore moved this task from To Do to Doing on the Wikidata-Senses-Iteration4 board.Sep 17 2018, 10:22 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Sep 18 2018, 2:24 PM
Addshore moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration4 board.Sep 18 2018, 9:05 PM
Addshore subscribed.Sep 20 2018, 1:00 PM

@Lydia_Pintscher The patch should be landing on beta at some point today.

Just as we were merging it @Lucas_Werkmeister_WMDE pointed out 1 thing:

I was just editing some glosses for an unrelated task with this patch still checked out, and I found it to be a bit overly intrusive – the warning pops up too often while you’re entering a language code (because “e” is not a valid language code even though “en” is).

Should we investigate it popping up less? / only when the user moves focus away from the language field? / after a short time period?

Addshore moved this task from Peer Review to Test (Product Review) on the Wikidata-Senses-Iteration4 board.Sep 20 2018, 1:21 PM
Lydia_Pintscher added a comment.Sep 20 2018, 2:51 PM

Yeah if it is annoying we should try to see if there are ways to make it less annoying. If you or UX have ideas please go ahead.

Lydia_Pintscher closed this task as Resolved.Sep 26 2018, 9:27 AM
Lydia_Pintscher claimed this task.
Lydia_Pintscher closed subtask T198203: Check gloss language codes in UI as Resolved.
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration4 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits