Page MenuHomePhabricator
Create Task
Maniphest T210744

Refactor our javascript to remove jquery usage with better vanilla alternatives
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

When we updated the upstream wikimedia eslint config in T209932, we deactivated a lot of rules primarily concerning suboptimal jQuery usage, because that was beyond the scope of that ticket. Nonetheless, these rules are reasonable (#106 on GitHub) and should be implemented. Also the max-statements-per-line rule should be enabled and the code adjusted.

Acceptance Criteria

  • enable rules and fix code in Wikibase (~119 linting errors) - rules disabled
  • enable rules and fix code in WikibaseLexeme (~9 linting errors) - rules disabled
  • enable rules and fix code in WikibaseQualityConstrains (~0 linting errors)

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Nov 29 2018, 4:08 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptNov 29 2018, 4:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Michael mentioned this in T209932: Update mediawiki eslint config .Nov 29 2018, 4:49 PM
Michael added projects: Technical-Debt, JavaScript.
Michael moved this task from 🗃️ Incoming to 👁️ watching on the User-Michael board.Dec 4 2018, 5:04 PM
Michael moved this task from 👁️ watching to 🗃️ Incoming on the User-Michael board.Dec 5 2018, 8:15 AM
Addshore triaged this task as Low priority.Dec 18 2018, 11:12 AM
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore moved this task from incoming to consider for next sprint on the Wikidata board.
Addshore updated the task description. (Show Details)Dec 18 2018, 2:27 PM
Addshore set the point value for this task to 5.
Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from consider for next sprint to in progress on the Wikidata board.Dec 19 2018, 12:46 PM
Michael claimed this task.Dec 20 2018, 11:51 AM
Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.
gerritbot subscribed.Dec 20 2018, 3:31 PM

Change 480968 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery proxy" eslint rule

https://gerrit.wikimedia.org/r/480968

gerritbot added a project: Patch-For-Review.Dec 20 2018, 3:31 PM

Change 480969 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery isFunction" eslint rule

https://gerrit.wikimedia.org/r/480969

gerritbot added a comment.Dec 20 2018, 3:31 PM

Change 480970 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery grep" eslint rule

https://gerrit.wikimedia.org/r/480970

gerritbot added a comment.Dec 20 2018, 3:31 PM

Change 480971 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery each" eslint rule

https://gerrit.wikimedia.org/r/480971

gerritbot added a comment.Dec 20 2018, 3:31 PM

Change 480972 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery map" eslint rule

https://gerrit.wikimedia.org/r/480972

gerritbot added a comment.Dec 20 2018, 3:31 PM

Change 480973 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Fix broken unregister widget method

https://gerrit.wikimedia.org/r/480973

gerritbot added a comment.Dec 20 2018, 3:31 PM

Change 480974 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery inArray" eslint rule

https://gerrit.wikimedia.org/r/480974

gerritbot added a comment.Dec 20 2018, 3:31 PM

Change 480975 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery trim" eslint rule

https://gerrit.wikimedia.org/r/480975

gerritbot added a comment.Dec 20 2018, 3:31 PM

Change 480976 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Renable and fix max-statements-per-line eslint rule

https://gerrit.wikimedia.org/r/480976

gerritbot added a comment.Dec 20 2018, 4:19 PM

Change 480983 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery proxy" eslint rule

https://gerrit.wikimedia.org/r/480983

gerritbot added a comment.Dec 20 2018, 4:19 PM

Change 480984 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery each" eslint rule

https://gerrit.wikimedia.org/r/480984

gerritbot added a comment.Dec 20 2018, 4:19 PM

Change 480985 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery inArray" eslint rule

https://gerrit.wikimedia.org/r/480985

gerritbot added a comment.Dec 20 2018, 4:19 PM

Change 480986 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Renable and fix max-statements-per-line eslint rule

https://gerrit.wikimedia.org/r/480986

gerritbot added a comment.Dec 20 2018, 4:19 PM

Change 480987 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Suppress compatibility errors only in tests

https://gerrit.wikimedia.org/r/480987

Michael mentioned this in rEWLEb1ef01f9ec53: Enable and fix "no jQuery proxy" eslint rule.Dec 20 2018, 4:22 PM
Michael mentioned this in rEWLE558c10afbac0: Enable and fix "no jQuery each" eslint rule.
Michael mentioned this in rEWLEeaa7d8e3adc9: Enable and fix "no jQuery inArray" eslint rule.
Michael mentioned this in rEWLEaae764f8e8e6: Renable and fix max-statements-per-line eslint rule.
Michael mentioned this in rEWLE655a788e9d61: Suppress compatibility errors only in tests.
Michael mentioned this in rEWLE7b352b0b7b1f: Enable and fix "no jQuery each" eslint rule.Dec 21 2018, 11:22 AM
Michael mentioned this in rEWLEa27101ebaa67: Enable and fix "no jQuery inArray" eslint rule.
Michael mentioned this in rEWLE907f98ca9ed8: Renable and fix max-statements-per-line eslint rule.
Michael mentioned this in rEWLE21bed63d31e1: Suppress compatibility errors only in tests.
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 21 2018, 6:59 PM
gerritbot added a comment.Dec 23 2018, 8:36 PM

Change 480983 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery proxy" eslint rule

https://gerrit.wikimedia.org/r/480983

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 23 2018, 9:00 PM
Michael mentioned this in rEWLE35db49057b73: Enable and fix "no jQuery each" eslint rule.Jan 2 2019, 10:57 AM
Michael mentioned this in rEWLE954d34ef8211: Enable and fix "no jQuery inArray" eslint rule.
Michael mentioned this in rEWLE12d46752e0e9: Renable and fix max-statements-per-line eslint rule.
Michael mentioned this in rEWLE9afc0b28d02a: Suppress compatibility errors only in tests.
Michael moved this task from ⏳ In progress to 💬 waiting on other's work or feedback on the User-Michael board.Jan 2 2019, 2:08 PM
gerritbot added a comment.Jan 3 2019, 2:12 PM

Change 480968 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery proxy" eslint rule

https://gerrit.wikimedia.org/r/480968

gerritbot added a comment.Jan 3 2019, 2:16 PM

Change 480969 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery isFunction" eslint rule

https://gerrit.wikimedia.org/r/480969

gerritbot added a comment.Jan 3 2019, 2:16 PM

Change 480970 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery grep" eslint rule

https://gerrit.wikimedia.org/r/480970

gerritbot added a comment.Jan 9 2019, 9:17 AM

Change 480984 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery each" eslint rule

https://gerrit.wikimedia.org/r/480984

gerritbot added a comment.Jan 9 2019, 9:17 AM

Change 480985 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable and fix "no jQuery inArray" eslint rule

https://gerrit.wikimedia.org/r/480985

gerritbot added a comment.Jan 9 2019, 9:17 AM

Change 480986 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Renable and fix max-statements-per-line eslint rule

https://gerrit.wikimedia.org/r/480986

gerritbot added a comment.Jan 9 2019, 9:17 AM

Change 480987 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Suppress compatibility errors only in tests

https://gerrit.wikimedia.org/r/480987

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.13; 2019-01-15); removed MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 9 2019, 10:00 AM
gerritbot added a comment.Jan 10 2019, 12:49 PM

Change 480971 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery each" eslint rule

https://gerrit.wikimedia.org/r/480971

gerritbot added a comment.Jan 11 2019, 10:52 AM

Change 480972 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery map" eslint rule

https://gerrit.wikimedia.org/r/480972

gerritbot added a comment.Jan 11 2019, 10:58 AM

Change 480973 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix broken unregister widget method

https://gerrit.wikimedia.org/r/480973

gerritbot added a comment.Jan 11 2019, 10:58 AM

Change 480974 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery inArray" eslint rule

https://gerrit.wikimedia.org/r/480974

gerritbot added a comment.Jan 11 2019, 11:08 AM

Change 480975 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable and fix "no jQuery trim" eslint rule

https://gerrit.wikimedia.org/r/480975

gerritbot added a comment.Jan 11 2019, 12:01 PM

Change 480976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Renable and fix max-statements-per-line eslint rule

https://gerrit.wikimedia.org/r/480976

Michael moved this task from 💬 waiting on other's work or feedback to ✅ my work done on the User-Michael board.Jan 11 2019, 12:09 PM
Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore closed this task as Resolved.Jan 15 2019, 9:20 AM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE mentioned this in T213975: Link page from wikimedia.Commons with page exisiting on en.wikipedia with no existing item on wikidata fails.Jan 17 2019, 10:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits