The Wikibase web interface shows non-functional sitelink groups
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	abian
	Sep 7 2019, 11:37 AM

Description

Problem: On a fresh Wikibase installation the web interface shows all the possible sitelink groups supported by Wikidata even if they don't work locally (by default they aren't enabled). Only locally enabled and fully functional sitelink groups should appear on the Wikibase web interface. The sitelink groups can be selectively enabled with $wgWBRepoSettings['siteLinkGroups'] (see https://www.mediawiki.org/wiki/Wikibase/Installation#Enable_Sitelinks).

Screenshots/mockups (current state):

Acceptance criteria:

Only locally enabled and fully functional sitelink groups appear on the Wikibase web interface.

Open questions:

Details

	Subject	Repo	Branch	Lines +/-
	Move siteLinkGroups to default config and empty	mediawiki/extensions/Wikibase	master	+16 -14
	Remove siteLink groups from Wikibase registry	mediawiki/extensions/Wikibase	master	+49 -18

Customize query in gerrit

Related Objects

Mentioned In: T219022: remove sitelink groups from Wikibase Registry

Event Timeline

abian created this task.Sep 7 2019, 11:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2019, 11:37 AM

Looks like we tried to fix this at some point but it got lost in the backlog of things.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/474844/

From the looks of things, there was not a phab ticket for that original patch.

Change 474844 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Addshore):
[mediawiki/extensions/Wikibase@master] Move siteLinkGroups to default config and empty

https://gerrit.wikimedia.org/r/474844

gerritbot added a project: Patch-For-Review.Sep 17 2019, 1:41 PM

Addshore triaged this task as Low priority.Sep 27 2019, 6:51 PM

Addshore added a project: Wikidata-Campsite.

Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

• alaa_wmde mentioned this in T219022: remove sitelink groups from Wikibase Registry.Oct 1 2019, 11:18 AM

Let's review the associated patch and resolve this. It is desirable to solve from product perspective for 3rd party installations.

• alaa_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.Oct 1 2019, 11:31 AM

• alaa_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Tests need to be fixed still

• alaa_wmde claimed this task.Oct 1 2019, 1:49 PM

• alaa_wmde moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 2 2019, 1:10 PM

• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 4 2019, 10:25 PM

• alaa_wmde moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 7 2019, 11:59 AM

• alaa_wmde removed • alaa_wmde as the assignee of this task.Oct 7 2019, 12:01 PM

• alaa_wmde edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

Worked a bit on this trying to fix the tests.. but apparently a day was not enough, and what I thought was a solution (basically setting up the sites needed for relevant tests relevant tests which made them pass) caused other tests to fail.

Gonna need a bit more focus than that, so moved back to Ready to Pickup for lack of time currently

Rosalie_WMDE moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Oct 30 2019, 10:17 AM

Rosalie_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 30 2019, 11:15 AM

Rosalie_WMDE claimed this task.Oct 30 2019, 11:37 AM

Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 547543 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove siteLink groups from Wikibase registry

https://gerrit.wikimedia.org/r/547543

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 1 2019, 12:32 PM

Change 547543 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove siteLink groups from Wikibase registry

https://gerrit.wikimedia.org/r/547543

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 3 2019, 11:00 AM

Rosalie_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 4 2019, 10:42 AM

Rosalie_WMDE moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 7 2019, 1:28 PM

This comment was removed by Rosalie_WMDE.

Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 8 2019, 9:13 AM

Change 474844 abandoned by Alaa Sarhan:
Move siteLinkGroups to default config and empty

Reason:
already resolved in 547543

https://gerrit.wikimedia.org/r/474844