wfEscapeWikiText() emits error "PHP Notice: Array to string conversion" on Special:Search
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Nikerabbit
	Nov 6 2019, 5:54 PM

Description

message

[{exception_id}] {exception_url}   ErrorException from line 1591 of /srv/mediawiki/php-1.35.0-wmf.5/includes/GlobalFunctions.php: PHP Notice: Array to string conversion

trace

#0 /srv/mediawiki/php-1.35.0-wmf.5/includes/GlobalFunctions.php(1591): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 [internal function]: wfEscapeWikiText(array)
#2 /srv/mediawiki/php-1.35.0-wmf.5/includes/Status.php(295): array_map(string, array)
#3 /srv/mediawiki/php-1.35.0-wmf.5/includes/Status.php(198): Status->getErrorMessage(array, NULL)
#4 /srv/mediawiki/php-1.35.0-wmf.5/includes/Status.php(322): Status->getWikiText(string, boolean, NULL)
#5 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialSearch.php(411): Status->getHTML(string)
#6 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialSearch.php(179): SpecialSearch->showResults(string)
#7 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPage.php(575): SpecialSearch->execute(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(967): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(530): MediaWiki->main()
#12 /srv/mediawiki/php-1.35.0-wmf.5/index.php(46): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Original report from translatewiki.net:

#0 /www/dev.translatewiki.net/docroot/w/includes/GlobalFunctions.php(1591): MWExceptionHandler::handleError(8, 'Array to string...', '/www/dev.transl...', 1591, Array)
#1 [internal function]: wfEscapeWikiText(Array)
#2 /www/dev.translatewiki.net/docroot/w/includes/Status.php(295): array_map('wfEscapeWikiTex...', Array)
#3 /www/dev.translatewiki.net/docroot/w/includes/Status.php(198): Status->getErrorMessage(Array, NULL)
#4 /www/dev.translatewiki.net/docroot/w/includes/Status.php(322): Status->getWikiText('search-error', false, NULL)
#5 /www/dev.translatewiki.net/docroot/w/includes/specials/SpecialSearch.php(411): Status->getHTML('search-error')
#6 /www/dev.translatewiki.net/docroot/w/includes/specials/SpecialSearch.php(179): SpecialSearch->showResults('{{Doc viewed}} ...')
#7 /www/dev.translatewiki.net/docroot/w/includes/specialpage/SpecialPage.php(575): SpecialSearch->execute(NULL)
#8 /www/dev.translatewiki.net/docroot/w/includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#9 /www/dev.translatewiki.net/docroot/w/includes/MediaWiki.php(298): MediaWiki\\Special\\SpecialPageFactory->executePath(Object(Title), Object(RequestContext))
#10 /www/dev.translatewiki.net/docroot/w/includes/MediaWiki.php(967): MediaWiki->performRequest()
#11 /www/dev.translatewiki.net/docroot/w/includes/MediaWiki.php(530): MediaWiki->main()
#12 /www/dev.translatewiki.net/docroot/w/index.php(46): MediaWiki->run()
#13 {main}

Details

Request ID: XcSQ-wpAIC8AAHZhBJQAAABI
Request URL: https://www.wikidata.org/w/index.php?search=https%20%20%20exampleofadomain.com%20xxxxxxxxxxx%20xxx%20xx%20xx%20xx%20xxx%200000000000000000000%20xxxxxxxx%20xxxxx%200x%200F%200Fxxx.xxxxxx.xxx%200xxxxxx%200xxxxxxx%200xxx-xxxxx-xxxx-xxxxxxx%2000xxxxxxx%200xxxx%2000xxx%200xxxx%2000xx%200xhxxxx%200x%200x%200xxxx.xxxxxxxxx.xxx%200xxxxxx%200x0000%200x00%200xxxxxx-xxx-xx-xxx-xxxxxx-xxxx.xxxx%2000xxx%200xxxxxxxxx-xxx.&profile=default&fulltext=0&ns0=0

	Subject	Repo	Branch	Lines +/-
	Do not run wfEscapeWikiText on array in Status class	mediawiki/core	master	+23 -4
	Don't pass arrays into Status i18n messages	mediawiki/extensions/CirrusSearch	master	+7 -10

Customize query in gerrit

Related Objects

Mentioned In: rECIR462c1ed50552: Don't pass arrays into Status i18n messages

Event Timeline

Nikerabbit created this task.Nov 6 2019, 5:54 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptNov 6 2019, 5:54 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Also happening on production (rarely though) according to Logstash.

Krinkle renamed this task from "PHP Notice: Array to string conversion" on long search request to wfEscapeWikiText() emits error "PHP Notice: Array to string conversion" on Special:Search.Nov 7 2019, 9:40 PM

Krinkle moved this task from Untriaged to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.

Krinkle merged a task: T237686: Array to string conversion in wfEscapeWikiText.

Krinkle added a subscriber: • mmodell.

Krinkle updated the task description. (Show Details)Nov 7 2019, 9:48 PM

Krinkle changed the subtype of this task from "Task" to "Production Error".

Krinkle set Request URL to https://www.wikidata.org/w/index.php?search=https%20%20%20exampleofadomain.com%20xxxxxxxxxxx%20xxx%20xx%20xx%20xx%20xxx%200000000000000000000%20xxxxxxxx%20xxxxx%200x%200F%200Fxxx.xxxxxx.xxx%200xxxxxx%200xxxxxxx%200xxx-xxxxx-xxxx-xxxxxxx%2000xxxxxxx%200xxxx%2000xxx%200xxxx%2000xx%200xhxxxx%200x%200x%200xxxx.xxxxxxxxx.xxx%200xxxxxx%200x0000%200x00%200xxxxxx-xxx-xx-xxx-xxxxxx-xxxx.xxxx%2000xxx%200xxxxxxxxx-xxx.&profile=default&fulltext=0&ns0=0.Nov 7 2019, 9:50 PM

Found in production as well. Reliably reproducible via https://www.wikidata.org/w/index.php?search=https%20%20%20exampleofadomain.com%20xxxxxxxxxxx%20xxx%20xx%20xx%20xx%20xxx%200000000000000000000%20xxxxxxxx%20xxxxx%200x%200F%200Fxxx.xxxxxx.xxx%200xxxxxx%200xxxxxxx%200xxx-xxxxx-xxxx-xxxxxxx%2000xxxxxxx%200xxxx%2000xxx%200xxxx%2000xx%200xhxxxx%200x%200x%200xxxx.xxxxxxxxx.xxx%200xxxxxx%200x0000%200x00%200xxxxxx-xxx-xx-xxx-xxxxxx-xxxx.xxxx%2000xxx%200xxxxxxxxx-xxx.&profile=default&fulltext=0&ns0=0

Umherirrender merged a task: T237896: PHP Notice: Array to string conversion in GlobalFunctions::wfEscapeWikiText().Nov 13 2019, 8:08 PM

Umherirrender added a subscriber: Reedy.

wfEscapeWikiText is called for each parameter of the given parameter list for a message, but it is possible to do more complex parameter params as only strings. Using Message::listParam for example produce an array which cannot be work on with` wfEscapeWikiText`

Failing:
$status = Status::newGood();
$status->error( 'lastmodifiedat', 'first', Message::numParam( 5 ) );
echo $status->getHTML( 'internalerror_info' );

=> Internal error: This page was last edited on first, at Array.

Works:
$status = Status::newGood();
$status->error( 'lastmodifiedat', 'first', '5' );
echo $status->getHTML( 'internalerror_info' );

=> Internal error: This page was last edited on first, at 5.

This can happen on every code path formatting the error text and not passing a message object on error.

Also happening on production (rarely though) according to Logstash.

Not rarely, although the rate is not huge: https://logstash.wikimedia.org/goto/aea2cb6ac106291659dd50190cf3f7f3

Change 552335 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Don't pass arrays into Status i18n messages

https://gerrit.wikimedia.org/r/552335

gerritbot added a project: Patch-For-Review.Nov 21 2019, 9:11 PM

EBernhardson claimed this task.Nov 21 2019, 9:13 PM

EBernhardson triaged this task as Medium priority.

EBernhardson moved this task from needs triage to Current work on the Discovery-Search board.

EBernhardson edited projects, added Discovery-Search (Current work); removed Discovery-Search.

EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Nov 22 2019, 12:03 AM

Change 552335 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Don't pass arrays into Status i18n messages

https://gerrit.wikimedia.org/r/552335

EBernhardson mentioned this in rECIR462c1ed50552: Don't pass arrays into Status i18n messages.Nov 22 2019, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2019, 9:11 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 22 2019, 10:00 AM

Krinkle moved this task from Nov2019/1.35.wmf.5+ to Resolved on the Wikimedia-production-error board.Nov 24 2019, 3:16 AM

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Nov 25 2019, 5:10 PM

brennen subscribed.Nov 25 2019, 7:04 PM

I am seeing ATM errors:

/wiki/Special:Search?search=<search string>&ns0=1   ErrorException from line 1591 of /srv/mediawiki/php-1.35.0-wmf.5/includes/GlobalFunctions.php: PHP Notice: Array to string conversion

Such as: https://logstash.wikimedia.org/goto/ba65dd4317ecfef44eac4372c9c13a62

Could you confirm they are the same origin, and will be fixed after wmf8 gets deployed, and not different kind of errors with the same error message?

In T237559#5692007, @jcrespo wrote:
I am seeing ATM errors:
/wiki/Special:Search?search=<search string>&ns0=1   ErrorException from line 1591 of /srv/mediawiki/php-1.35.0-wmf.5/includes/GlobalFunctions.php: PHP Notice: Array to string conversion
Such as: https://logstash.wikimedia.org/goto/ba65dd4317ecfef44eac4372c9c13a62

Could you confirm they are the same origin, and will be fixed after wmf8 gets deployed, and not different kind of errors with the same error message?

These have the same error signature, essentially bots sending excessively long search queries. They will be covered by the fix.

Thank you for checking!

jcrespo awarded a token.Nov 26 2019, 5:55 PM

TJones closed this task as Resolved.Nov 27 2019, 4:40 PM

Umherirrender merged a task: T239239: PHP Notice: Array to string conversion.Nov 28 2019, 8:16 PM

Umherirrender added a subscriber: Daimona.

Change 553519 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Do not run wfEscapeWikiText on array in Status class

https://gerrit.wikimedia.org/r/553519

gerritbot added a project: Patch-For-Review.Nov 28 2019, 8:17 PM

Change 553519 merged by jenkins-bot:
[mediawiki/core@master] Do not run wfEscapeWikiText on array in Status class

https://gerrit.wikimedia.org/r/553519

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2019, 9:10 AM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Dec 4 2019, 10:00 AM