Page MenuHomePhabricator
Create Task
Maniphest T247690

Detail of error message is no longer shown in Wikidata edit interface
Closed, ResolvedPublic
Actions

Description

Reproduce 1:

Reproduce 2:

Expected:

You will see a detailed error message. This may include AbuseFilter warning or disallow message.

Actual:

  • You only see "The save has failed."
  • The message is not localized. (T250889)

At least seen since Feb 24: https://www.wikidata.org/wiki/Wikidata:Project_chat/Archive/2020/02#How_to_edit_label?

Details

SubjectRepoBranchLines +/-
Increase error tooltip max-width from 15em to 17emmediawiki/extensions/Wikibasemaster+5 -0
Update wikibase-api to 3.2.0mediawiki/extensions/Wikibasemaster+1 -1
RepoApiError: Pick the best error to reportwikibase/javascript-apimaster+23 -7
Customize query in gerrit

Related Objects

Event Timeline

Bugreporter created this task.Mar 15 2020, 9:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2020, 9:38 AM
Bugreporter updated the task description. (Show Details)Mar 15 2020, 9:40 AM
matej_suchanek subscribed.Mar 15 2020, 10:18 AM

Other (similar) reports:

Lea_Lacroix_WMDE added a subscriber: Lydia_Pintscher.Mar 18 2020, 12:34 PM
Lea_Lacroix_WMDE subscribed.
Lydia_Pintscher triaged this task as High priority.Mar 18 2020, 1:31 PM
Lydia_Pintscher added a project: Wikidata-Campsite.
Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.
Keyacom subscribed.Mar 25 2020, 6:53 AM

When I did my first-ever edit on Wikidata, i.e. on Q13517472, the warning that the edit activated the abuse filter 10 had shown normally.

matej_suchanek added a comment.Mar 25 2020, 9:46 AM

3 March 2020 when Wikidata was 1.35.0-wmf.21.

Bugreporter merged a task: T249728: Error message for duplicate sitelink edits is very unclear.Apr 8 2020, 4:47 PM
Bugreporter added a subscriber: agray.
Bugreporter merged a task: T250876: API error adding serbian entry to wikidata.Apr 22 2020, 12:12 AM
Bugreporter added subscribers: RoySmith, • Petar.petkovic.
Raymond updated the task description. (Show Details)Apr 22 2020, 6:58 AM
Addshore subscribed.Apr 28 2020, 12:31 PM

This probably relates to the recent errorformat changes in Wikibase recently in T242769.
This was deployed with 1.35.0-wmf.21

WMDE-leszek moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Apr 28 2020, 12:32 PM
WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Apr 28 2020, 1:15 PM
Addshore mentioned this in T242769: Wikibase UI API calls should request a specific errorformat and uselang.May 4 2020, 1:12 PM
hoo claimed this task.May 6 2020, 1:04 PM
hoo moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.May 12 2020, 6:24 PM

Change 596007 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[wikibase/javascript-api@master] RepoApiError: Pick the best error to report

https://gerrit.wikimedia.org/r/596007

gerritbot added a project: Patch-For-Review.May 12 2020, 6:24 PM
hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 12 2020, 6:25 PM
gerritbot added a comment.May 12 2020, 6:33 PM

Change 596007 merged by jenkins-bot:
[wikibase/javascript-api@master] RepoApiError: Pick the best error to report

https://gerrit.wikimedia.org/r/596007

Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 7:10 PM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 13 2020, 10:17 AM
hoo moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 13 2020, 5:34 PM

This still needs the release preparation patch to be merged (https://gerrit.wikimedia.org/r/c/wikibase/javascript-api/+/596231), then we can tag it (while doing that, we should also tag the past 3.1.1 release as that was forgotten back then). After that, the subcomponent can be bumped in Wikibase and we should be good here.

Lydia_Pintscher mentioned this in T252668: Impossible editing Q84761767.May 14 2020, 9:25 AM
gerritbot added a comment.May 15 2020, 4:36 PM

Change 596684 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Update wikibase-api to 3.2.0

https://gerrit.wikimedia.org/r/596684

gerritbot added a project: Patch-For-Review.May 15 2020, 4:36 PM
hoo added a comment.May 15 2020, 4:39 PM

I tagged the release now, so we only need to update the submodule in Wikibase now.

LucasWerkmeister merged a task: T252944: Better error message for when Q-item already linked to Wikipedia..May 16 2020, 3:21 PM
LucasWerkmeister added a subscriber: 1Veertje.
gerritbot added a comment.May 18 2020, 4:16 PM

Change 596684 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update wikibase-api to 3.2.0

https://gerrit.wikimedia.org/r/596684

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 18 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 18 2020, 5:10 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 18 2020, 5:21 PM
Lucas_Werkmeister_WMDE subscribed.

Should be possible to verify on Beta now; I’ve set up an AbuseFilter on Beta that mirrors the P​21 one on Wikidata, so if you try to add “sex or gender” (here, P​963) with an invalid value (e. g. Q​6) to an item, you should get an error, and see the detail in the error message.

Lydia_Pintscher moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 28 2020, 6:22 PM

Tested it on production via the testcases in the description. Duplicate sitelink warning seems fine. However this is quite beautiful 😬

image.png (362×932 px, 33 KB)

Anything we can do to improve it?

matej_suchanek mentioned this in T163713: Client widget does not report the actual problem.May 29 2020, 11:49 AM
gerritbot added a comment.May 29 2020, 1:04 PM

Change 599836 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Increase error tooltip max-width from 15em to 17em

https://gerrit.wikimedia.org/r/599836

gerritbot added a project: Patch-For-Review.May 29 2020, 1:04 PM
hoo moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 29 2020, 1:12 PM
hoo moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
matej_suchanek added a comment.May 29 2020, 1:18 PM

I wanted to translate the warning "The save has failed." but apparently it is ignored by translatewiki (wikibase-api-failed-save), that's probably why everybody can only see it in English. The list of ignored messages is longer and should get some attention.

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 2 2020, 2:25 PM
gerritbot added a comment.Jun 2 2020, 2:43 PM

Change 599836 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Increase error tooltip max-width from 15em to 17em

https://gerrit.wikimedia.org/r/599836

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).Jun 2 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 2 2020, 3:11 PM
Lydia_Pintscher added a comment.Jun 16 2020, 4:18 PM

Tested more. Looking acceptable now :D Thank you!

Leaving the ticket open because of @matej_suchanek's comment.

Lydia_Pintscher moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 2 2020, 4:58 PM
hoo closed this task as Resolved.Jul 4 2020, 2:12 PM
hoo mentioned this in T257113: Review list of messages marked as ignored for translation.
hoo moved this task from To Do (prioritised from top to bottom) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
In T247690#6228627, @Lydia_Pintscher wrote:

Tested more. Looking acceptable now :D Thank you!

Leaving the ticket open because of @matej_suchanek's comment.

I filled T257113: Review list of messages marked as ignored for translation for that (as it is, strictly speaking, unrelated to the issues brought up here), so that we can finally close this one.

Lucas_Werkmeister_WMDE mentioned this in T304945: Remove custom error responses (localization, several errors) from Wikibase APIs.Mar 29 2022, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits