Page MenuHomePhabricator

Update parserTests in TimedMediaHandler extension to v2
Closed, ResolvedPublic

Description

ParserTests are the only place where we still run the parser in "no tidy" mode. We need to update the output of the parserTests used by this extension to have properly tidied output. Adding !! version 2 as the first line of your parserTests file opts in to this new behavior, and you can easily see which tests fail. Usually the clean up is pretty straightforward.

See https://gerrit.wikimedia.org/r/565146 for a description of typical fixups.

See https://gerrit.wikimedia.org/r/568093 patchset 1 for how to get started (just add !! version 2 to all your parser tests files and see what breaks!

Event Timeline

Change 585284 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/TimedMediaHandler@master] WIP: Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585284

Change 585284 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585284

cscott claimed this task.

Change 620765 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/TEI@master] Update parser tests files to version 2

https://gerrit.wikimedia.org/r/620765