Page MenuHomePhabricator
Create Task
Maniphest T258558

Error messages for API modules that will not work with federated properties MVP
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

We've identified a need for error messaging for the following API modules when trying to interact with properties.
The error message should be consistent across all of endpoints and should say something like "You can not interact with properties using this API while federated properties is enabled"

Get API modules that can interact with properties

Edit API modules that interact with properties :

Initial Estimation

  • For the errors that appear for APIs that must not work with federated properties (API modules that interact with properties): 8

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

• Samantha_Alipio_WMDE created this task.Jul 22 2020, 7:35 AM
• Samantha_Alipio_WMDE moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.
Addshore added a project: Story.Jul 23 2020, 12:06 PM
• Samantha_Alipio_WMDE set the point value for this task to 8.Jul 23 2020, 12:09 PM
• Samantha_Alipio_WMDE moved this task from Ready to estimate to Ready for Breakdown on the Wikibase - Federated Properties board.
Addshore moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Aug 14 2020, 9:48 AM
Addshore updated the task description. (Show Details)Aug 14 2020, 9:56 AM
Addshore claimed this task.Aug 14 2020, 11:14 AM
Addshore moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 4/6 (Hike 2) on the Wikibase - Federated Properties board.
Addshore edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 2)); removed Wikibase - Federated Properties.
Addshore moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptAug 14 2020, 11:14 AM
Addshore removed Addshore as the assignee of this task.Aug 14 2020, 11:15 AM
Addshore moved this task from Doing to To do on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.
Addshore subscribed.
• toan claimed this task.Aug 14 2020, 11:45 AM
• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.
gerritbot added a comment.Aug 14 2020, 12:36 PM

Change 620326 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: Create claim should not allow altering properties

https://gerrit.wikimedia.org/r/620326

gerritbot added a project: Patch-For-Review.Aug 14 2020, 12:36 PM
• toan updated the task description. (Show Details)Aug 14 2020, 12:39 PM
• toan removed • toan as the assignee of this task.Aug 14 2020, 12:46 PM
• toan moved this task from Doing to To do on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.
• toan subscribed.
• toan claimed this task.Aug 14 2020, 1:40 PM
• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.
gerritbot added a comment.Aug 14 2020, 2:00 PM

Change 620325 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: Prepare api for invalidating editing properties

https://gerrit.wikimedia.org/r/620325

gerritbot added a comment.Aug 14 2020, 3:33 PM

Change 620373 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: Modify/Edit-Entity should not allow altering properties

https://gerrit.wikimedia.org/r/620373

• toan updated the task description. (Show Details)Aug 14 2020, 3:35 PM
gerritbot added a comment.Aug 14 2020, 4:03 PM

Change 620374 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: RemoveClaims should not allow altering properties

https://gerrit.wikimedia.org/r/620374

• toan updated the task description. (Show Details)Aug 17 2020, 7:35 AM
gerritbot added a comment.Aug 17 2020, 8:10 AM

Change 620650 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: RemoveQualifiers should not allow altering properties

https://gerrit.wikimedia.org/r/620650

• toan updated the task description. (Show Details)Aug 17 2020, 8:11 AM
gerritbot added a comment.Aug 17 2020, 10:52 AM

Change 620686 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: RemoveReferences should not allow altering properties.

https://gerrit.wikimedia.org/r/620686

• toan updated the task description. (Show Details)Aug 17 2020, 10:59 AM
gerritbot added a comment.Aug 17 2020, 11:06 AM

Change 620687 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: SetReference should not allow altering properties

https://gerrit.wikimedia.org/r/620687

• toan updated the task description. (Show Details)Aug 17 2020, 11:07 AM
• toan updated the task description. (Show Details)Aug 17 2020, 11:15 AM
gerritbot added a comment.Aug 17 2020, 11:27 AM

Change 620690 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: SetClaim should not allow altering properties.

https://gerrit.wikimedia.org/r/620690

• toan updated the task description. (Show Details)Aug 17 2020, 11:31 AM
gerritbot added a comment.Aug 17 2020, 11:56 AM

Change 620693 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: SetClaimValue should not allow altering properties.

https://gerrit.wikimedia.org/r/620693

• toan updated the task description. (Show Details)Aug 17 2020, 11:57 AM
gerritbot added a comment.Aug 17 2020, 12:09 PM

Change 620695 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: SetQualifier should not allow altering properties.

https://gerrit.wikimedia.org/r/620695

• toan updated the task description. (Show Details)Aug 17 2020, 12:09 PM
gerritbot added a comment.Aug 17 2020, 12:28 PM

Change 620697 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: GetEntities should return an error when getting properties

https://gerrit.wikimedia.org/r/620697

• toan updated the task description. (Show Details)Aug 17 2020, 12:28 PM
• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 17 2020, 1:47 PM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 5/6 (Hike 2)); removed Wikibase - Federated Properties (Sprint 4/6 (Hike 2)).Aug 19 2020, 8:38 AM
• Samantha_Alipio_WMDE moved this task from To do to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.
gerritbot added a comment.Aug 19 2020, 12:38 PM

Change 620325 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Prepare api for invalidating editing properties

https://gerrit.wikimedia.org/r/620325

gerritbot added a comment.Aug 19 2020, 12:55 PM

Change 620326 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Create claim should not allow altering properties

https://gerrit.wikimedia.org/r/620326

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 1:00 PM
gerritbot added a comment.Aug 19 2020, 1:05 PM

Change 620686 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: RemoveReferences should not allow altering properties.

https://gerrit.wikimedia.org/r/620686

gerritbot added a comment.Aug 19 2020, 1:06 PM

Change 620687 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: SetReference should not allow altering properties

https://gerrit.wikimedia.org/r/620687

gerritbot added a comment.Aug 19 2020, 1:15 PM

Change 620650 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: RemoveQualifiers should not allow altering properties

https://gerrit.wikimedia.org/r/620650

gerritbot added a comment.Aug 19 2020, 2:51 PM

Change 620373 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Modify/Edit-Entity should not allow altering properties

https://gerrit.wikimedia.org/r/620373

gerritbot added a comment.Aug 19 2020, 3:06 PM

Change 620697 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: GetEntities should return an error when getting properties

https://gerrit.wikimedia.org/r/620697

gerritbot added a comment.Aug 19 2020, 3:09 PM

Change 620695 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: SetQualifier should not allow altering properties.

https://gerrit.wikimedia.org/r/620695

gerritbot added a comment.Aug 19 2020, 3:17 PM

Change 620693 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: SetClaimValue should not allow altering properties.

https://gerrit.wikimedia.org/r/620693

gerritbot added a comment.Aug 19 2020, 4:28 PM

Change 620690 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: SetClaim should not allow altering properties.

https://gerrit.wikimedia.org/r/620690

Rosalie_WMDE updated the task description. (Show Details)Aug 20 2020, 2:17 PM
Rosalie_WMDE moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Aug 20 2020, 2:31 PM
Rosalie_WMDE moved this task from Product Verification to Done on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.
gerritbot added a comment.Aug 20 2020, 2:41 PM

Change 620374 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: RemoveClaims should not allow altering properties

https://gerrit.wikimedia.org/r/620374

Addshore closed this task as Resolved.Oct 30 2020, 5:50 PM
gerritbot added a comment.Feb 24 2021, 7:17 PM

Change 666724 had a related patch set uploaded (by Hoo man; owner: Addshore):
[mediawiki/extensions/Wikibase@REL1_35] Backport five FP changes

https://gerrit.wikimedia.org/r/666724

gerritbot added a comment.Mar 4 2021, 5:24 PM

Change 666724 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Backport five FP changes

https://gerrit.wikimedia.org/r/666724

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits