T275617: Update SecurePoll to use the new HookContainer/HookRunner system updated SecurePoll to use the new hook system for its hook handlers. SecurePoll also emits its own hooks, SecurePoll_GetUserParams and SecurePoll_JumpUrl, and those should be converted to the new system as well, namely adding hook interfaces that other extensions can use and a hook runner class. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/664895 for an example in CentralAuth.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Umherirrender | T335536 Hard deprecate class Hooks with all deprecated functions (and remove in 1.42) | |||
| Open | None | T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system | |||
| Open | None | T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system | |||
| Resolved | Zabe | T289950 SecurePoll should use the new hook runner system for its own hooks |
Event Timeline
Comment Actions
Change 716078 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/SecurePoll@master] Use the new hook system for hooks provided by SecurePoll
https://gerrit.wikimedia.org/r/716078
Comment Actions
Change 716078 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Use the new hook system for hooks provided by SecurePoll
https://gerrit.wikimedia.org/r/716078
Comment Actions
Change 730215 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/SecurePoll@master] Fix wrong var being passed
https://gerrit.wikimedia.org/r/730215
Comment Actions
Change 730230 had a related patch set uploaded (by Majavah; author: Zabe):
[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.3] Fix wrong var being passed
https://gerrit.wikimedia.org/r/730230
Comment Actions
Change 730231 had a related patch set uploaded (by Majavah; author: Zabe):
[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.4] Fix wrong var being passed
https://gerrit.wikimedia.org/r/730231
Comment Actions
Change 730215 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Fix wrong var being passed
https://gerrit.wikimedia.org/r/730215
Comment Actions
Change 730230 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.3] Fix wrong var being passed
https://gerrit.wikimedia.org/r/730230
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2021-10-12T15:58:15Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/SecurePoll/includes/Hooks/HookRunner.php: Backport: [[gerrit:730230|Fix wrong var being passed (T289950 T293102)]] (duration: 02m 13s)
Comment Actions
Change 730231 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.4] Fix wrong var being passed
https://gerrit.wikimedia.org/r/730231
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2021-10-12T16:06:08Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/SecurePoll/includes/Hooks/HookRunner.php: Backport: [[gerrit:730231|Fix wrong var being passed (T289950 T293102)]] (duration: 00m 57s)