Once the new FallbackLabelDescriptionLookupFactory has been created (T312222), it should be used by most places that want a FallbackLabelDescriptionLookup; this especially includes most (possibly all) users of LanguageFallbackLabelDescriptionLookupFactory. See also the list in T305032#8052212.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | BUG REPORT | Lucas_Werkmeister_WMDE | T305032 Lexeme pages do not show labels of redirected Items (unlike Item pages) | ||
Resolved | Lucas_Werkmeister_WMDE | T312223 Use FallbackLabelDescriptionLookupFactory in code | |||
Declined | None | T312780 Provide EntityRevisionLookup for federated properties | |||
Resolved | Lucas_Werkmeister_WMDE | T312791 Implement FallbackLabelDescriptionLookup that supports federated properties |
Event Timeline
Change 812024 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme ID formatter
https://gerrit.wikimedia.org/r/812024
Change 812025 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form ID formatter
https://gerrit.wikimedia.org/r/812025
Change 812026 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme formatter
https://gerrit.wikimedia.org/r/812026
Change 812027 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form formatter
https://gerrit.wikimedia.org/r/812027
Change 812028 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for meta tags creator
https://gerrit.wikimedia.org/r/812028
Change 812029 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in LexemeHandler
https://gerrit.wikimedia.org/r/812029
Change 812244 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlpha
https://gerrit.wikimedia.org/r/812244
Change 812024 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme ID formatter
https://gerrit.wikimedia.org/r/812024
Change 812025 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form ID formatter
https://gerrit.wikimedia.org/r/812025
Change 812026 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme formatter
https://gerrit.wikimedia.org/r/812026
Change 812027 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form formatter
https://gerrit.wikimedia.org/r/812027
Change 812028 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for meta tags creator
https://gerrit.wikimedia.org/r/812028
Change 812029 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in LexemeHandler
https://gerrit.wikimedia.org/r/812029
Change 812839 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in entity types
https://gerrit.wikimedia.org/r/812839
Change 812871 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexeme
https://gerrit.wikimedia.org/r/812871
Change 812896 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in client hook handlers
https://gerrit.wikimedia.org/r/812896
Change 813212 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in property entity types
https://gerrit.wikimedia.org/r/813212
Change 812839 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in item entity types
https://gerrit.wikimedia.org/r/812839
Change 813212 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in property entity types
https://gerrit.wikimedia.org/r/813212
Change 812896 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in client hook handlers
https://gerrit.wikimedia.org/r/812896
Change 812871 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexeme
https://gerrit.wikimedia.org/r/812871
Change 812244 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlpha
https://gerrit.wikimedia.org/r/812244
Change 813635 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory for entity search callbacks
https://gerrit.wikimedia.org/r/813635
Change 813637 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in ItemHandler
https://gerrit.wikimedia.org/r/813637
Change 813639 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in PropertyHandler
https://gerrit.wikimedia.org/r/813639
Change 813647 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in EntityIdLabelFormatterFactory
https://gerrit.wikimedia.org/r/813647
Change 813635 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in entity search callbacks
https://gerrit.wikimedia.org/r/813635
Change 813656 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialSetSiteLink
https://gerrit.wikimedia.org/r/813656
Change 813659 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Math@master] Use FallbackLabelDescriptionLookupFactory in MathWikibaseConfig
https://gerrit.wikimedia.org/r/813659
Change 813659 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Use FallbackLabelDescriptionLookupFactory in MathWikibaseConfig
https://gerrit.wikimedia.org/r/813659
Change 814118 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialListProperties
https://gerrit.wikimedia.org/r/814118
Change 814119 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseCirrusSearch@master] Use FallbackLabelDescriptionLookupFactory in Hooks
https://gerrit.wikimedia.org/r/814119
Change 814171 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SidebarLinkBadgeDisplay
https://gerrit.wikimedia.org/r/814171
Change 814173 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialPagesWithBadges
https://gerrit.wikimedia.org/r/814173
Change 814179 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in newSnakSerializationRenderer
https://gerrit.wikimedia.org/r/814179
Stating the obvious:
For extensions, this creates a dependency on 1.39-wmf.21 . Otherwise you will see
Call to undefined method Wikibase\Client\WikibaseClient::getFallbackLabelDescriptionLookupFactory()
;-)
Change 813637 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in ItemHandler
https://gerrit.wikimedia.org/r/813637
Change 813639 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in PropertyHandler
https://gerrit.wikimedia.org/r/813639
Change 814119 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Use FallbackLabelDescriptionLookupFactory in Hooks
https://gerrit.wikimedia.org/r/814119
Change 813647 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in EntityIdLabelFormatterFactory
https://gerrit.wikimedia.org/r/813647
Change 813656 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialSetSiteLink
https://gerrit.wikimedia.org/r/813656
Change 814118 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialListProperties
https://gerrit.wikimedia.org/r/814118
Change 814171 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SidebarLinkBadgeDisplay
https://gerrit.wikimedia.org/r/814171
Change 814173 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialPagesWithBadges
https://gerrit.wikimedia.org/r/814173
Change 814179 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in newSnakSerializationRenderer
https://gerrit.wikimedia.org/r/814179
Change 816816 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in DataAccessSnakFormatterFactory
https://gerrit.wikimedia.org/r/816816
Change 816816 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in DataAccessSnakFormatterFactory
https://gerrit.wikimedia.org/r/816816
Wikibase is pretty much done, but a few other extensions are still using the old factory (see codesearch).
Change 817219 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/ArticlePlaceholder@master] Use FallbackLabelDescriptionLookupFactory in AboutTopicRenderer
https://gerrit.wikimedia.org/r/817219
Change 817219 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Use FallbackLabelDescriptionLookupFactory in AboutTopicRenderer
https://gerrit.wikimedia.org/r/817219