Page MenuHomePhabricator
Create Task
Maniphest T329268

Adjust scroll into view to prevent overlapping with buttons
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
lilients_WMDE
Feb 9 2023, 10:23 AM
Tags
Referenced Files
F36912817: Screenshot from 2023-03-15 13-49-50.png
Mar 15 2023, 12:50 PM
F36912814: Screenshot from 2023-03-15 13-49-32.png
Mar 15 2023, 12:50 PM
F36912809: Screenshot from 2023-03-15 13-48-14.png
Mar 15 2023, 12:50 PM
F36817323: Screenshot from 2023-02-09 11-20-48.png
Feb 9 2023, 10:23 AM
Subscribers
Aklapper
lilients_WMDE

Description

When you click a marker near to top border, the popup scrolls into view. Since the scrolling triggers the reload button, there currently can be an overlapping. Also the buttons on the sides can overlap with a popup.

Screenshot from 2023-02-09 11-20-48.png (421×464 px, 200 KB)
Screenshot from 2023-03-15 13-48-14.png (504×510 px, 180 KB)
  • Change the top padding of the scroll into view so that the popup shows below the button.
  • Change padding to the sides to prevent overlapping with buttons there (zoom, close button, etc.).

Results

Screenshot from 2023-03-15 13-49-32.png (488×527 px, 143 KB)
Screenshot from 2023-03-15 13-49-50.png (571×544 px, 190 KB)

Details

SubjectRepoBranchLines +/-
Use larger autoPanPadding only for nearby popupsmediawiki/extensions/Kartographermaster+2 -1
Adjust autoPanPadding to prevent overlapping with buttonsmediawiki/extensions/Kartographermaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT90645 A better Nearby for Wikivoyage
 OpenNoneT304076 Nearby feature for maps
 ResolvedNoneT329268 Adjust scroll into view to prevent overlapping with buttons

Event Timeline

lilients_WMDE created this task.Feb 9 2023, 10:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2023, 10:23 AM
lilients_WMDE added a parent task: T304076: Nearby feature for maps.Feb 9 2023, 10:26 AM
lilients_WMDE claimed this task.Feb 14 2023, 3:40 PM
lilients_WMDE added a project: WMDE-TechWish-Sprint-2023-01-18.
lilients_WMDE moved this task from Ready for pickup to In sprint on the WMDE-GeoInfo-FocusArea board.
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-01-18 board.
lilients_WMDE removed lilients_WMDE as the assignee of this task.Feb 20 2023, 4:53 PM
lilients_WMDE moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2023-01-18 board.
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2023-03-14.Mar 13 2023, 1:26 PM
lilients_WMDE claimed this task.Mar 15 2023, 12:37 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-03-14 board.
lilients_WMDE updated Other Assignee, added: WMDE-Fisch.
gerritbot added a comment.Mar 15 2023, 12:43 PM

Change 899606 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/Kartographer@master] Adjust autoPanPadding to prevent overlapping with buttons

https://gerrit.wikimedia.org/r/899606

gerritbot added a project: Patch-For-Review.Mar 15 2023, 12:43 PM
lilients_WMDE renamed this task from Adjust scroll into view to prevent overlapping with reload button to Adjust scroll into view to prevent overlapping with buttons.Mar 15 2023, 12:50 PM
lilients_WMDE updated the task description. (Show Details)
lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-03-14 board.Mar 15 2023, 12:54 PM
gerritbot added a comment.Mar 15 2023, 1:21 PM

Change 899606 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Adjust autoPanPadding to prevent overlapping with buttons

https://gerrit.wikimedia.org/r/899606

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2023, 1:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 15 2023, 2:00 PM
lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-03-14 board.Mar 15 2023, 2:06 PM
lilients_WMDE updated the task description. (Show Details)Mar 15 2023, 3:14 PM
gerritbot added a comment.Mar 16 2023, 5:28 PM

Change 900398 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Use larger autoPanPadding only for nearby popups

https://gerrit.wikimedia.org/r/900398

gerritbot added a project: Patch-For-Review.Mar 16 2023, 5:28 PM
gerritbot added a comment.Mar 23 2023, 10:13 AM

Change 900398 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use larger autoPanPadding only for nearby popups

https://gerrit.wikimedia.org/r/900398

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2023, 10:30 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.2; 2023-03-27); removed MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 23 2023, 11:00 AM
WMDE-Fisch removed lilients_WMDE as the assignee of this task.Apr 4 2023, 8:50 AM
WMDE-Fisch updated Other Assignee, removed: WMDE-Fisch.
thiemowmde closed this task as Resolved.Apr 4 2023, 9:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits