Page MenuHomePhabricator
Create Task
Maniphest T334738

Replace Alias Chip component with Codex FilterChip
Closed, ResolvedPublic
Actions

Description

the alias component in FunctionEditorAliases.vue should use the codex filterChip component instead of using a custom chip component.

The chip component can also be deleted with this change.

Blocked on codex implementation: https://phabricator.wikimedia.org/T324223

Details

SubjectRepoBranchLines +/-
Drop our local Chip and ChipContainer components, now unusedmediawiki/extensions/WikiLambdamaster+5 -321
Implement new About widget designmediawiki/extensions/WikiLambdamaster+3 K -3 K
FunctionEditorAliases: Replace wl-chip-container with the Codex ChipInputmediawiki/extensions/WikiLambdamaster+111 -136
[WIP] Replace Alias Chip with ChpInput Componentmediawiki/extensions/WikiLambdamaster+161 -141
[WIP] Replace wl-chip-container with cdx-chip-inputmediawiki/extensions/WikiLambdamaster+37 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKieserman renamed this task from Replace Alias Chip component with to Replace Alias Chip component with Codex FilterChip.Apr 14 2023, 1:58 PM
• JKieserman created this task.
• JKieserman mentioned this in T318148: Function editor: Aliases component improvements.
Jdforrester-WMF added a subtask: T324223: FilterChip: Add FilterChip component to Codex.Apr 17 2023, 3:51 PM
Jdforrester-WMF moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.
Volker_E closed subtask T324223: FilterChip: Add FilterChip component to Codex as Resolved.Aug 2 2023, 9:16 AM
• CCoxwell-WMF claimed this task.Oct 9 2023, 5:46 PM
gerritbot added a comment.Oct 9 2023, 11:18 PM

Change 964585 had a related patch set uploaded (by Ccoxwell; author: Ccoxwell):

[mediawiki/extensions/WikiLambda@master] [WIP] Replace wl-chip-container with cdx-chip-input

https://gerrit.wikimedia.org/r/964585

gerritbot added a project: Patch-For-Review.Oct 9 2023, 11:18 PM
Jdforrester-WMF changed the task status from Open to In Progress.Oct 12 2023, 4:44 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage: Nice-to-haves to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Oct 27 2023, 6:48 PM

Change 964585 abandoned by Ccoxwell:

[mediawiki/extensions/WikiLambda@master] [WIP] Replace wl-chip-container with cdx-chip-input

Reason:

https://gerrit.wikimedia.org/r/964585

gerritbot added a comment.Oct 27 2023, 7:03 PM

Change 969385 had a related patch set uploaded (by Ccoxwell; author: Ccoxwell):

[mediawiki/extensions/WikiLambda@master] [WIP] Replace Alias Chip with ChipInput Component

https://gerrit.wikimedia.org/r/969385

gerritbot added a comment.Oct 27 2023, 9:12 PM

Change 969385 had a related patch set uploaded (by Ccoxwell; author: Ccoxwell):

[mediawiki/extensions/WikiLambda@master] [WIP] Replace Alias Chip with ChpInput Component

https://gerrit.wikimedia.org/r/969385

Jdforrester-WMF removed • CCoxwell-WMF as the assignee of this task.Nov 6 2023, 8:41 PM
Jdforrester-WMF added a subscriber: • CCoxwell-WMF.
Jdforrester-WMF moved this task from In Progress to Backlog on the Abstract Wikipedia team board.Nov 17 2023, 6:16 PM
Jdforrester-WMF changed the task status from In Progress to Open.Jan 22 2024, 8:07 PM
gerritbot added a comment.Jan 22 2024, 8:08 PM

Change 969385 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] [WIP] Replace Alias Chip with ChpInput Component

Reason:

https://gerrit.wikimedia.org/r/969385

AAlhazwani-WMF mentioned this in T353236: Function Editor: Change function descriptions to use cdx-text-area not cdx-input.Mar 5 2024, 10:11 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed Patch-For-Review.Mar 26 2024, 12:05 PM
gengh added a subtask: T336347: ChipContainer and Chip components: Decouple these componets from the internal structure of zobject data.Jun 14 2024, 9:01 AM
gengh claimed this task.Jun 26 2024, 5:10 PM

This task will be addressed while working on https://phabricator.wikimedia.org/T360610

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.Jun 26 2024, 5:12 PM
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jdforrester-WMF added a subtask: T360610: [25Q1] Improve About widget experience for translators and multi-lingual contributors.Jul 3 2024, 4:47 PM
Jdforrester-WMF moved this task from Ready, Features to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 24 2024, 2:50 PM
gerritbot added a comment.Jul 25 2024, 12:18 PM

Change #1056924 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] FunctionEditorAliases: Replace wl-chip-container with the Codex ChipInput

https://gerrit.wikimedia.org/r/1056924

gerritbot added a project: Patch-For-Review.Jul 25 2024, 12:18 PM
gerritbot added a comment.Jul 29 2024, 5:38 PM

Change #1056924 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionEditorAliases: Replace wl-chip-container with the Codex ChipInput

https://gerrit.wikimedia.org/r/1056924

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 29 2024, 6:00 PM
gerritbot added a comment.Aug 20 2024, 3:30 PM

Change #1052114 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Implement new About widget design

https://gerrit.wikimedia.org/r/1052114

gerritbot added a comment.Aug 22 2024, 1:08 PM

Change #1052114 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Implement new About widget design

https://gerrit.wikimedia.org/r/1052114

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.20; 2024-08-27); removed MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Aug 22 2024, 2:00 PM
Jdforrester-WMF closed subtask T336347: ChipContainer and Chip components: Decouple these componets from the internal structure of zobject data as Resolved.Aug 23 2024, 1:37 PM
gerritbot added a comment.Aug 23 2024, 1:38 PM

Change #1065222 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Drop our local Chip and ChipContainer components, now unused

https://gerrit.wikimedia.org/r/1065222

gerritbot added a comment.Aug 23 2024, 8:07 PM

Change #1065222 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Drop our local Chip and ChipContainer components, now unused

https://gerrit.wikimedia.org/r/1065222

Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Aug 26 2024, 12:37 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Wed, Aug 28, 5:12 PM
Jdforrester-WMF closed this task as Resolved.Tue, Sep 3, 1:11 PM
Jdforrester-WMF edited subtasks, added: T369617: Implement new About Widget design; removed: T360610: [25Q1] Improve About widget experience for translators and multi-lingual contributors.
Jdforrester-WMF closed subtask T369617: Implement new About Widget design as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits