Page MenuHomePhabricator
Create Task
Maniphest T343998

[M] Item label, description and alias editing should have a license note
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

As an editor, I want to be informed about the license of contributions when I am editing a label, description or alias of an Item on the legacy termbox.

Problem:
We currently don't show a "license of contributions" message when an Item label, alias or description is edited like we do when a statement is added or edited.

We need to have the same message appear when an Item label, alias or description is edited on the legacy termbox.

Screenshot

image.png (294×330 px, 28 KB)

Copy
By clicking "Publish", you agree to the terms of use, and you irrevocably agree to release your contribution under the Creative Commons CC0 License.

I accept these terms for my future edits. Do not show this message again.

BDD
GIVEN an Item
AND a legacy termbox
AND an editor wants to make a change
WHEN the edit button is clicked for an Item label, alias or description
THEN the "license of contributions" message is displayed

Acceptance criteria:

  • "license of contributions" message is displayed when an Item label, alias or description is edited on the legacy termbox

Details

SubjectRepoBranchLines +/-
Add copyright note when editing terms (legacy termbox)mediawiki/extensions/Wikibasemaster+19 -10
jquery.wikibase.wbtooltip: Fix offsetsmediawiki/extensions/Wikibasemaster+38 -30
Fix copyright notice closingmediawiki/extensions/Wikibasemaster+29 -16
WIP: Alternative approach to termbox copyright notice heightmediawiki/extensions/Wikibasemaster+2 -2
WIP: Fix termbox copyright note on my machinemediawiki/extensions/Wikibasemaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Arian_Bozorg created this task.Aug 10 2023, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2023, 3:38 PM
Arian_Bozorg renamed this task from Item label, description and alias editing should have a license note to [SW] Item label, description and alias editing should have a license note.Aug 11 2023, 9:15 AM
Michael subscribed.Aug 14 2023, 11:31 AM
karapayneWMDE renamed this task from [SW] Item label, description and alias editing should have a license note to [SW][BUG]Item label, description and alias editing should have a license note.Aug 15 2023, 2:06 PM
karapayneWMDE renamed this task from [SW][BUG]Item label, description and alias editing should have a license note to [SW][STORY] Item label, description and alias editing should have a license note.
karapayneWMDE moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.
Arian_Bozorg renamed this task from [SW][STORY] Item label, description and alias editing should have a license note to Item label, description and alias editing should have a license note.Aug 16 2023, 9:17 AM
Arian_Bozorg updated the task description. (Show Details)
karapayneWMDE moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Aug 16 2023, 9:38 AM
WMDE-leszek set the point value for this task to 5.Aug 22 2023, 9:39 AM
WMDE-leszek moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
WMDE-leszek edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
ItamarWMDE subscribed.Aug 23 2023, 10:18 AM

Task Breakdown Notes:

ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 23 2023, 10:18 AM
hoo claimed this task.Sep 19 2023, 8:44 PM
hoo moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Oct 4 2023, 9:27 AM

Change 963275 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Add copyright note when editing terms (legacy termbox)

https://gerrit.wikimedia.org/r/963275

gerritbot added a project: Patch-For-Review.Oct 4 2023, 9:27 AM
hoo edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team (Sprint-∞).Oct 4 2023, 9:31 AM
hoo moved this task from In Task Breakdown to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Oct 5 2023, 11:57 AM

Change 963712 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] jquery.wikibase.wbtooltip: Fix left offset for s* orientation

https://gerrit.wikimedia.org/r/963712

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Oct 5 2023, 12:51 PM
Lucas_Werkmeister_WMDE mentioned this in T343999: Lexeme lemma, sense or form editing should have a licence note.Oct 5 2023, 2:29 PM
gerritbot added a comment.Oct 6 2023, 9:53 AM

Change 963986 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Fix termbox copyright note on my machine

https://gerrit.wikimedia.org/r/963986

gerritbot added a comment.Oct 6 2023, 11:41 AM

Change 963997 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Alternative approach to termbox copyright notice height

https://gerrit.wikimedia.org/r/963997

Michael renamed this task from Item label, description and alias editing should have a license note to [M] Item label, description and alias editing should have a license note.Oct 6 2023, 4:54 PM
Michael changed the point value for this task from 5 to 1.

I've changed the estimated storypoints to 1 (it was 5), so that it works as intended with the point-based wip-limits on our board Wikidata Dev Team (Wikidata.org Slice)

Lucas_Werkmeister_WMDE subscribed.Oct 11 2023, 11:22 AM

In the task description, the popup/tooltip is shown above the “save”/“cancel” toolbar, pointing to the right. Is it also okay if it’s below the toolbar end pointing to the left? Otherwise, on my system it doesn’t fit on the page:

image.png (348×459 px, 33 KB)

It could instead look like this, partially overlapping the legacy termbox:

image.png (274×567 px, 46 KB)

(I included the “help” tooltip to demonstrate why I suggest pointing it to the left instead of to the right.)

karapayneWMDE moved this task from In Peer Review to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.Oct 13 2023, 8:21 AM
gerritbot added a comment.Oct 15 2023, 6:31 PM

Change 965917 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Fix copyright notice closing

https://gerrit.wikimedia.org/r/965917

hoo moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Oct 17 2023, 9:40 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Oct 17 2023, 10:06 AM
Lucas_Werkmeister_WMDE added a comment.Oct 17 2023, 10:38 AM
In T343998#9242275, @Lucas_Werkmeister_WMDE wrote:

In the task description, the popup/tooltip is shown above the “save”/“cancel” toolbar, pointing to the right. Is it also okay if it’s below the toolbar end pointing to the left?

(The patch attached to this task has now been updated this way, and I’ll merge that unless I hear an objection here soon.)

gerritbot added a comment.Oct 17 2023, 10:44 AM

Change 965917 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix copyright notice closing

https://gerrit.wikimedia.org/r/965917

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 17 2023, 11:00 AM
gerritbot added a comment.Oct 20 2023, 11:28 AM

Change 963712 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] jquery.wikibase.wbtooltip: Fix offsets

https://gerrit.wikimedia.org/r/963712

gerritbot added a comment.Oct 20 2023, 11:28 AM

Change 963275 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add copyright note when editing terms (legacy termbox)

https://gerrit.wikimedia.org/r/963275

Lucas_Werkmeister_WMDE moved this task from In Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Oct 20 2023, 11:42 AM
Arian_Bozorg closed this task as Resolved.Nov 2 2023, 1:00 PM
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

Looks good to me :)

Thanks so much

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits