Popups should not use mediawiki.ui.checkbox, use Codex instead
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 3 2023, 9:23 PM

Description

Popups is using a deprecated module. Please update it per instructions.

In browser console:

This page is using the deprecated ResourceLoader module "mediawiki.ui.checkbox". Please use Codex. See migration guidelines: https://w.wiki/7TAh

We should heed its warning and get this fixed pronto.

QA

Make sure you are viewing a page as an anonymous user.
The checkbox appears in the settings menu that is opened by clicking the settings cog in a page preview.

QA Results - Beta

AC	Status	Details
1	✅	~~T348069#9288080~~ T348069#9297104

QA Results - Prod

AC	Status	Details
1	✅	T348069#9325231

Details

	Subject	Repo	Branch	Lines +/-
	Removing mw.ui.checkbox dependency (take 2)	mediawiki/extensions/Popups	master	+17 -11
	Removing mw.ui.checkbox dependency	mediawiki/extensions/Popups	master	+10 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		Jdlrobson	T182050 Remove all mediawiki.ui components and libraries in favor of Codex
		Resolved		KSarabia-WMF	T348069 Popups should not use mediawiki.ui.checkbox, use Codex instead

Event Timeline

Jdlrobson created this task.Oct 3 2023, 9:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2023, 9:23 PM

Jdlrobson triaged this task as High priority.Oct 3 2023, 9:23 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a parent task: T182050: Remove all mediawiki.ui components and libraries in favor of Codex.

Jdlrobson mentioned this in T182050: Remove all mediawiki.ui components and libraries in favor of Codex.Oct 3 2023, 9:28 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 11 2023, 3:42 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.Oct 19 2023, 5:51 PM

Jdlrobson set the point value for this task to 2.Oct 23 2023, 5:31 PM

Jdrewniak claimed this task.Oct 25 2023, 6:13 PM

Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.

Change 968742 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] Removing mw.ui.checkbox dependency

https://gerrit.wikimedia.org/r/968742

gerritbot added a project: Patch-For-Review.Oct 25 2023, 6:58 PM

Jdrewniak removed Jdrewniak as the assignee of this task.Oct 25 2023, 7:12 PM

Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.

Jdrewniak subscribed.

• Mabualruz claimed this task.Oct 26 2023, 4:37 PM

Change 968742 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Removing mw.ui.checkbox dependency

https://gerrit.wikimedia.org/r/968742

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 26 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2023, 5:10 PM

• Mabualruz reassigned this task from • Mabualruz to Edtadros.Oct 26 2023, 5:46 PM

• Mabualruz moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.

• Mabualruz subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Make sure you are viewing a page as an anonymous user.
✅ AC1: The checkbox appears in the settings menu that is opened by clicking the settings cog in a page preview.

Edtadros updated the task description. (Show Details)Oct 27 2023, 5:08 PM

Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.Oct 27 2023, 10:01 PM

I had to revert this change - it's leading to a repaint on page load for anonymous users.

From commit:
Unexpected visual change flagged by Pixel. We're now loading BOTH codex search and Codex styles on page load (the latter via JavaScript). This results in a visual regression in the sidebar as the message box for
languages switches from MediaWiki UI to Codex. I am not 100% sure what the right approach is here, but we should pause to assess given this new learning.

Possible options

Add checkbox styles to codex-search bundle
Load codex-styles on page load instead of codex-search
Delay the loading of the codex-styles until the overlay is rendering
Wait until Codex has code splitting.

Personally I would lean into 3 (we can call mw.loader.using before rendering the settings overlay) and create a ticket for the DST team to discuss on the longer term solution.

Change 969350 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Removing mw.ui.checkbox dependency (take 2)

https://gerrit.wikimedia.org/r/969350

gerritbot added a project: Patch-For-Review.Oct 27 2023, 11:46 PM

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.Oct 30 2023, 4:24 PM

Jdlrobson assigned this task to Jdrewniak.Oct 30 2023, 5:33 PM

Jdlrobson mentioned this in T350069: message boxes visually change when full Codex styles module is loaded.Oct 30 2023, 5:54 PM

Change 969350 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Removing mw.ui.checkbox dependency (take 2)

https://gerrit.wikimedia.org/r/969350

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2023, 9:11 PM

Jdlrobson reassigned this task from Jdrewniak to Edtadros.Oct 30 2023, 9:24 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Make sure you are viewing a page as an anonymous user.
✅ AC1: The checkbox appears in the settings menu that is opened by clicking the settings cog in a page preview.

Edtadros updated the task description. (Show Details)Nov 1 2023, 4:04 AM

Jdlrobson assigned this task to KSarabia-WMF.Nov 2 2023, 4:40 PM

LGTM

Personally I would lean into 3 (we can call mw.loader.using before rendering the settings overlay) and create a ticket for the DST team to discuss on the longer term solution.

Done in T350069.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Make sure you are viewing a page as an anonymous user.
✅ AC1: The checkbox appears in the settings menu that is opened by clicking the settings cog in a page preview.

Edtadros updated the task description. (Show Details)Nov 13 2023, 12:14 AM

Edtadros mentioned this in T349323: Verify 1.42.0-wmf.3 deployment.Nov 13 2023, 12:27 AM

	F41499986: screenshot 213.png
	Nov 13 2023, 12:13 AM

	F41424944: screenshot 193.png
	Nov 1 2023, 4:03 AM

	F40665250: image.png
	Oct 27 2023, 10:03 PM

	F40611775: screenshot 170.png
	Oct 27 2023, 5:05 PM

Popups should not use mediawiki.ui.checkbox, use Codex insteadClosed, ResolvedPublic2 Estimated Story PointsActions

Description

QA

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Popups should not use mediawiki.ui.checkbox, use Codex instead
Closed, ResolvedPublic2 Estimated Story Points
Actions

Related Objects
Search...