Page MenuHomePhabricator
Create Task
Maniphest T349080

User rights: Logged in users can edit user-contributed functions that are not-running
Closed, ResolvedPublic
Actions

Description

Description

NOTE: this task doesn't include the function multilingual information (name, description, aliases and argument labels), this is covered by the task T349063
Goal

Any logged in user should be able to edit functions when:

  • the function is a user contributed functions, and
  • if editing input/output, the function is not running
Details
  1. When the function is predefined function:
    • Only function maintainers can edit them. Rights needed: [ wikilambda-edit-predefined ]
  1. When the function is user-contributed function:
    • Edit inputs/Z8K1 or output/Z8K2:
      • If the function is running: Only function maintainers can edit them. [ wikilambda-edit-user-function, wikilambda-edit-running-function & wikilambda-edit-running-function-definition ]
      • Else: logged in user [ wikilambda-edit-user-function ]
    • Edit tests/Z8K3 or implementations/Z8K4 (connect/disconnect):
      • If the function is running:
        • connect implementations: functioneers [ wikilambda-edit-user-function, wikilambda-edit-running-function, wikilambda-connect-implementation ]
        • disconnect implementations: functioneers [ wikilambda-edit-user-function, wikilambda-edit-running-function, wikilambda-disconnect-implementation ]
        • connect tests: functioneers [ wikilambda-edit-user-function, wikilambda-edit-running-function, wikilambda-connect-test ]
        • disconnect tests: functioneers [ wikilambda-edit-user-function, wikilambda-edit-running-function, wikilambda-disconnect-test ]
      • If the function is not running:
        • connect implementations: functioneers [ wikilambda-edit-user-function, wikilambda-connect-implementation ]
        • connect tests: functioneers [ wikilambda-edit-user-function, wikilambda-connect-test ]
        • disconnect tests: functioneers [ wikilambda-edit-user-function, wikilambda-disconnect-test ]
    • Any other edits:
      • Any logged in user [ wikilambda-edit-user-function ]
Permissions involved:
  • function maintainer: [ wikilambda-edit-predefined, wikilambda-edit-running-function-definition ]
  • functioneer: [ wikilambda-edit-running-function, wikilambda-connect-*, wikilambda-disconnect-* ]
  • logged in user: [ wikilambda-edit-user-function ]
To-Do:
  • Create wikilambda-edit-running-function-definition right and assing it to functionmaintainer group
  • Remove wikilambda-edit-builtin-function right (redundant, covered by wikilambda-edit-predefined)
  • Remove wikilambda-edit-function right (redundant, covered by wikilambda-edit-predefined or wikilambda-edit-user-function)
  • Remove wikilambda-edit-function-definition right (redundant, covered by wikilambda-edit-running-function-definition, which needs a special right, because it requires more privileges than edit-running-function + edit-function-definition )
  • Set wikilambda-edit-predefined to true for the group functionmaintainer
  • Set wikilambda-edit-running-function-definition to true for the group functionmaintainer
  • Set wikilambda-edit-running-function to true for the group functioneer
  • Set wikilambda-connect-* to true for the group functioneer
  • Set wikilambda-disconnect-* to true for the group functioneer
  • Set wikilambda-edit-function-definition to true for the group user
  • Set wikilambda-edit-user-function to true for the group user

Completion checklist

Details

SubjectRepoBranchLines +/-
[wikifunctions] Alter site to General Availabilityoperations/mediawiki-configmaster+13 -32
Restore wikilambda-edit-builtin-function rightmediawiki/extensions/WikiLambdamaster+16 -2
Fix edit function rights and privileges for different conditionsmediawiki/extensions/WikiLambdamaster+197 -199
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Oct 17 2023, 10:05 AM
gengh mentioned this in T349054: Adjust and improve Wikifunctions user rights grants for General Availability.
gengh updated the task description. (Show Details)Oct 17 2023, 10:11 AM
Jdforrester-WMF added a parent task: T349054: Adjust and improve Wikifunctions user rights grants for General Availability.Oct 17 2023, 2:05 PM
gerritbot added a comment.Oct 17 2023, 4:14 PM

Change 966570 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] [wikifunctions] Alter site to General Availability

https://gerrit.wikimedia.org/r/966570

gerritbot added a project: Patch-For-Review.Oct 17 2023, 4:14 PM
gengh renamed this task from User rights: Logged in users can edit user-contributed functions that are not running to User rights: Logged in users can edit user-contributed functions that are not-running.Oct 19 2023, 11:28 AM
gengh updated the task description. (Show Details)
gengh claimed this task.Oct 19 2023, 1:31 PM
gengh updated the task description. (Show Details)
gengh mentioned this in T349081: User rights: Edit implementations or tests that are connected to functions.Oct 19 2023, 2:30 PM
gerritbot added a comment.Oct 19 2023, 2:40 PM

Change 967226 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix edit function rights and privileges for different conditions

https://gerrit.wikimedia.org/r/967226

Jdforrester-WMF changed the task status from Open to In Progress.Oct 19 2023, 4:38 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Oct 20 2023, 1:31 PM

Change 967226 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix edit function rights and privileges for different conditions

https://gerrit.wikimedia.org/r/967226

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Oct 20 2023, 1:33 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 20 2023, 2:00 PM
gerritbot added a comment.Oct 20 2023, 2:20 PM

Change 967463 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Restore wikilambda-edit-builtin-function right

https://gerrit.wikimedia.org/r/967463

gerritbot added a comment.Oct 24 2023, 6:16 PM

Change 967463 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Restore wikilambda-edit-builtin-function right

https://gerrit.wikimedia.org/r/967463

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.3; 2023-10-31); removed MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 24 2023, 7:00 PM
Jdforrester-WMF removed a project: Patch-For-Review.Oct 25 2023, 1:45 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Nov 6 2023, 8:34 PM
gerritbot added a comment.Nov 7 2023, 2:02 PM

Change 966570 merged by jenkins-bot:

[operations/mediawiki-config@master] [wikifunctions] Alter site to General Availability

https://gerrit.wikimedia.org/r/966570

Stashbot mentioned this in T349082: User rights: Logged in users can edit user-contributed objects of non-restricted types.Nov 7 2023, 2:03 PM
Stashbot mentioned this in T349063: User rights: Logged in users can edit function input labels and key labels.
Stashbot mentioned this in T349061: User rights: Logged in users can create functions, implementations, tests and others.

Mentioned in SAL (#wikimedia-operations) [2023-11-07T14:03:16Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:966570|[wikifunctions] Alter site to General Availability (T349054 T349061 T349063 T349080 T349082)]]

Stashbot added a comment.Nov 7 2023, 2:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-07T14:04:43Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:966570|[wikifunctions] Alter site to General Availability (T349054 T349061 T349063 T349080 T349082)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Nov 7 2023, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-07T14:10:17Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:966570|[wikifunctions] Alter site to General Availability (T349054 T349061 T349063 T349080 T349082)]] (duration: 07m 00s)

Jdforrester-WMF closed this task as Resolved.Nov 29 2023, 5:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits