Page MenuHomePhabricator

Deploy new donation entry point
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
ovasileva
Aug 29 2024, 10:21 AM
Referenced Files
F57553901: 2024-09-25_16-53-01.mp4.gif
Sep 25 2024, 11:59 PM
F57553899: 2024-09-25_16-53-44.mp4.gif
Sep 25 2024, 11:59 PM
F57553893: 2024-09-25_16-50-42.mp4.gif
Sep 25 2024, 11:59 PM
F57553891: 2024-09-25_16-50-00.mp4.gif
Sep 25 2024, 11:59 PM
Tokens
"Like" token, awarded by aliu."Y So Serious" token, awarded by stjn."Like" token, awarded by Jdlrobson.

Description

NOTE: Deployment date September 9

Background

User story

  • As a donor, I want the ability to find the link to donate quickly, so that it's easier for me to donate

Requirements

Acceptance criteria

  • Turn the feature flag for the donation entry point on across wikis
  • Deploy in 2 phases. First phase should deploy to several wikis (check with steering committee which)
  • Inform @Pcoombe and @spatton of date and time of deployment

Communication criteria - does this need an announcement or discussion?

  • Communicate in message after deployment

Rollback plan

  • Steering committee decided whether rollback is necessary

This task was created by Version 1.2.0 of the Web team task template using phabulous

Derived Requirement

Ensure that the donation entry point on Vector 2022 is updated and deployed across wikis in two phases, per the completion of T372757. The feature flag for the new donation entry point must be turned on across selected wikis during the first phase of deployment. Communication with stakeholders must occur after deployment, with a rollback plan in place as decided by the steering committee.

BDD

Feature: Deployment of updated donation entry point on Vector 2022

Scenario: Ensure the donation entry point is correctly deployed across wikis

Given the donation entry point has been moved in Vector 2022 as per T372757
When the feature flag is turned on across selected wikis
Then the new donation link should appear in the correct location
And it should be easier for donors to find the link
Test Steps

Test Case 1: Ensure donation entry point is correctly deployed on selected wikis in phase 1

  1. Go to a selected wiki where the new donation entry point has been deployed.
  2. Check the location of the donation link.
  3. ✅❓❌⬜ AC1: Confirm that the donation link appears in the correct location as per the design in T372757.
  4. ✅❓❌⬜ AC2: Confirm that the donation link is easily visible and accessible for users.

QA Results - Beta

ACStatusDetails
1T373585#10178068
2T373585#10178068

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ovasileva set the point value for this task to 2.

pref is monday to one or two wikis and wednesday for others? Need to double check with @sgrabarczuk to figure out which wikis.

Change #1071281 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[operations/mediawiki-config@master] Release donate link to pilot wikis (French Wikipedia and Wikifunctions)

https://gerrit.wikimedia.org/r/1071281

feel free to assign back to me when you're done reviewing!

Change #1071281 merged by jenkins-bot:

[operations/mediawiki-config@master] Release donate link to pilot wikis (French Wikipedia and Wikifunctions)

https://gerrit.wikimedia.org/r/1071281

Mentioned in SAL (#wikimedia-operations) [2024-09-09T20:49:10Z] <kindrobot@deploy1003> Started scap sync-world: Backport for [[gerrit:1071281|Release donate link to pilot wikis (French Wikipedia and Wikifunctions) (T373585)]], [[gerrit:1071202|Fix typo in browser vendor prefix (T374180)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-09T20:51:06Z] <kindrobot@deploy1003> jforrester, toyofuku, kindrobot: Backport for [[gerrit:1071281|Release donate link to pilot wikis (French Wikipedia and Wikifunctions) (T373585)]], [[gerrit:1071202|Fix typo in browser vendor prefix (T374180)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson lowered the priority of this task from High to Medium.Sep 9 2024, 9:00 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-09T21:01:49Z] <kindrobot@deploy1003> Finished scap sync-world: Backport for [[gerrit:1071281|Release donate link to pilot wikis (French Wikipedia and Wikifunctions) (T373585)]], [[gerrit:1071202|Fix typo in browser vendor prefix (T374180)]] (duration: 12m 39s)

Change #1071961 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[operations/mediawiki-config@master] Turn off feature flag to move donate link everywhere

https://gerrit.wikimedia.org/r/1071961

Change #1071961 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn off feature flag to move donate link everywhere

https://gerrit.wikimedia.org/r/1071961

Mentioned in SAL (#wikimedia-operations) [2024-09-11T20:27:13Z] <cjming@deploy1003> Started scap sync-world: Backport for [[gerrit:1071961|Turn off feature flag to move donate link everywhere (T373585)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-11T20:30:43Z] <cjming@deploy1003> cjming, toyofuku: Backport for [[gerrit:1071961|Turn off feature flag to move donate link everywhere (T373585)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-11T20:36:56Z] <cjming@deploy1003> Finished scap sync-world: Backport for [[gerrit:1071961|Turn off feature flag to move donate link everywhere (T373585)]] (duration: 09m 42s)

Due to unexpected bugs in the deployment, this is now being carried over to next sprint.

For Olga: this is now blocked on T373566, but we should be in good shape to do the pilot wikis on Monday (meaning this only got pushed back a week), with a subsequent rollout on Wednesday if things look good

For Olga: this is now blocked on T373566, but we should be in good shape to do the pilot wikis on Monday (meaning this only got pushed back a week), with a subsequent rollout on Wednesday if things look good

That sounds good, thanks for the note!

We discussed in sprint meeting and the new plan is to deploy back to pilots on Thursday, after the train has rolled out, and then all wikis on Monday the 23rd

Change #1073297 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[operations/mediawiki-config@master] Deploy new donate link location to pilot wikis (take 2)

https://gerrit.wikimedia.org/r/1073297

We discussed in sprint meeting and the new plan is to deploy back to pilots on Thursday, after the train has rolled out, and then all wikis on Monday the 23rd

Thanks for the update @SToyofuku-WMF !

SToyofuku-WMF raised the priority of this task from Medium to High.Sep 19 2024, 4:49 PM

Change #1073297 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy new donate link location to pilot wikis (take 2)

https://gerrit.wikimedia.org/r/1073297

Mentioned in SAL (#wikimedia-operations) [2024-09-19T20:04:11Z] <toyofuku@deploy1003> Started scap sync-world: Backport for [[gerrit:1073297|Deploy new donate link location to pilot wikis (take 2) (T373585)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-19T20:06:02Z] <toyofuku@deploy1003> toyofuku: Backport for [[gerrit:1073297|Deploy new donate link location to pilot wikis (take 2) (T373585)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-19T20:12:47Z] <toyofuku@deploy1003> Finished scap sync-world: Backport for [[gerrit:1073297|Deploy new donate link location to pilot wikis (take 2) (T373585)]] (duration: 08m 35s)

Change #1074550 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[operations/mediawiki-config@master] Deploy donate link to all wikis

https://gerrit.wikimedia.org/r/1074550

Pppery subscribed.

Not exactly a tech issue but I still feel like this deserves a tech news announcement.

Change #1074550 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy donate link to all wikis

https://gerrit.wikimedia.org/r/1074550

Mentioned in SAL (#wikimedia-operations) [2024-09-24T20:21:17Z] <samtar@deploy1003> Started scap sync-world: Backport for [[gerrit:1074550|Deploy donate link to all wikis (T373585)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-24T20:23:19Z] <samtar@deploy1003> samtar, toyofuku: Backport for [[gerrit:1074550|Deploy donate link to all wikis (T373585)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-24T20:32:29Z] <samtar@deploy1003> Finished scap sync-world: Backport for [[gerrit:1074550|Deploy donate link to all wikis (T373585)]] (duration: 11m 11s)

GMikesell-WMF updated Other Assignee, added: Edtadros.
GMikesell-WMF updated the task description. (Show Details)

@Jdlrobson and @ovasileva deployed links are as designed but before I move this to sign off, I did have a question on the first AC of Turn the feature flag for the donation entry point on across wikis. What other wikis do you want me to check? I did English and Spanish.

Also, side note: in the user story of making it easier for them to donate, why is the donate button only when you are logged out at the top right but then move to the main menu sidebar if you are logged in? If a user has the main menu hidden, the donate button is now hidden too, unless they remember that it's in the main menu. It's also an extra click for the logged-in user to get to donate. I'm just curious about why they are in different spots for logged-in vs logged-out.

Test Result - Beta

Status: ❓NMI ✅ PASS
Environment: Beta
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure donation entry point is correctly deployed on selected wikis in phase 1

  1. Go to a selected wiki where the new donation entry point has been deployed.
  2. Check the location of the donation link.
  3. ✅ AC1: Confirm that the donation link appears in the correct location as per the design in T372757.
Logged inLogged out
2024-09-25_16-50-00.mp4.gif (538×940 px, 736 KB)
2024-09-25_16-50-42.mp4.gif (564×930 px, 819 KB)

Es Wiki

Logged inLogged out
2024-09-25_16-53-44.mp4.gif (532×1 px, 636 KB)
2024-09-25_16-53-01.mp4.gif (582×1 px, 509 KB)
  1. ✅ AC2: Confirm that the donation link is easily visible and accessible for users.

See AC1

Jdlrobson added a subscriber: GMikesell-WMF.

What other wikis do you want me to check? I did English and Spanish.

That's enough. I also checked https://meta.wikimedia.org/wiki/Main_Page . I don't think we need to check every single wiki for this - there would be too many and I don't think we'd learn anything.

@ovasileva the only thing we probably need to be on the look out for is gadgets that interfere with the donate link, but I assume we would hear from community members if that was a problem and I'm not exactly sure how we would even test for that without checking every single domain we maintain?

All done. Will document deployment on KR page in mediawiki

Can i just say that i find this kinda ridiculous ?
The link has no business to be in what is the spot for ‘user related’ tools.

This is just another example of the foundation's obsession with raking in money.