Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix flakiness in subscriberIT integration test #476

Merged
merged 45 commits into from
Jan 12, 2021
Merged

fix: fix flakiness in subscriberIT integration test #476

merged 45 commits into from
Jan 12, 2021

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jan 6, 2021 •
edited
Loading

The subscriber sync pull integration test is still flaky because the PullRequest does not always return the max amount of messages requested. Adding retries to the synchronous pull operations to ensure all messages are received.

Fixes #435 ☕️

@hannahrogers-google
Modifying Publish example in README to match other examples given, and
19dd129 
fix issue #6784
@hannahrogers-google
fix: Modifying Publish example in README to match other examples, and
4158529 
fix Issue googleapis#11
@hannahrogers-google
Merge branch 'master' of github.com:hannahrogers-google/java-pubsub
7d704f0
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
9e0ebc6
@hannahrogers-google
feat: Adding support for DLQs
01d41b7 
Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google
Fix formatting
ed3b1ee
@hannahrogers-google
fix: making changes requested in pull request
72f7996
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
389cb86
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c9e4bd2
@hannahrogers-google
fix: creating fix to not populate delivery attempt attribute when dead
3738ec8 
lettering is not enabled
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
4ce1d3b
@hannahrogers-google
Adding unit test for case in which a received message has no delivery…
aecd4ca 
… attempt
@hannahrogers-google
Making MessageWaiter class more generic to also be used for outstanding
77fa3b3 
ack operations
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
b87023c
@hannahrogers-google
Merge branch 'master' into fix-subscriber-stop
7086b3c
@hannahrogers-google
Waiting for acks to complete before shutting down a streaming subscriber
da0e355 
connection
@hannahrogers-google
Fixing formatting error
dc55fc1
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
45beee2
@hannahrogers-google
fix: making sure all publishes complete before shutting down the
548b7a7 
publisher
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
76a1de9
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
a8989f1
@hannahrogers-google
adding default max outstanding request bytes
b4439fd
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
01f607c
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c0cddb3
@hannahrogers-google
fix: make push endpoint valid https
9a6381d
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
0bd165f
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
5d47be8
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub in…
e3b7f6d 
…to master
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub in…
6c1a26c 
…to master
@hannahrogers-google
fix: use default zero value if a flow control setting is not provided
f2fa6b8
@hannahrogers-google
fix lint issues
0cd08dc
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub in…
9ba9764 
…to master
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
f52eb61
@hannahrogers-google
fix: better cleanup during publisher test
78d98e8
@hannahrogers-google
fix: format issues
785c3ee
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
dbe753f
@hannahrogers-google
fix: test timeouts should be a minute
35c2c6e
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
8fd6691
@hannahrogers-google
fix: make subscriberIt less flaky
b76e387
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c855f24
@hannahrogers-google
fix: add deprecated tag for deprecated methods
d274df4
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
5663e12
@hannahrogers-google
fix: retrying sync pulls in subscriberIT test
fef9956
@hannahrogers-google
fix: reverting other branch
5bbaa7e
@hannahrogers-google
fix: revert synth.py
d185e92
@hannahrogers-google hannahrogers-google requested a review from a team January 6, 2021 22:19
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Jan 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2021
@hannahrogers-google hannahrogers-google changed the title fix: fix flakinessijmn fix: fix flakiness in subscriberIT integration test Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021 •
edited
Loading

Codecov Report

Merging #476 (d185e92) into master (3006332) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #476   +/-   ##
=========================================
  Coverage     79.17%   79.17%           
  Complexity      323      323           
=========================================
  Files            21       21           
  Lines          2925     2925           
  Branches        166      166           
=========================================
  Hits           2316     2316           
  Misses          541      541           
  Partials         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3006332...d185e92. Read the comment docs.

anguillanneuf
anguillanneuf approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better than what I had. Thank you!

@hannahrogers-google hannahrogers-google merged commit d981b4e into googleapis:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub.SubscriberIT: testSubscriber failed
2 participants
@hannahrogers-google @anguillanneuf