fix: removing delivery attempt attribute when dead lettering is not enabled #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
============================================
+ Coverage 78.82% 78.94% +0.11%
- Complexity 291 292 +1
============================================
Files 21 21
Lines 2588 2588
Branches 129 129
============================================
+ Hits 2040 2043 +3
+ Misses 491 490 -1
+ Partials 57 55 -2
Continue to review full report at Codecov.
|
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
Show resolved
Hide resolved
maheshgattani
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
When DLQ is not enabled, the delivery attempt attribute should not be populated on a PubsubMessage. The static helper function to get the delivery attempt should return null if the attribute is not set.