r23979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23978‎ | r23979 | r23980 >
Date:21:47, 10 July 2007
Author:simetrical
Status:old
Tags:
Comment:
(bug 9151) Remove timed redirects on "Return to X" pages for accessibility.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -1072,10 +1072,10 @@
10731073
10741074 /**
10751075 * return from error messages or notes
1076 - * @param $auto automatically redirect the user after 10 seconds
 1076+ * @param $unused No longer used
10771077 * @param $returnto page title to return to. Default is Main Page.
10781078 */
1079 - public function returnToMain( $auto = true, $returnto = NULL ) {
 1079+ public function returnToMain( $unused = null, $returnto = NULL ) {
10801080 global $wgUser, $wgOut, $wgRequest;
10811081
10821082 if ( $returnto == NULL ) {
@@ -1099,9 +1099,6 @@
11001100 $link = $sk->makeLinkObj( $titleObj, '' );
11011101
11021102 $r = wfMsg( 'returnto', $link );
1103 - if ( $auto ) {
1104 - $wgOut->addMeta( 'http:Refresh', '10;url=' . $titleObj->escapeFullURL() );
1105 - }
11061103 $wgOut->addHTML( "\n<p>$r</p>\n" );
11071104 }
11081105
Index: trunk/phase3/RELEASE-NOTES
@@ -130,6 +130,7 @@
131131 prevents page editing
132132 * (bug 9936) Per-edit suppression of preview-on-first edit with "preview=no"
133133 * Allow showing a one-off preview on first edit with "preview=yes"
 134+* (bug 9151) Remove timed redirects on "Return to X" pages for accessibility.
134135
135136 == Bugfixes since 1.10 ==
136137

Follow-up revisions

RevisionCommit summaryAuthorDate
r24046* (bug 9151) Fix relative subpage links with section fragmentsbrion21:02, 12 July 2007
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log