r85546 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85545‎ | r85546 | r85547 >
Date:16:31, 6 April 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Remove color:black from table {} in skins (bug 28422) + small fixes
* Remove color:black from table {} in skins (bug 28422)
* Add color:black to .wikitable (since it has a background-color)
* Update comment about CSS3 'word-wrap:break-word' support in Gecko
* Remove line-break in mediawiki.js (it's ~ 90 chars, acceptable)
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)
  • /trunk/phase3/skins/common/diff.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -62,7 +62,6 @@
6363
6464 table {
6565 font-size: 100%;
66 - color: black;
6766 }
6867 a {
6968 text-decoration: none;
Index: trunk/phase3/skins/common/shared.css
@@ -299,6 +299,7 @@
300300 background: #f9f9f9;
301301 border: 1px #aaa solid;
302302 border-collapse: collapse;
 303+ color: black;
303304 }
304305 .wikitable th, .wikitable td {
305306 border: 1px #aaa solid;
Index: trunk/phase3/skins/common/diff.css
@@ -54,8 +54,10 @@
5555 }
5656 table.diff td div {
5757 /* Force-wrap very long lines such as URLs or page-widening char strings.
58 - CSS 3 draft..., but Gecko doesn't support it yet:
59 - https://bugzilla.mozilla.org/show_bug.cgi?id=99457 */
 58+ CSS 3 only (In Gecko 1.9.1 / Firefox 3.5):
 59+ https://bugzilla.mozilla.org/show_bug.cgi?id=99457
 60+ https://developer.mozilla.org/web-tech/2008/08/20/word-wrap-break-word/
 61+ https://developer.mozilla.org/En/CSS/Word-wrap */
6062 word-wrap: break-word;
6163
6264 /* As fallback, scrollbars will be added for very wide cells
Index: trunk/phase3/skins/vector/screen.css
@@ -825,7 +825,6 @@
826826 /* Tables */
827827 table {
828828 font-size: 100%;
829 - color: black;
830829 }
831830 /* Forms */
832831 fieldset {
Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -1026,9 +1026,7 @@
10271027 // Allow calling with an external script or single dependency as a string
10281028 if ( typeof modules === 'string' ) {
10291029 // Support adding arbitrary external scripts
1030 - if ( modules.substr( 0, 7 ) == 'http://'
1031 - || modules.substr( 0, 8 ) == 'https://' )
1032 - {
 1030+ if ( modules.substr( 0, 7 ) == 'http://' || modules.substr( 0, 8 ) == 'https://' ) {
10331031 if ( type === 'text/css' ) {
10341032 $( 'head' )
10351033 .append( $( '<link rel="stylesheet" type="text/css" />' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r85547notes for r85546krinkle16:34, 6 April 2011
r871701.17: MFT r85546, r86450, r86625, r86805, r86841, r86904, r86973, r87030catrope16:57, 30 April 2011
r873531.17wmf1: MFT r85546, r86409, r86450, r86625, r86788, r86805, r86841, r86904,...catrope20:27, 3 May 2011

Comments

#Comment by Fomafix (talk | contribs)   07:32, 8 April 2011

Should it be included in 1.17, because r80495 from Bug 26708 also is in 1.17?

#Comment by Krinkle (talk | contribs)   08:44, 8 April 2011

You're right. I've tagged it for merge.

Status & tagging log