Template talk:Football box
This is the talk page for discussing improvements to the Football box template. |
|
Archives: 1 |
This template does not require a rating on Wikipedia's content assessment scale. It is of interest to the following WikiProjects: | ||||||||
|
|
|
Microformats
editWouldn't it be better, instead of forcing everyone to start using {{start date}}, we simply put the date parameter into the {{start-date}} template? That way we could let people keep putting dates in the {{footballbox}} template in plain text, and the microformats would be automatically generated. – PeeJay 23:09, 16 May 2011 (UTC)
Key
editI think the template could do with an option for a key. We football fans may instinctively know that the arrows and numbers mean substitutions and times, but unfamiliar readers may not. The trouble is, with a template that complicated, I have no idea how to add it. Any template experts on hand to help? Oldelpaso (talk) 19:14, 14 December 2011 (UTC)
Who started the shootout
editAnyone think there should be something that indicates who started the shootout? --MicroX (talk) 04:19, 13 February 2012 (UTC)
- I second this. This is pretty useful. Perhaps an arrow at either end of "Penalties"? –HTD 19:10, 1 June 2012 (UTC)
- Agree too, any progress on this? --Pelotastalk|contribs 10:49, 30 November 2012 (UTC)
- I've noticed some sites, UEFA among them IIRC, display the penalty takers on a stagger, i.e. the penalty takers do not all line up, and are instead about half a line out from each other. If we could replicate this somehow, we could easily indicate who took the first kick. – PeeJay 19:26, 22 August 2015 (UTC)
Broken links in the |report=
parameter?
edit
What if the link in the |report=
parameter goes bad? Usually, when a link goes bad you add a link to an archive copy, but leave the old link available. But, if you add a {{Cite web}}, {{Wayback}}, or {{WebCite}} template in to the |report=
parameter then the {{footballbox}} looks bad.
For example,
Italy | 1 – 1 (a.e.t.) | France |
---|---|---|
Materazzi 19' | "Report". Archived from the original on 2 Jan 2009. Retrieved 1 Jan 2009. {{cite web}} : Unknown parameter |deadurl= ignored (|url-status= suggested) (help) |
Zidane 7' (pen.) |
Penalties | ||
Pirlo Materazzi De Rossi Del Piero Grosso |
5 – 3 | Wiltord Trezeguet Abidal Sagnol |
Italy | 1 – 1 (a.e.t.) | France |
---|---|---|
Materazzi 19' | Report Archived 2 January 2009 at the Wayback Machine | Zidane 7' (pen.) |
Penalties | ||
Pirlo Materazzi De Rossi Del Piero Grosso |
5 – 3 | Wiltord Trezeguet Abidal Sagnol |
What do you recommend? Blevintron (talk) 22:20, 31 March 2012 (UTC)
- The above post was made in 2012, but many templates have this same problem. In fact some can't display archive links at all, the embedded template causes havoc on render. Not sure what the solution is. -- GreenC 01:07, 14 November 2016 (UTC)
- Why not just wrap the reference in <ref></ref> tags in that case?
| report = Report<ref>{{cite web | title=Actual title of the link | url=http://www.example.com/foo | accessdate=1 Jan 2009 | archiveurl=http://www.example.com/archive/foo | archivedate=2 Jan 2009 |deadurl=yes}}</ref>
==> Report[1] –Sygmoral (talk) 22:50, 16 November 2016 (UTC)
- Why not just wrap the reference in <ref></ref> tags in that case?
References
- ^ "Actual title of the link". Archived from the original on 2 Jan 2009. Retrieved 1 Jan 2009.
{{cite web}}
: Unknown parameter|deadurl=
ignored (|url-status=
suggested) (help)
Extra-time
editWhat about include the extra-time of the match?--Marceloml (talk) 18:14, 26 July 2012 (UTC)
- What do you mean? – PeeJay 19:02, 26 July 2012 (UTC)
- I mean to put the minutes gived by the referee in both times of the match. (Sorry for my english)--Marceloml (talk) 19:23, 26 July 2012 (UTC)
- Oh, you mean injury time (extra time is something different). It seems a bit pointless to me though. – PeeJay 19:26, 26 July 2012 (UTC)
- I mean to put the minutes gived by the referee in both times of the match. (Sorry for my english)--Marceloml (talk) 19:23, 26 July 2012 (UTC)
Penaltiy shootout
editHey, just a small thing and maybe not needed but what about changing the link to a penalty shootout to Penalty shoot-out (association football), so we avoid a redirect? Kante4 (talk) 22:56, 2 February 2013 (UTC)
Code rewrite
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Requesting the change to this version for better accessibility with the use of <div>
. Better accessibility also evident in mobile view (with its current default stylesheet). --SocietyBox (talk) 08:13, 27 July 2013 (UTC)
- Done. I also updated the test cases for you. — Mr. Stradivarius ♪ talk ♪ 04:45, 28 July 2013 (UTC)
"v" or "vs"
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
The correct abbreviation for "versus" is "vs" not simply "v". Therefore, could someone please change line 11 of this template from:
! style="width:22%; text-align:center" | {{#if:{{{score|}}}|{{{score}}}|v }} {{#if:{{{aet|}}}|([[Overtime (sports)#Association football|a.e.t.]]) }}
to:
! style="width:22%; text-align:center" | {{#if:{{{score|}}}|{{{score}}}|vs}} {{#if:{{{aet|}}}|([[Overtime (sports)#Association football|a.e.t.]]) }}
Thank you. – PeeJay 10:04, 26 May 2014 (UTC)
- Not done: please establish a consensus for this alteration before using the
{{edit template-protected}}
template. versus agrees with you that vs is a correct abbreviation, but it disagrees that it can't simply be v as well: "Versus, often abbreviated v., v, vs. or vs...". Therefor, you will need to get a consensus to change the cosmetics of this template per your request. — {{U|Technical 13}} (t • e • c) 12:06, 26 May 2014 (UTC)
Template-protected edit request on 19 August 2014 (teams displayed as headers)
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Request to change the following code:
! style="width:39%; text-align:right" class="vcard attendee" | {{{team1}}}
! style="width:22%; text-align:center" | v
! style="width:39%; text-align:left" class="vcard attendee" | {{{team2}}}
to
| style="width:39%; text-align:right" class="vcard attendee" | {{{team1}}}
! style="width:22%; text-align:center" | v
| style="width:39%; text-align:left" class="vcard attendee" | {{{team2}}}
In essence to replace the ! to | so that the team name is not defaulted to bold type Header but is controlled by the user who is using the template.
Refer to Template:footballbox collapsible for the way the teams are outputted since this is supposed to be identical in its behavior except that the output is collapsible.
A discussion with an example has begun at Wikipedia_talk:WikiProject_Football#Template_footballbox_.26_footballbox_collapsible.
Brudder Andrusha (talk) 00:58, 19 August 2014 (UTC)
- Not done for now: This will affect the appearance of all 12,000 transclusions, so there should be a clear consensus to make the change before we enact this request. Let's wait for the outcome of the discussion you linked to - it will need at least two or three days to give all interested parties a chance to take part, I would say. If the discussion results in a consensus to make the change, please reopen this request. Best — Mr. Stradivarius ♪ talk ♪ 01:16, 19 August 2014 (UTC)
Template-protected edit request on 10 December 2014
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
The Penalties wikilink should have a hyphen in the word shoot-out so it links directly to Penalty shoot-out (association football) MicroX (talk) 01:16, 10 December 2014 (UTC)
- Not done: Declining per WP:NOTBROKEN. The link Penalty shootout (association football) leads to the article Penalty shoot-out (association football) as much as the link Penalty shoot-out (association football) does; I don't think putting over 10,000 articles in the job queue for such a change is worth it. SiBr4 (talk) 09:36, 10 December 2014 (UTC)
- What is a job queue? You'd just be making one simple edit on one template. --MicroX (talk) 06:57, 12 December 2014 (UTC)
- See Help:Job queue. A change to a template needs to be reflected on all pages using the template, which does not happen immediately. SiBr4 (talk) 09:36, 12 December 2014 (UTC)
- What is a job queue? You'd just be making one simple edit on one template. --MicroX (talk) 06:57, 12 December 2014 (UTC)
Google using Microformat summary
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Google are now using the Microformats 'summary' attribute when displaying search results. It's not looking right in the Google results at the moment. See http://i.imgur.com/roHvZS6.png as an example.
I've made a few proposals in the template:Football box/sandbox file. I've added team names to a summary attribute and also added a location attribute to the the stadium/venue. I've already made the changes to the template:Football box collapsible template and the output now looks a lot better on Google for wikipedia pages using that template.
TheBigJagielka (talk) 21:50, 26 February 2015 (UTC)
- Note: Andy, I know no one who knows microformates better than you. Can you confirm this issue here and that the proposed code in the sandbox will resolve it? Thanks. —
{{U|Technical 13}} (e • t • c)
02:09, 14 March 2015 (UTC) - No other comments, so Done — Martin (MSGJ · talk) 09:41, 20 March 2015 (UTC)
- Now the template is broken when attendance is missing. Stadium and referee info are in the same row. Dr. Vicodine (talk) 20:41, 20 March 2015 (UTC)
- The changes has been reverted. User:TheBigJagielka, can you thoroughly test your changes and let me know when you are ready to re-deploy? — Martin (MSGJ · talk) 20:17, 21 March 2015 (UTC)
- Now the template is broken when attendance is missing. Stadium and referee info are in the same row. Dr. Vicodine (talk) 20:41, 20 March 2015 (UTC)
- @MSGJ:, I have made the necessary change and the testing can be seen below:
- Stadium, Referee and Attendance
- Stadium, Referee but no Attendance
- Stadium, but no Referee or Attendance
- No Stadium, but includes Referee and Attendance
- Stadium, Attendance but no Referee
TheBigJagielka (talk) 14:24, 22 March 2015 (UTC)
- Done — Martin (MSGJ · talk) 12:36, 29 March 2015 (UTC)
Easier report parameter
editI just changed the Football box collapsible template to accept plain URLs as 'report' parameter, so that people can just write report=url
instead of always having to write report=[url Report]
. The template now generates those links automatically, but only if a plain URL is detected, so all other use cases still work. Feel free to copy over that change into this template. Sygmoral (talk) 14:23, 22 August 2015 (UTC)
- Great idea. I'd been wondering about this for a while, but I didn't know if it was possible. – PeeJay 19:22, 22 August 2015 (UTC)
- Here is the code to parse the report parameter that way, if someone wants to put it into this template.
{{ #if: {{{report|}}} | {{#ifeq:{{str_sub|{{{report}}}|0|4}}|http |[{{{report}}} Report] |{{{report}}}}} | }}
Sygmoral (talk) 18:06, 29 August 2015 (UTC)
- Here is the code to parse the report parameter that way, if someone wants to put it into this template.
Template-protected edit request on 2 March 2016
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Quite a while ago already, I edited the {{Football box collapsible}} template to make the report
parameter easier to use. I did this because everyone always writes report=[url Report]
, so I automated that format so you can just write report=url
instead. It detects when the report
parameter starts with http, and if so, wraps it into such a link.
The following edit is required: {{{report}}}
needs to be replaced with {{#ifeq:{{str_sub|{{{report}}}|0|4}}|http |[{{{report}}} Report] |{{{report}}}}}
.
Thanks! –Sygmoral (talk) 20:05, 2 March 2016 (UTC)
- Done — Martin (MSGJ · talk) 23:19, 2 March 2016 (UTC)
Accessibility update
editI can't say for certain, but MOS:ACCESSIBILITY (see Block elements) would probably suggest that we move away from breaks and toward the use of {{plainlist}} for the goals, cards, etc. in the two goals parameters. Comments? If no one objects, I'll update the documentation. Walter Görlitz (talk) 04:03, 16 May 2016 (UTC)
- Good idea, I agree. –Sygmoral (talk) 01:53, 18 May 2016 (UTC)
- In fact, with a little work, we could make it so that goal parameters starting with * are automatically converted to use {{plainlist}}. That may be worth doing because it will make adoption easier: it is easier to remember. Could then look like this:
|goals1 = [[Marco Materazzi|Materazzi]] {{goal|19}} |goals2 = * [[Zinedine Zidane|Zidane]] {{goal|7|pen.}} * [[Someone else]] {{goal|74}} |other_parameters
- versus
|goals1 = [[Marco Materazzi|Materazzi]] {{goal|19}} |goals2 = {{plainlist| * [[Zinedine Zidane|Zidane]] {{goal|7|pen.}} * [[Someone else]] {{goal|74}} }} |other_parameters
- Shall I put in an edit request for that? –Sygmoral (talk) 02:04, 18 May 2016 (UTC)
- That would be a good option. Walter Görlitz (talk) 06:24, 18 May 2016 (UTC)
- I have just implemented this for {{Football box collapsible}}! Assuming no one complains, I will soon create an edit request for this template. (I did notice that no spaces must appear before the *, otherwise it doesn't come out right.) –Sygmoral (talk) 03:49, 20 May 2016 (UTC)
- That would be a good option. Walter Görlitz (talk) 06:24, 18 May 2016 (UTC)
Template-protected edit request on 20 May 2016
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
See above: this code change allows people to list goals and penalties using normal list syntax (asterisk), which will be rendered in a {{plainlist}}, rather than putting <br> between them (as suggested by Walter Görlitz). The required change is that the parameters goal1
, goal2
, penalties1
and penalties2
are replaced with constructs like this:
{{#ifeq:{{str_sub|{{{goals1}}}|0|1}}|* |{{plainlist|{{{goals1}}}}} |{{{goals1|}}}}}
This code is already in use on the {{Football box collapsible}} template, as demonstrated by the last few matches on Belgium national football team results – 2010s. Thanks! –Sygmoral (talk) 04:04, 20 May 2016 (UTC)
- @Sygmoral: May you implement the change in this template's sandbox and update the testcases so your suggested change is visible? Thanks. — Andy W. (talk · ctb) 04:22, 20 May 2016 (UTC)
- @Andy M. Wang: done! I had to add a new test case (nr 3) because the new functionality can only be tested with new syntax. The other tests do show that it is backwards compatible, however. –Sygmoral (talk) 04:53, 20 May 2016 (UTC)
- @Sygmoral: Thanks! The change seems good for MOS:ACCESSIBILITY as you stated, and you have support, so this looks uncontroversial. I'm planning on applying the changes later once I take another look shortly (within 24 hours). Cheers, — Andy W. (talk · ctb) 05:34, 20 May 2016 (UTC)
- Went ahead and synced with Special:Diff/721182966. Tests looked great. Cheers, — Andy W. (talk · ctb) 06:20, 20 May 2016 (UTC)
- @Sygmoral: Thanks! The change seems good for MOS:ACCESSIBILITY as you stated, and you have support, so this looks uncontroversial. I'm planning on applying the changes later once I take another look shortly (within 24 hours). Cheers, — Andy W. (talk · ctb) 05:34, 20 May 2016 (UTC)
- @Andy M. Wang: done! I had to add a new test case (nr 3) because the new functionality can only be tested with new syntax. The other tests do show that it is backwards compatible, however. –Sygmoral (talk) 04:53, 20 May 2016 (UTC)
Adjustment to ID parameter
editThis edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Requesting to add {{#ifeq:{{str_sub|{{{id}}}|0|1}}|" |{{{id|}}}|"{{{id}}}"}}
(similar to this edit) to allow the ID's to not need quotations while still supporting instances where the quotation is included (and therefore preventing duplicate quotes). Secret Agent Julio (talk) 17:46, 21 July 2016 (UTC)
- Oh my, they require quotes right now? That isn't great design... :/ Is there a way to easily find all usages of this template with this recent new id parameter, so that we can just update them and then always add quotes in this template? –Sygmoral (talk) 17:53, 21 July 2016 (UTC)
- Yeah, definitely not the greatest idea. I know Qed237 brought it up here, so it sounds like the quotes were left as it was thought people would still include quotations? Either way, this prevents the duplicate quotes Redrose64 mentioned. I believe this was implemented during some work on Category:Pages using invalid self-closed HTML tags, so after only a week it has already been thoroughly implemented. I could try to see if the quotes could be removed via AWB, but for now this is probably the best solution. — Preceding unsigned comment added by alternate account of Secret Agent Julio (talk • contribs) 18:10, 21 July 2016 (UTC)
For now, we can put in something likeRead Redrose64's follow up on his talk. If adding quotes is not recommended, the request here is probably okay — Andy W. (talk · ctb) 18:18, 21 July 2016 (UTC) 18:30, 21 July 2016 (UTC){{#ifeq:{{str sub|{{{id}}}|0|1}}|"|[[Category:Some category name]]}}
(or some other string template if there's a better one than {{str sub old}}). After the instances of|id=
with '"' are corrected, the update would then be a simpler{{#if:{{{id|}}}|id="{{{id}}}" }}
probably.- User:Redrose64 didn't get the ping from the unsigned comment. Courtesy post — Andy W. (talk · ctb) 18:23, 21 July 2016 (UTC)
- Qed237 didn't get the ping from my unsigned comment. Courtesy post. Secret Agent Julio (talk) 19:05, 21 July 2016 (UTC)
- Yeah, definitely not the greatest idea. I know Qed237 brought it up here, so it sounds like the quotes were left as it was thought people would still include quotations? Either way, this prevents the duplicate quotes Redrose64 mentioned. I believe this was implemented during some work on Category:Pages using invalid self-closed HTML tags, so after only a week it has already been thoroughly implemented. I could try to see if the quotes could be removed via AWB, but for now this is probably the best solution. — Preceding unsigned comment added by alternate account of Secret Agent Julio (talk • contribs) 18:10, 21 July 2016 (UTC)
Enable "umpire" for pre-1881 matches?
editBefore 1881, there were no referees, with umpires as the only match officials.
This is a bit of a niche request, no doubt, but would it be possible in any way to have an option to show "Umpire" rather than "Referee" for these early matches? Thanks Grover cleveland (talk) 20:59, 30 January 2018 (UTC)
- Wouldn't it be "Umpires" (plural), since there were two umpires per game (one provided by each side)? – PeeJay 22:15, 30 January 2018 (UTC)
- It varied. For example, there was one umpire at the first FA Cup final. It later became customary for each team to provide its own umpire, which led to the introduction of the referee to settle disputes between the umpires. But you make a good point -- ideally we would have the option of both "umpire" and "umpires", although I'd be OK with just "umpire" for now. Grover cleveland (talk) 18:19, 2 February 2018 (UTC)
Template issues
editRestore template as of 22 July 2016, the changes should be discussed and tested further in the sandbox before being adopted, as there have been various issues caused by the latest edits. S.A. Julio (talk) 21:06, 6 April 2018 (UTC)
- S.A. Julio, it's impossible to judge whether a reversion is justified when you only state "there have been various issues". Nor does it help Matt Fitzpatrick fix the issues. Cabayi (talk) 07:06, 7 April 2018 (UTC)
- They've now responded, hopefully the alignment issue will be fixed soon. However, hopefully in the future the sandbox can be further utilised, the microdata and layout changes created a number of problems. S.A. Julio (talk) 15:03, 7 April 2018 (UTC)
- I've solved right-aligning the date and time on desktop while left-aligning on mobile — see sandbox and testcases. Before I take it live, I thought I'd ask if I should center the date and time in mobile? Centering the date and time in mobile wasn't possible in the previous layout, but it is possible now. Matt Fitzpatrick (talk) 04:21, 9 April 2018 (UTC)
- @Matt Fitzpatrick: Thanks, I'm not sure which would be preferable, whatever would make most sense. However, the time alignment still seems a bit strange, see 2018–19 UEFA Nations League A, where there are two lines for the time. Can this be right aligned as well? Thanks, S.A. Julio (talk) 00:03, 10 April 2018 (UTC)
- @S.A. Julio: I'll keep thinking of a CSS solution for this. Putting two different times breaks the data structure, though, so if this is a common format, maybe another parameter (time2?) may help? Another parameter would also make the CSS solution very easy. Matt Fitzpatrick (talk) 17:10, 16 April 2018 (UTC)
- I don't know if it's related, but there is a malformed
time
tag near the start of the code. pauli133 (talk) 11:38, 14 May 2018 (UTC)
- @Matt Fitzpatrick: Thanks, I'm not sure which would be preferable, whatever would make most sense. However, the time alignment still seems a bit strange, see 2018–19 UEFA Nations League A, where there are two lines for the time. Can this be right aligned as well? Thanks, S.A. Julio (talk) 00:03, 10 April 2018 (UTC)
Time formatting
editOn smaller screens (or half-width windows), the time field is left-justified and out of alignment with the date (as seen at 2018 FIFA World Cup Final, it happens when the time field is too long). SounderBruce 22:04, 11 July 2018 (UTC)
New Lua version
editI have updated this template to use Lua, which should reduce the template expansion complexity, but have no effect on the html output. I have temporarily saved the old version in the sandbox for comparison in the testcases. please let me know if you see any problems. Frietjes (talk) 19:49, 16 October 2018 (UTC)
- now using templatestyles. please let me know if you see any problems. Frietjes (talk) 14:41, 4 December 2018 (UTC)
- Frietjes, would it be possible to add a parameter to the module for a note below the scoreline? For example, see UEFA Euro 1968 final tournament#Italy vs Soviet Union and UEFA Euro 2016 qualifying Group I#Serbia v Albania. Then a
<br />
tag would no longer need to be used. S.A. Julio (talk) 20:24, 9 February 2019 (UTC)- S.A. Julio, sure. should we call it
scorenote
or ? Frietjes (talk) 17:03, 11 February 2019 (UTC)- Frietjes, sounds good. S.A. Julio (talk) 17:59, 11 February 2019 (UTC)
- S.A. Julio, now implemented. Frietjes (talk) 23:14, 11 February 2019 (UTC)
- Frietjes, sounds good. S.A. Julio (talk) 17:59, 11 February 2019 (UTC)
- S.A. Julio, sure. should we call it
- Frietjes, would it be possible to add a parameter to the module for a note below the scoreline? For example, see UEFA Euro 1968 final tournament#Italy vs Soviet Union and UEFA Euro 2016 qualifying Group I#Serbia v Albania. Then a
mobile-float-reset removed
editIn October 2018, .mobile-float-reset
was removed from MediaWiki:Mobile.css and Wikipedia:TemplateStyles was recommended instead. Please fix. --SocietyBox (talk) 20:37, 15 January 2019 (UTC)
a.e.t
editCan the a.e.t be made smaller because it is unacceptably large.--Sakiv (talk) 21:39, 13 March 2019 (UTC)
- What exactly is unacceptable about it, please? – PeeJay 08:51, 14 March 2019 (UTC)
- @PeeJay2K3: Only the score should be so prominent. The fact of when the win came is not as important as the score.--Sakiv (talk) 17:41, 14 March 2019 (UTC)
- I mean, that's a matter of opinion. Ideally, we shouldn't reduce the font size unless absolutely necessary because of accessibility requirements. – PeeJay 23:47, 14 March 2019 (UTC)
- @PeeJay2K3: Only the score should be so prominent. The fact of when the win came is not as important as the score.--Sakiv (talk) 17:41, 14 March 2019 (UTC)
agget/asget
editWho decided this was a good idea? There was never such a thing as "golden goal extra time" or "silver goal extra time", there was only ever "extra time". We do not need to specify that a game went to some kind of "special" extra time. – PeeJay 08:33, 21 March 2020 (UTC)
- Well "golden goal extra time" or "silver goal extra time" just refers to extra time under the golden/silver goal format, a number of sources have used this wording [1] [2] [3] [4] [5] [6] [7] [8]. This seems worth noting given the unique format, the term "asdet" is commonly used to denote matches using golden goal/sudden death rules. S.A. Julio (talk) 23:52, 21 March 2020 (UTC)
- Those terms are colloquial only. I'm not complaining about the use of "asdet" as that appears to have some official usage, but the others have none. Even in prose, I'm not specifically opposed to the usage of those terms, but the use of "agget" and "asget" are complete neologisms here. – PeeJay 08:37, 22 March 2020 (UTC)
report parameter edge case
editI have been trying to work around a problem with the current setup of the |report=
parameter, but my Lua skills are negligible. When the parameter starts with "http", an automatic link of the style Report is generated. This works fine, as long as nothing else is included after the URL. When a {{dead link}} template is included after the parameter value, such as at 2008 Caribbean Cup qualification, the result is a semi-broken link followed by a poorly formatted template rendering. Can anyone here adjust the code here so that in addition to looking for "http" at the start of the parameter value, the module also looks for any templates? If templates are found, the parameter should probably just be rendered without trying to make a link.
Note that this problem also exists in {{Baseballbox}} (cf Softball at the 2011 Pan American Games) and {{IceHockeybox}} (cf Canada at the 2012 Winter Youth Olympics). – Jonesey95 (talk) 19:25, 18 September 2021 (UTC)
- Jonesey95, I implemented the simple fix. we could probably do something more sophisticated and move the {{dead link}} after the link, but that would require more string processing. Frietjes (talk) 15:18, 23 September 2021 (UTC)
- Thanks! It looks like that solves the broken-link problem; if editors fix the dead links, the plain URL will no longer be displayed, so they will fix two problems with one edit. – Jonesey95 (talk) 15:33, 23 September 2021 (UTC)
- I have implemented the same fix at Module:Football box collapsible and a similar fix at {{Linescore}}. – Jonesey95 (talk) 15:43, 23 September 2021 (UTC)
- Thanks! It looks like that solves the broken-link problem; if editors fix the dead links, the plain URL will no longer be displayed, so they will fix two problems with one edit. – Jonesey95 (talk) 15:33, 23 September 2021 (UTC)
Location parameter
editA small suggestion: change the location parameter so that it will still display without the stadium; for articles such as 1958 FIFA World Cup qualification – UEFA Group 7, the stadium isn't listed (and might not be well documented). SounderBruce 08:15, 13 December 2022 (UTC)
Accessibility
editFrietjes, I hope you don't mind if I ping you. I'm inexperienced with Lua templates, and I see above that you handled the 2018 rewrite. I've tested an update to Module:Football box/sandbox. The live template creates a complex table, and screen readers (NVDA and VoiceOver) make a mistake with column headers and attribute all penalties to the home team because the penalties cell is technically in that column. Using the "headers" attribute makes it possible to manually assign the position. Rjjiii (talk) 18:52, 30 September 2023 (UTC)
- User:Rjjiii, thank you. your changes look good. the only possible problem will be if the total html output adds pages to Category:Pages where post-expand include size is exceeded since people love putting many of these on the same page. but, the only way to find out is to try. Frietjes (talk) 15:45, 2 October 2023 (UTC)
- While testing some pages, I realized this will result in multiple ids with the same name on some pages (and potential problems if those ids are referenced outside of this context), so disregard. Thank you for the reply though, Rjjiii (talk) 19:20, 2 October 2023 (UTC)
- So, my next thought on this was that the template needs something like the Lua equivalent of
{{{penaltyscore|}}}{{{attendance|}}}{{{score1|}}}{{{score2|}}}
added to eachtd
element'sid
to make them unique. I'm not sure how badly that will affect the pages that are heavily transcluding the template. I had intended to hack something in the sandbox and test, but real life is fairly intense at the moment, so I'm avoiding that opportunity for additional stress. I'm posting the idea here in case I do not come back around to it. Regards, Rjjiii (talk) 04:05, 4 October 2023 (UTC)
Yellow/red cards
editWould a cautions section being added to this make sense? Yoblyblob (talk) 16:59, 2 October 2023 (UTC)
- I don't think so. Cards don't directly contribute to the score. – PeeJay 15:26, 3 October 2023 (UTC)
What happened to the winning team being in Bold?
editNot sure when this changed, but years ago, the winning team was in bold and the non-winning team was not. Now all the teams are in bold making it more difficult to scan through a list of games and pick out the winner. --Trödel 20:54, 6 November 2023 (UTC)
- Both teams have always been in bold, as far as I can remember. – PeeJay 18:34, 7 November 2023 (UTC)
Report PDF icon issue
editHey guys, just noticed an issue with the infobox.
If the report is a PDF, it shows up with the PDF icon, but this seems to be an issue with a scoreline with less than two goal scorers, which has caused a scrollbar to appear - This is what I mean. - Is there a fix for this? J man708 (talk) 11:02, 20 November 2023 (UTC)
Adding match reports to References
editIs there a way to automatically add URLs from match reports to the References section, for example code the URL inside <ref></ref>
tags? There is a current discussion at Talk:2026 FIFA World Cup qualification (OFC)#WP:CITE regarding this. Courtesy pinging @Stevie fae Scotland, YangerAAS, Yoblyblob, and Lee Vilenski: as participants in the current or previous discussions. — Jkudlick ⚓ (talk) 17:57, 8 August 2024 (UTC)
- Very likely yes, it would have to be done at Module:Football box, but it automatically can add the square brackets to make an external link, so probably. I would not know how though Yoblyblob (Talk) :) 18:00, 8 August 2024 (UTC)
- It already creates the external link, but I want to know if it can be changed to conform with WP:CITE and add it to the references. — Jkudlick ⚓ (talk) 18:11, 8 August 2024 (UTC)
- You'd have to edit the module (or more likely explain to a template editor what needs to change). Lee Vilenski (talk • contribs) 18:22, 8 August 2024 (UTC)
- Thank you. I'll make the request now. — Jkudlick ⚓ (talk) 15:51, 9 August 2024 (UTC)
- You'd have to edit the module (or more likely explain to a template editor what needs to change). Lee Vilenski (talk • contribs) 18:22, 8 August 2024 (UTC)
- It already creates the external link, but I want to know if it can be changed to conform with WP:CITE and add it to the references. — Jkudlick ⚓ (talk) 18:11, 8 August 2024 (UTC)
Template-protected edit request on 9 August 2024
editThis edit request to Module:Football box and Module:Football box collapsible has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
I am requesting that the module code be edited to place the URL or {{Cite web}} entered as the |report=
parameter within <ref> </ref>
tags rather than just within [ ]
brackets. This will help comply with the WP:CITE policy and WP:LINKROT procedure. There is support for this at WP:FOOTY as noted at this discussion from this past May which also refers to this discussion from June and July 2023. This should populate these articles into this search of articles with bare URL references if only the URL is used.
If this change is made, I would request that the relevant documentation be updated to encourage the use of {{Cite web}} in the |report=
parameter to avoid bare URLs and to help prevent link rot. I would also request that a |report2=
parameter be added for those cases where two reports are referenced, e.g. match reports from FIFA and CONMEBOL. — Jkudlick ⚓ (talk) 15:51, 9 August 2024 (UTC)
- Jkudlick, I think it would be better for editors to use
|report=<ref> </ref>
instead of having the template wrap the url inside of<ref>...</ref>
for a few reasons: (1) the functionality is more transparent and (2) it allows the use of shared references and (3) you can put multiple references in the same|report=
input. but, others may disagree. Frietjes (talk) 19:07, 9 August 2024 (UTC)- @Frietjes: I understand what you mean about functionality transparency, and I have also entered multiple match reports on several occasions. I tested use of the
<ref>...</ref>
tags on User:Jkudlick/sandbox#Test of Template:Football box, and the only text that appears is the superscript footnote indicator with no additional text. — Jkudlick ⚓ (talk) 20:08, 9 August 2024 (UTC)- Jkudlick, correct, what ever text you put in
|report=
is what appears in that cell. the only time the text is modified is if the text starts with http. Frietjes (talk) 14:21, 12 August 2024 (UTC)- @Frietjes: I have edited some of the code at Module:Sandbox/Jkudlick with tested outputs at User:Jkudlick/sandbox/Football box tests. This does not change the current display unless
|title=
is used to allow the minimum parameters for {{Cite web}}. It also still allows for a fully custom entry in|report=
. Would this be suitable? — Jkudlick ⚓ (talk) 18:02, 17 September 2024 (UTC)- I don't really see the advantage of using
|report = https://... | title = Report title
vs. using|report = <ref>{{cite web|url=https://... | title = Report title}}</ref>
to add a<ref>...</ref>
wrapped citation. as I said above, the later seems better to me: (1) the functionality is more transparent and (2) it allows the use of shared references and (3) you can put multiple references in the same|report=
input. Maybe get feedback from others? Frietjes (talk) 19:09, 17 September 2024 (UTC)- No worries. It does seem like too much work for not much return. — Jkudlick ⚓ (talk) 19:21, 17 September 2024 (UTC)
- I don't really see the advantage of using
- @Frietjes: I have edited some of the code at Module:Sandbox/Jkudlick with tested outputs at User:Jkudlick/sandbox/Football box tests. This does not change the current display unless
- Jkudlick, correct, what ever text you put in
- @Frietjes: I understand what you mean about functionality transparency, and I have also entered multiple match reports on several occasions. I tested use of the
- Not done for now: please establish a consensus for this alteration before using the
{{Edit template-protected}}
template. --Ahecht (TALK
PAGE) 17:55, 17 September 2024 (UTC)
Simplify generating the |id= parameter
edit@Frietjes: I was wondering, could there be a simplify adding IDs to football boxes without having to define the parameter for every usage? For example, if |id=auto
, an ID would be generated for the match in the format: "[team1] v [team2]". For the purposes of the team names used in the ID, this would require stripping down the team1/team2 parameters of any images (flagicons), references, HTML tags, bolding/italic code, etc, and then using only the display text of the wikilink. Potentially this could even be done by default if no |id=
parameter is present, though I'm unsure if this would cause any disruptions with existing anchors.
I wasn't sure if adding such a feature would be reasonable, or if it would negatively impact the module performance. Thanks, S.A. Julio (talk) 21:22, 18 September 2024 (UTC)
- S.A. Julio, yes, we could definitely try to automate the anchor generation. LUA is pretty efficient, so I don't think there would be a real performance penalty in terms of processing. the only problem we could have would be if total amount of html generated caused a page to go over a "post expand size limit". but we could always try making this always on and see what happens. if you point me to a page using these ids, I can work on something in the module sandbox. Frietjes (talk) 23:34, 18 September 2024 (UTC)
- on a related topic, do you know if we really need the "schema" generated by the module (see microdata, search the html output, or search the module for "schema"). if we got rid of the schema, that would cut down on the amount of html being generated. Frietjes (talk)
- Alright great, see Template:Football box/testcases#Test case 2. As far as the microdata, I'm not extremely familiar in the area, but I don't necessarily see tremendous value in it. Microformats are useful, but I'm not certain the use of microdata here is all that beneficial vs. the added HTML it generates. S.A. Julio (talk) 00:32, 19 September 2024 (UTC)
- S.A. Julio , thank you for the examples, I put something in Module:Football box/sandbox that seems to work for those cases. Frietjes (talk) 14:58, 19 September 2024 (UTC)
- @Frietjes: Great, thank you! Do you think there would be any issues if these anchors were automatically generated for templates which do not have
|id=
set? A few articles might have conflicting anchors but I can't imagine many. Also, it could be very useful is if Module:Sports results had a feature to complement this, allowing for links to be automatically generated in this format (if a parameter such as|generate_links=
is set, while not overwriting any existing links). Thanks, S.A. Julio (talk) 19:53, 19 September 2024 (UTC)- S.A. Julio, I like the idea of having the anchors there all the time. I could imagine cases where you have a tournament with a round-robin stage followed by an elimination stage (or with double elimination) that you could have teams playing each other more than once with the same ordering. but, as you said, I don't think this is common. I will update the sandbox to make this on all the time. as for sports results, sure, we could probably add a
|generate_match_links=
or something like that. Frietjes (talk) 20:02, 19 September 2024 (UTC) - according to Template:Anchor, duplicate anchors are invalid HTML, so this issue should probably be resolved before turning this on for all uses. I am going back to the
|id=auto
for now in the sandbox. Frietjes (talk) 20:07, 19 September 2024 (UTC)- @Frietjes: Alright, we can wait on that for now, I'll see if there could be any resolutions. In the meantime, while not an 'elegant' or ideal solution, is there any way the anchors could be generated automatically if a certain string is found in the article title? For example if the title contains 'group stage', 'qualifying', 'knockout stage', etc. These types of articles should never result in duplicate anchors, and is where the vast majority of the ID parameters are currently being used. S.A. Julio (talk) 20:22, 19 September 2024 (UTC)
- yes, it is possible to look for expressions in the page title. I don't recall if that the pagename query is expensive. if it is expensive, it could cause a problem when there are hundreds of calls on one page. in any event, I am going to be offline for a couple weeks, so I won't be able to look at this in the immediate future. Frietjes (talk) 14:59, 20 September 2024 (UTC)
- @Frietjes: Alright, thanks for your help. From what I could tell, calling the pagename did not seem to expensive, so I went ahead and added the feature, hopefully I did this all correctly? And when you're back and have a chance, would you be able to check out the change I made to the sandbox of Module:Sports results, and whether this would be alright to apply? Thanks, S.A. Julio (talk) 04:44, 25 September 2024 (UTC)
- yes, it is possible to look for expressions in the page title. I don't recall if that the pagename query is expensive. if it is expensive, it could cause a problem when there are hundreds of calls on one page. in any event, I am going to be offline for a couple weeks, so I won't be able to look at this in the immediate future. Frietjes (talk) 14:59, 20 September 2024 (UTC)
- @Frietjes: Alright, we can wait on that for now, I'll see if there could be any resolutions. In the meantime, while not an 'elegant' or ideal solution, is there any way the anchors could be generated automatically if a certain string is found in the article title? For example if the title contains 'group stage', 'qualifying', 'knockout stage', etc. These types of articles should never result in duplicate anchors, and is where the vast majority of the ID parameters are currently being used. S.A. Julio (talk) 20:22, 19 September 2024 (UTC)
- S.A. Julio, I like the idea of having the anchors there all the time. I could imagine cases where you have a tournament with a round-robin stage followed by an elimination stage (or with double elimination) that you could have teams playing each other more than once with the same ordering. but, as you said, I don't think this is common. I will update the sandbox to make this on all the time. as for sports results, sure, we could probably add a
- @Frietjes: Great, thank you! Do you think there would be any issues if these anchors were automatically generated for templates which do not have
- S.A. Julio , thank you for the examples, I put something in Module:Football box/sandbox that seems to work for those cases. Frietjes (talk) 14:58, 19 September 2024 (UTC)
- Alright great, see Template:Football box/testcases#Test case 2. As far as the microdata, I'm not extremely familiar in the area, but I don't necessarily see tremendous value in it. Microformats are useful, but I'm not certain the use of microdata here is all that beneficial vs. the added HTML it generates. S.A. Julio (talk) 00:32, 19 September 2024 (UTC)