-
Notifications
You must be signed in to change notification settings - Fork 411
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make
CueSerializationTest
more realistic
Serializing bitmap cues is currently broken, but this test is incorrectly passing. This change makes two changes to introduce the same failure (both changes are necessary, each one alone still passes): 1. Move from Robolectric to an instrumentation test. 2. Trigger the `Bitmap` to be serialized using a file descriptor, either by calling `Bitmap.asShared` in the test when constructing the `Cue`, or constructing the `Bitmap` from a 'real' image byte array instead a 1x1 token image. Issue: #836 PiperOrigin-RevId: 585643486
- Loading branch information
1 parent
5f27b18
commit 63062a9
Showing
3 changed files
with
58 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- Copyright (C) 2016 The Android Open Source Project | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
|
||
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:tools="http://schemas.android.com/tools" | ||
package="androidx.media3.extractor.test"> | ||
|
||
<uses-sdk/> | ||
|
||
<application | ||
android:name="androidx.multidex.MultiDexApplication" | ||
android:allowBackup="false" | ||
tools:ignore="MissingApplicationIcon,HardcodedDebugMode" | ||
android:usesCleartextTraffic="true"/> | ||
|
||
<instrumentation | ||
android:targetPackage="androidx.media3.extractor.test" | ||
android:name="androidx.test.runner.AndroidJUnitRunner"/> | ||
|
||
</manifest> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters