HomePhabricator

CX Dashboard suggestion: only retry a few times

Tags
None
Referenced Files
None
Subscribers
None

Description

CX Dashboard suggestion: only retry a few times

All three suggestions fetchers (edits, popular, topics) had infinite
retries when trying to fetch page and section recommendations.

Retries are generally justified for suggestions each API call
may not result in enough recommendations due to the quality
of different seeds and the effect of client-side validation.

Retries for failing APIs, especially for capacity issues,
are not recommended as they can exacerbate the issue.

This patch introduces a 'retry' helper to re-execute the
fetching logic until we have enough suggestions but not
exceeding a small number of retries, currently hardcoded
to 5.

Change-Id: I73680422c4cbaa7f2c9784bc5c3ce876e6a808f4

Details

Provenance
SBissonAuthored on Sep 24 2024, 3:21 PM
ngkountasCommitted on Sep 24 2024, 9:44 PM
Parents
rECTX6add54b179af: Fix: lint
Branches
Unknown
Tags
Unknown
ChangeId
I73680422c4cbaa7f2c9784bc5c3ce876e6a808f4

Event Timeline