Add option to use BigQuery Storage API from IPython magics #7640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BigQuery tests are passing. Other failures appear to be Kokoro-induced flakes. |
alixhami
requested changes
Apr 2, 2019
bigquery/tests/unit/test_magics.py
Outdated
| @pytest.mark.skipIf( | ||
| bigquery_storage_v1beta1 is None, "Requires `google-cloud-bigquery-storage`" | ||
| ) | ||
| def test_bigquery_magic_with_bqstorage(monkeypatch): |
There was a problem hiding this comment.
Can you add a test or update an existing test asserting that the BQ storage API is not used when the new parameter is not set?
Construct and use a BigQuery Storage API client when either the context.use_bqstorage_api property is set, or the --use_bqstorage_api parameter is passed into the magic.
…hon into bqstorage-magics
alixhami
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct and use a BigQuery Storage API client when either the
context.use_bqstorage_apiproperty is set, or the--use_bqstorage_apiparameter is passed into the magic.